Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modules bootstrap refactoring #29937

Closed
wants to merge 14 commits into from
Closed

Modules bootstrap refactoring #29937

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4c8d820
module: refactor modules bootstrap
bfarias-godaddy Sep 30, 2019
76b4153
bootstrap complete before user code
guybedford Oct 11, 2019
eb97b1c
fixup for merge
guybedford Oct 11, 2019
31bb33f
avoid unnecessary test change
guybedford Oct 11, 2019
7c47066
remove unnecessary test change
guybedford Oct 11, 2019
0f6c8c0
ensure warning triggers immediately
guybedford Oct 11, 2019
2d4dfef
keep CJS runMain, move main to process
guybedford Oct 13, 2019
fe0c923
defaultOnly comment
guybedford Oct 13, 2019
c750488
move main functions into pre_execution
guybedford Oct 14, 2019
ad0f5c7
pr feedback
guybedford Oct 15, 2019
29d1d9c
async_hooks fix
guybedford Oct 15, 2019
91a3772
esm loader initialize as async
guybedford Oct 15, 2019
f638d29
fixup worker test
guybedford Oct 16, 2019
673257d
feedback
guybedford Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion test/parallel/test-bootstrap-modules.js
View file
Open in desktop
Expand Up @@ -92,7 +92,6 @@ if (common.isMainThread) {
expectedModules.add('NativeModule internal/streams/state');
expectedModules.add('NativeModule internal/worker');
expectedModules.add('NativeModule internal/worker/io');
expectedModules.add('NativeModule module');
Trott marked this conversation as resolved.
Show resolved Hide resolved
expectedModules.add('NativeModule stream');
expectedModules.add('NativeModule worker_threads');
}
Expand Down