Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: increase MAX_HWM #29938

Closed
wants to merge 7 commits into from
Closed

Commits on Oct 20, 2019

  1. stream: increase MAX_HWM

    MAX_HWM was added in 9208c89 where the highwatermark was changed to
    always increase in steps of highest power of 2 to prevent increasing
    hwm excessivly in tiny amounts.
    
    Why a limit was added on the highwatermark is unclear but breaks
    existing usage where a larger read size is used. The invariant for
    read(n) is that a buffer of size n is always returned. Considering
    a maximum ceiling on the buffer size breaks this invariant.
    
    This PR significantly increases the limit to make it less likely to
    break the previous invariant and also documents the limit.
    
    Fixes: nodejs#29933
    ronag committed Oct 20, 2019
    Copy the full SHA
    d05b777 View commit details
    Browse the repository at this point in the history
  2. fixup: added range check

    ronag committed Oct 20, 2019
    Copy the full SHA
    f873bee View commit details
    Browse the repository at this point in the history
  3. fixup

    ronag committed Oct 20, 2019
    Copy the full SHA
    7539c6f View commit details
    Browse the repository at this point in the history
  4. fixup

    ronag committed Oct 20, 2019
    Copy the full SHA
    a51e404 View commit details
    Browse the repository at this point in the history
  5. fixup: doc nit

    ronag committed Oct 20, 2019
    Copy the full SHA
    98b7702 View commit details
    Browse the repository at this point in the history
  6. fixup: use primordials

    ronag committed Oct 20, 2019
    Copy the full SHA
    ba28187 View commit details
    Browse the repository at this point in the history
  7. fixup: use hex

    ronag committed Oct 20, 2019
    Copy the full SHA
    a5b6642 View commit details
    Browse the repository at this point in the history