Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: --enable-source-maps and prepareStackTrace are incompatible #30046

Closed
wants to merge 3 commits into from
Closed

doc: --enable-source-maps and prepareStackTrace are incompatible #30046

wants to merge 3 commits into from

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Oct 21, 2019

document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see #29994

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@bcoe
doc: --enable-source-maps and prepareStackTrace are incompatible
d63d519 
document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see nodejs#29994
@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Oct 21, 2019
devsnek
devsnek approved these changes Oct 21, 2019
View reviewed changes
doc/api/cli.md Outdated Show resolved Hide resolved
joyeecheung
joyeecheung reviewed Oct 21, 2019
View reviewed changes
doc/api/cli.md Outdated Show resolved Hide resolved
cjihrig
cjihrig approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the suggestions incorporated.

@targos targos mentioned this pull request Oct 22, 2019
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26150/

bcoe added a commit that referenced this pull request Oct 23, 2019
@bcoe
doc: --enable-source-maps and prepareStackTrace are incompatible
b964e77 
document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see #29994

PR-URL: #30046
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@bcoe
Copy link
Contributor Author

bcoe commented Oct 23, 2019

Landed in b964e77

@bcoe bcoe closed this Oct 23, 2019
@bcoe bcoe deleted the doc-29994 branch October 23, 2019 06:07
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
@bcoe @MylesBorins
doc: --enable-source-maps and prepareStackTrace are incompatible
89a89fb 
document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see #29994

PR-URL: #30046
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
@bcoe @MylesBorins
doc: --enable-source-maps and prepareStackTrace are incompatible
89b9115 
document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see #29994

PR-URL: #30046
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 23, 2019
Merged
@addaleax addaleax added the source maps Issues and PRs related to source map support. label Nov 2, 2019
targos pushed a commit that referenced this pull request Nov 8, 2019
@bcoe @targos
doc: --enable-source-maps and prepareStackTrace are incompatible
0e2de0f 
document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see #29994

PR-URL: #30046
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@bcoe @targos
doc: --enable-source-maps and prepareStackTrace are incompatible
ee66859 
document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see #29994

PR-URL: #30046
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@targos targos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
@bcoe @targos
doc: --enable-source-maps and prepareStackTrace are incompatible
22e10fd 
document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see #29994

PR-URL: #30046
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@devsnek devsnek devsnek approved these changes

@addaleax addaleax Awaiting requested review from addaleax

Assignees
No one assigned
Labels
cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. source maps Issues and PRs related to source map support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bcoe @nodejs-github-bot @lpinca @cjihrig @joyeecheung @devsnek @addaleax