Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: cherry-pick ed40ab1 #30064

Closed
wants to merge 1 commit into from
Closed

deps: V8: cherry-pick ed40ab1 #30064

wants to merge 1 commit into from

Commits on Oct 22, 2019

  1. deps: V8: cherry-pick ed40ab1

    Original commit message:
    
        [regexp] Fix the order of named captures on the groups object
    
        Named capture properties on the groups object should be ordered by the
        capture index (and not alpha-sorted). This was accidentally broken in
        https://crrev.com/c/1687413.
    
        Bug: v8:9822,v8:9423
        Change-Id: Iac6f866f077a1b7ce557ba47e8ba5d7e7014b3ce
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864829
        Auto-Submit: Jakob Gruber <jgruber@chromium.org>
        Reviewed-by: Peter Marshall <petermarshall@chromium.org>
        Commit-Queue: Peter Marshall <petermarshall@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#64306}
    
    Refs: v8/v8@ed40ab1
    Fixes: nodejs#29878
    targos committed Oct 22, 2019
    Copy the full SHA
    232697f View commit details
    Browse the repository at this point in the history