Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use -latomic on macOS #30099

Closed
wants to merge 1 commit into from
Closed

Don't use -latomic on macOS #30099

wants to merge 1 commit into from

Commits on Oct 23, 2019

  1. Don't use -latomic on macOS 

    Fixes build when using open-source clang. (Builds using Apple clang from Xcode
7 and later were already working, due to the fact that node's build system
misidentifies their llvm_version as "0.0" and thus the flag wasn't being added.)

Closes #30093
    @ryandesign
    ryandesign committed Oct 23, 2019
    Copy the full SHA
    dcfe2b2 View commit details
    Browse the repository at this point in the history