Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: support readable hwm in IncomingMessage #30135

Merged
merged 1 commit into from Oct 30, 2019
Merged

http: support readable hwm in IncomingMessage #30135

merged 1 commit into from Oct 30, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 26, 2019 •
edited

This commit causes http.IncomingMessage instances to set their readableHighWaterMark value the same value used in the underlying socket.

FWIW, http.OutgoingMessage already uses the socket to set its writableHighWaterMark.

Fixes: #30107

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Oct 26, 2019
@cjihrig cjihrig mentioned this pull request Oct 26, 2019
Closed
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 26, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26212/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 26, 2019 •
edited by cjihrig

CI: https://ci.nodejs.org/job/node-test-pull-request/26215/ 💛

@cjihrig
Copy link
Contributor Author

cjihrig commented Oct 29, 2019

Before I land this, is anyone opposed to it landing as semver-patch? If we treat it as a semver-major, then it would require one more TSC reviewer.

@cjihrig
http: support readable hwm in IncomingMessage
11276af 
This commit causes http.IncomingMessage instances to set their
readableHighWaterMark value the same value used in the underlying
socket.

PR-URL: nodejs#30135
Fixes: nodejs#30107
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@cjihrig cjihrig merged commit 11276af into nodejs:master Oct 30, 2019
@cjihrig cjihrig deleted the rhwm branch October 30, 2019 14:33
targos pushed a commit that referenced this pull request Nov 5, 2019
@cjihrig @targos
http: support readable hwm in IncomingMessage
2505f67 
This commit causes http.IncomingMessage instances to set their
readableHighWaterMark value the same value used in the underlying
socket.

PR-URL: #30135
Fixes: #30107
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Nov 5, 2019
Merged
@targos targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 8, 2019
MylesBorins pushed a commit that referenced this pull request Jan 12, 2020
@cjihrig @MylesBorins
http: support readable hwm in IncomingMessage
c2757d1 
This commit causes http.IncomingMessage instances to set their
readableHighWaterMark value the same value used in the underlying
socket.

PR-URL: #30135
Fixes: #30107
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@cjihrig @BethGriggs
http: support readable hwm in IncomingMessage
86369e4 
This commit causes http.IncomingMessage instances to set their
readableHighWaterMark value the same value used in the underlying
socket.

PR-URL: #30135
Fixes: #30107
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
@0807Jpatel 0807Jpatel mentioned this pull request Apr 9, 2020
Closed
@ronag
Copy link
Member

ronag commented Jan 6, 2021 •
edited

This seems a bit strange to me. Won't the effective buffering now be 2 * socket.readableHighWaterMark or socket.readableHighWaterMark + 16k (depending on whether socket.consume is used)? I kind of think highWaterMark on IncomingMessage should be 0? @mcollina wdyt?

@mcollina
Copy link
Member

mcollina commented Jan 7, 2021

I'm generically ok in more buffering, I don't see a problem with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@trivikr trivikr trivikr approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Option to configure highWaterMark of HTTP response
9 participants
@cjihrig @nodejs-github-bot @ronag @mcollina @addaleax @lpinca @trivikr @ZYSzys @targos