Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v13.1.0 release proposal #30262

Merged
merged 65 commits into from Nov 5, 2019
Merged

v13.1.0 release proposal #30262

merged 65 commits into from Nov 5, 2019

Commits on Oct 23, 2019

  1. crypto: add Hash.prototype.copy() method

    Make it possible to clone the internal state of a Hash object
    into a new Hash object, i.e., to fork the state of the object.
    
    Fixes: #29903
    
    PR-URL: #29910
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    bnoordhuis authored and MylesBorins committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    1d03df4 View commit details
    Browse the repository at this point in the history
  2. dgram: add source-specific multicast support

    This adds RFC 4607 support for IPv4 and IPv6.
    
    Co-Authored-By: Nicolas Thumann <46975855+n-thumann@users.noreply.github.com>
    Co-Authored-By: Rich Trott <rtrott@gmail.com>
    PR-URL: #15735
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    3 people authored and MylesBorins committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    a63f7e7 View commit details
    Browse the repository at this point in the history
  3. doc: make YAML matter consistent in crypto.md

    This fixes YAML that gets incorrectly processed by our tooling.
    
    Refs: #29910 (comment)
    
    PR-URL: #30016
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Trott authored and MylesBorins committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    39070bb View commit details
    Browse the repository at this point in the history
  4. cli: add --trace-uncaught flag

    Add a flag that makes Node.js print the stack trace at the
    time of *throwing* uncaught exceptions, rather than at the
    creation of the `Error` object, if there is any.
    
    This is disabled by default because it affects GC behavior.
    
    PR-URL: #30025
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    addaleax authored and MylesBorins committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    5ca5864 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2019

  1. inspector: turn platform tasks that outlive Agent into no-ops

    Turn tasks scheduled on the `v8::Isolate` or on the given platform
    into no-ops if the underlying `MainThreadInterface` has gone away
    before the task could be run (which would happen when the
    `Environment` instance and with it the `inspector::Agent` instance
    are destroyed).
    
    This addresses an issue that Electron has been having with
    inspector support, and generally just seems like the right thing
    to do, as we may not fully be in control of the relative timing
    of Environment teardown, platform tasksexecution, and the
    execution of `RequestInterrupt()` callbacks (although
    the former two always happen in the same order in our own code).
    
    PR-URL: #30031
    Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    addaleax authored and targos committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    f01c5c5 View commit details
    Browse the repository at this point in the history
  2. build: python3 support for configure

    PR-URL: #30047
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    rvagg authored and targos committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    5ba842b View commit details
    Browse the repository at this point in the history
  3. crypto: guard with OPENSSL_NO_GOST

    PR-URL: #30050
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    codebytere authored and targos committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    8b75aab View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2019

  1. deps: V8: cherry-pick ed40ab1

    Original commit message:
    
        [regexp] Fix the order of named captures on the groups object
    
        Named capture properties on the groups object should be ordered by the
        capture index (and not alpha-sorted). This was accidentally broken in
        https://crrev.com/c/1687413.
    
        Bug: v8:9822,v8:9423
        Change-Id: Iac6f866f077a1b7ce557ba47e8ba5d7e7014b3ce
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864829
        Auto-Submit: Jakob Gruber <jgruber@chromium.org>
        Reviewed-by: Peter Marshall <petermarshall@chromium.org>
        Commit-Queue: Peter Marshall <petermarshall@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#64306}
    
    Refs: v8/v8@ed40ab1
    Fixes: #29878
    
    PR-URL: #30064
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    targos committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    0d9ae1b View commit details
    Browse the repository at this point in the history
  2. module: resolve self-references

    Adds the ability to `import` or `require` a package from within its
    own source code. This allows tests and examples to be written using
    the package name, making them easier to reuse by consumers of the
    package.
    
    Assuming the `name` field in `package.json` is set to `my-pkg`, its
    test could use `require('my-pkg')` or `import 'my-pkg'` even if
    there's no `node_modules/my-pkg` while testing the package itself.
    
    An important difference between this and relative specifiers like
    `require('../')` is that self-references use the public interface
    of the package as defined in the `exports` field while relative
    specifiers don't.
    
    This behavior is guarded by a new experimental flag
    (`--experimental-resolve-self`).
    
    PR-URL: #29327
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    jkrems authored and targos committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    edfbee3 View commit details
    Browse the repository at this point in the history
  3. deps: V8: cherry-pick c721203

    Original commit message:
    
        Add missing null condition in Proxy GetPrototypeof
    
        Bug: v8:9781
        Change-Id: I1f82a828f103cc2aa3f9553214f6b4867ffc3b17
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829897
        Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com>
        Reviewed-by: Georg Neis <neis@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#64049}
    
    Refs: v8/v8@c721203
    Fixes: #29730
    
    PR-URL: #30065
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    targos committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    1cfa98c View commit details
    Browse the repository at this point in the history
  4. test: verify npm compatibility with releases

    This adds a test that makes sure than running `npm` from a release does
    not print warnings to the console.
    
    PR-URL: #30082
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    targos committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    a03809d View commit details
    Browse the repository at this point in the history
  5. doc: add legendecas to collaborators

    PR-URL: #30115
    Fixes: #30000
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
    legendecas authored and targos committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    ea9d125 View commit details
    Browse the repository at this point in the history
  6. src: allow inspector without v8 platform

    Embedders sometimes want to take control of V8 platform initialization
    themselves, so we wouldn't want to experience an error if
    NODE_USE_V8_PLATFORM was false necessarily. Instead, we can also gate
    it with HAVE_INSPECTOR to allow embedders to define that themselves
    and use Inspector without NODE_USE_V8_PLATFORM.
    
    PR-URL: #30049
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    codebytere authored and targos committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    fd0aded View commit details
    Browse the repository at this point in the history
  7. build: prefer python 3 over 2 for configure

    Change python search order to python3*, then python, then python2*.
    
    PR-URL: #30091
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: João Reis <reis@janeasystems.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    sam-github authored and targos committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    cedad02 View commit details
    Browse the repository at this point in the history
  8. build: vcbuild uses default Python, not Py2

    vcbuild now searches for the first python.exe found, and uses it, where
    it used to look for Python 2 first.
    
    PR-URL: #30091
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: João Reis <reis@janeasystems.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    joaocgreis authored and targos committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    8980d8c View commit details
    Browse the repository at this point in the history
  9. test: use arrow functions for callbacks

    Use arrow functions for callbacks in
    test/addons/make-callback-recurse/test.js.
    
    PR-URL: #30069
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    mpark86 authored and targos committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    1d9f427 View commit details
    Browse the repository at this point in the history
  10. n-api,doc: add info about building n-api addons

    Adds information about tools available for building N-API addons.
    
    Fixes: nodejs/abi-stable-node#384
    PR-URL: #30032
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    jschlight authored and targos committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    93b1bb8 View commit details
    Browse the repository at this point in the history
  11. async_hooks: only emit after for AsyncResource if stack not empty

    We clear the async id stack inside the uncaught exception handler and
    emit `after` events in the process, so we should not emit `after`
    a second time from the `runInAsyncScope()` code.
    
    This should match the behaviour we have in C++.
    
    Fixes: #30080
    
    PR-URL: #30087
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    addaleax authored and targos committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    4458378 View commit details
    Browse the repository at this point in the history
  12. doc: remove dashes

    The use of dashes -- in general, but especially in our docs -- can be
    problematic. It is used inconsistently and there is always another form
    of punctuation that is as good or better for the situation. In an effort
    to reduce the number of variations we use to display the same types of
    information, remove the various uses of dashes from the documentation.
    
    PR-URL: #30101
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and targos committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    45c70a9 View commit details
    Browse the repository at this point in the history
  13. doc: delete "a number of" things in the docs

    Delete "a number of" phrases in the docs. See what I did there? Ha ha.
    Ha ha. Ha. ...heh.. <clears throat/>
    
    PR-URL: #30103
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and targos committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    381c6cd View commit details
    Browse the repository at this point in the history
  14. doc,n-api: sort bottom-of-the-page references

    Use `tail -n 102 doc/api/n-api.md | LC_ALL=C sort -u` to establish a
    systematic order for the references.
    
    PR-URL: #30124
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: legendecas <legendecas@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Gabriel Schulhof authored and targos committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    32a5389 View commit details
    Browse the repository at this point in the history
  15. doc: revise os.md

    Revise os.md, mostly making it more concise. In one case, process.md was
    revised as well to be consistent with a revision in os.md.
    
    PR-URL: #30102
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and targos committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    9a71091 View commit details
    Browse the repository at this point in the history
  16. deps: V8: backport 777fa98

    Original commit message:
    
        Make SetSyntheticModuleExport throw instead of crash for nonexistent export name
    
        Per spec, Module::SetSyntheticModuleExport should throw a ReferenceError
        when called with an export name that was not supplied when constructing
        that SyntheticModule.  Instead, the current implementation crashes with
        a failed CHECK().
    
        Add a new Module::SyntheticModuleSetExport that throws (without an ensuing
        crash) for this case, and deprecate the old
        Module::SetSyntheticModuleExport.
    
        Bug: v8:9828
        Change-Id: I3b3d353064c3851882781818099bd8f6ee74c809
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1860996
        Reviewed-by: Adam Klein <adamk@chromium.org>
        Reviewed-by: Georg Neis <neis@chromium.org>
        Commit-Queue: Dan Clark <daniec@microsoft.com>
        Cr-Commit-Position: refs/heads/master@{#64438}
    
    Refs: v8/v8@777fa98
    
    PR-URL: #30062
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    targos committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    f3d00c5 View commit details
    Browse the repository at this point in the history
  17. src: fix crash with SyntheticModule#setExport

    Use the new non-deprecated V8 API for that.
    
    PR-URL: #30062
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    targos committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    d78e317 View commit details
    Browse the repository at this point in the history
  18. doc: remove "it is important to" phrasing

    Instead of telling someone "It is important to do X", just tell them to
    "Do X."
    
    PR-URL: #30108
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and targos committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    621eaf9 View commit details
    Browse the repository at this point in the history
  19. tools: doc: improve async workflow of generate.js

    Use fs.promises for read and write file
    Use unified().process wich is async instead processSync
    html and json are write in parallel
    errors are logged and exit process with `1` code
    
    Fixes: #30090
    
    PR-URL: #30106
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    tpoisseau authored and targos committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    a375754 View commit details
    Browse the repository at this point in the history
  20. doc: claim NODE_MODULE_VERSION=80 for Electron 9

    PR-URL: #30052
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    MarshallOfSound authored and targos committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    d91d270 View commit details
    Browse the repository at this point in the history
  21. doc: adjust code sample for stream.finished

    PR-URL: #29983
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    imcotton authored and targos committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    3c23224 View commit details
    Browse the repository at this point in the history
  22. doc: remove incorrect and outdated example

    PR-URL: #30138
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    tniessen authored and targos committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    e4ab6fc View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2019

  1. fs: add bufferSize option to fs.opendir()

    Add an option that controls the size of the internal
    buffer.
    
    Fixes: #29941
    
    PR-URL: #30114
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    addaleax authored and targos committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    07b5584 View commit details
    Browse the repository at this point in the history
  2. tools: update ESLint to 6.6.0

    Update ESLint to 6.6.0
    
    PR-URL: #30123
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    cjihrig authored and targos committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    d549a34 View commit details
    Browse the repository at this point in the history
  3. cli: whitelist new V8 flag in NODE_OPTIONS

    Explicitly whitelists --disallow-code-generation-from-strings in
    NODE_OPTIONS as a new V8 flag. This flag prevents strings like eval()
    from performing code generation.
    
    PR-URL: #30094
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    codebytere authored and targos committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    d05f67c View commit details
    Browse the repository at this point in the history
  4. stream: extract Readable.from in its own file

    See: nodejs/readable-stream#420
    
    PR-URL: #30140
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    mcollina authored and targos committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    87f14e1 View commit details
    Browse the repository at this point in the history
  5. src: split up InitializeContext

    This splits out code from InitializeContext into a
    new function InitializeContextForSnapshot and
    moves the callsite of InitializeContextRuntime from
    NewContext to InitializeContext - embedders don't
    necessarily call NewContext and so need to be able
    to guarantee these functions are called regardless.
    
    PR-URL: #30067
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    codebytere authored and targos committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    98c8f76 View commit details
    Browse the repository at this point in the history
  6. doc: fix numbering in require algorithm

    Refs: #29327
    
    PR-URL: #30117
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    jkrems authored and targos committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    403a648 View commit details
    Browse the repository at this point in the history
  7. doc,meta: prefer aliases and stubs over Runtime Deprecations

    Avoid Runtime Deprecations when an alias or a stub/no-op will suffice.
    An alias or stub will have lower maintenance costs for end users.
    
    Refs: #29989 (comment)
    
    PR-URL: #30153
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Trott authored and targos committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    978946e View commit details
    Browse the repository at this point in the history
  8. http: support readable hwm in IncomingMessage

    This commit causes http.IncomingMessage instances to set their
    readableHighWaterMark value the same value used in the underlying
    socket.
    
    PR-URL: #30135
    Fixes: #30107
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    cjihrig authored and targos committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    2505f67 View commit details
    Browse the repository at this point in the history
  9. doc: fix an error in resolution algorithm steps

    As it is, if `X begins with './' or '/' or '../'` (step 3), it reads
    as if it were possible for the algorithm to do a node_modules lookup
    (step 4). But that doesn't seem to reflect the actual logic.
    
    PR-URL: #29940
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Alex Zherdev authored and targos committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    dfb4a24 View commit details
    Browse the repository at this point in the history
  10. doc: add options description for send APIs

    Describes the meaning of the boolean return in process.send()
    (doc/api/process.md) and worker.send() (doc/api/cluster.md) as
    described in subprocess.send() (doc/api/child_process.md)
    
    Fixes: #26995
    PR-URL: #29868
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    dev-script authored and targos committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    a48d179 View commit details
    Browse the repository at this point in the history
  11. doc: move inactive Collaborators to emeriti

    Moving some relatively inactive Collaborators to emeriti. In all cases,
    the Collaborator has been emailed and responded that they were fine with
    this change.
    
    PR-URL: #30177
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Trott authored and targos committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    3709b5c View commit details
    Browse the repository at this point in the history
  12. deps: update npm to 6.12.1

    PR-URL: #30164
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Michael Perrotte authored and targos committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    e312448 View commit details
    Browse the repository at this point in the history
  13. doc: improve doc Http2Session:Timeout

    Add line in doc/http2.md for 'timeout' event which tell readers
    that 'timeout' event doesn't except any arguments.
    
    Refs: nodejs/help#877
    PR-URL: #30161
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    dev-script authored and targos committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    1499a72 View commit details
    Browse the repository at this point in the history
  14. build: fix pkg-config search for libnghttp2

    The configure script was searching for 'nghttp2' whereas the actual name
    of the package is 'libnghttp2'.
    
    This change also removes the hack for libcares in one fell swoop.
    
    Co-Authored-By: legendecas <legendecas@gmail.com>
    
    PR-URL: #30145
    Fixes: #30113
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    bnoordhuis authored and targos committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    b255688 View commit details
    Browse the repository at this point in the history
  15. doc: update AUTHORS list

    PR-URL: #30142
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    targos committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    ae81360 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2019

  1. src: change env.h includes for forward declarations

    Due to how the Environment class is used through the codebase,
    there are a lot of includes referencing either env.h or env-inl.h.
    This can cause that when any development touches those libraries,
    a lot of files have to be recompiled.
    This commit attempts to change those includes by forward declarations
    when possible to mitigate the issue.
    
    Refs: #27531
    
    PR-URL: #30133
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    alferpal authored and targos committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    ec7b69f View commit details
    Browse the repository at this point in the history
  2. tools: git rm -r tools/v8_gypfiles/broken

    PR-URL: #30149
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    cclauss authored and targos committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    14981f5 View commit details
    Browse the repository at this point in the history
  3. build: find Python syntax errors in dependencies

    As discussed in
    #30129 (comment), when
    we vendor in code, we own the Syntax Errors in that code.  This PR adds
    The `.flake8` config file at the root of this repo puts blinders on the
    linting of our dependencies so this test disables that file before
    linting.
    
    fixup: allow_failures until dependencies pass
    
    PR-URL: #30143
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    cclauss authored and targos committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    5469811 View commit details
    Browse the repository at this point in the history
  4. deps: V8: cherry-pick e5dbc95

    Original commit message:
    
        [api] Fix handle leak when getting Context embedder data
    
        The `Context::SlowGetAlignedPointerFromEmbedderData()` method returns
        a pointer, so the fact that it allocates handles is not obvious to
        the caller.
    
        Since this is the slow path anyway, simply add a handle scope inside
        of it.
    
        The tests are also modified to perform the same check for the
        `Object` equivalent of this method.
    
        Change-Id: I5f03c9a7b70b3a17315609df021606a53c9feb2d
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1879902
        Reviewed-by: Yang Guo <yangguo@chromium.org>
        Commit-Queue: Yang Guo <yangguo@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#64583}
    
    Refs: v8/v8@e5dbc95
    Fixes: #30127
    PR-URL: #30130
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Gabriel Schulhof authored and targos committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    104bfb9 View commit details
    Browse the repository at this point in the history
  5. tools: undefined name opts -> args in gyptest.py

    ```
    ./tools/gyp/gyptest.py:61:47: F821 undefined name 'opts'
        extra_path = [os.path.abspath(p) for p in opts.path]
                                                  ^
    ```
    `opts.path` is an undefined name in this context while `args.path` is
    used on the preceding line and is defined on line 48.  Undefined names
    have the potential to raise `NameError` at runtime which will halt the
    script.
    
    PR-URL: #30144
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    cclauss authored and targos committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    bcbcce5 View commit details
    Browse the repository at this point in the history
  6. tools: use print() function in buildbot_run.py

    PR-URL: #30148
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    cclauss authored and targos committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    e2fb353 View commit details
    Browse the repository at this point in the history
  7. tools: fix Python 3 syntax error in mac_tool.py

    PR-URL: #30146
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    cclauss authored and targos committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    348ec69 View commit details
    Browse the repository at this point in the history
  8. doc: linkify .fork() in cluster documentation

    PR-URL: #30163
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    addaleax authored and targos committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    f8fb2c0 View commit details
    Browse the repository at this point in the history
  9. meta: use contact_links instead of issue templates

    To redirect people to the help and website repos.
    
    PR-URL: #30172
    Refs: https://github.blog/changelog/2019-10-28-new-issue-template-configuration-options/
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    targos committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    050efeb View commit details
    Browse the repository at this point in the history
  10. src: expose granular SetIsolateUpForNode

    This PR exposes a new embedder-focused API: SetIsolateUpForNode.
    It maintains previous behavior for the single-param version of
    SetIsolateUpForNode and changes no defaults, but was designed to be
    flexible by allowing for embedders to conditionally override all
    callbacks and flags set by the previous two-param version of
    SetIsolateUpForNode.
    
    PR-URL: #30150
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    codebytere authored and targos committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    a0df91c View commit details
    Browse the repository at this point in the history
  11. src: isolate->Dispose() order consistency

    PR-URL: #30181
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    codebytere authored and targos committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    cc1cd2b View commit details
    Browse the repository at this point in the history
  12. build: allow Python 3.8

    PR-URL: #30194
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    targos committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    03827dd View commit details
    Browse the repository at this point in the history
  13. doc: explain http2 aborted event callback

    Line added in the description of http2 aborted event
    that it's listener does not expect any arguments.
    
    Refs: nodejs/help#877
    PR-URL: #30179
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    dev-script authored and targos committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    b7070f3 View commit details
    Browse the repository at this point in the history
  14. doc: linkify .setupMaster() in cluster doc

    Refs: #30163
    PR-URL: #30204
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    trivikr authored and targos committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    201a60e View commit details
    Browse the repository at this point in the history
  15. doc: add missing hash for header link

    The link is to a heading in the file, but is missing the #
    
    PR-URL: #30188
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    nschonni authored and targos committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    fc407bb View commit details
    Browse the repository at this point in the history
  16. tools: fix Python 3 deprecation warning in test.py

    PR-URL: #30208
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Hellzed authored and targos committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    68e4b5a View commit details
    Browse the repository at this point in the history
  17. deps: V8: cherry-pick a7dffcd767be

    Original commit message:
    
        [postmortem] Load files using utf-8 to support Python 3
    
        Change-Id: I174d38cc33210c07d1a7596627e1b2d21bb06313
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1895560
        Reviewed-by: Mathias Bynens <mathias@chromium.org>
        Commit-Queue: Michaël Zasso <mic.besace@gmail.com>
        Cr-Commit-Position: refs/heads/master@{#64717}
    
    Refs: v8/v8@a7dffcd
    
    PR-URL: #30218
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    cclauss authored and targos committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    46c9194 View commit details
    Browse the repository at this point in the history
  18. buffer: improve performance caused by primordials

    This is my first PR, and it's based on the code-and-learn guidances
    This restore some performance after introducing primordialias.
    
    Refs: #29766
    Refs: nodejs/code-and-learn#97
    Refs: #29633
    
    PR-URL: #30235
    Refs: #29766
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    jizusun authored and targos committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    8860bd6 View commit details
    Browse the repository at this point in the history
  19. build: add workaround for WSL

    Signed-off-by: gengjiawen <technicalcute@gmail.com>
    
    PR-URL: #30221
    Fixes: #30189
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    gengjiawen authored and targos committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    49e7f04 View commit details
    Browse the repository at this point in the history
  20. build: fix detection of Visual Studio 2017

    When run in a Visual Studio 2017 command prompt the `VCINSTALLDIR`
    environment variable will be already set and is not cleared by the
    `tools/msvs/vswhere_usability_wrapper.cmd` utility when it fails to
    find Visual Studio 2019. This causes `vcbuild.bat` to incorrectly
    assume Visual Studio 2019 and generate an incompatible configuration.
    
    Clearing the value of `VCINSTALLDIR` before calling the utility fixes
    the detection logic.
    
    PR-URL: #30119
    Fixes: #30118
    Refs: #30022
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: João Reis <reis@janeasystems.com>
    richardlau authored and targos committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    1bded98 View commit details
    Browse the repository at this point in the history
  21. 2019-11-05, Version 13.1.0 (Current)

    Notable changes:
    
    * cli:
      * Added a new flag (`--trace-uncaught`) that makes Node.js print the
        stack trace at the time of throwing uncaught exceptions, rather than
        at the creation of the `Error` object, if there is any. This is
        disabled by default because it affects GC behavior.
        #30025
    * crypto
      * Added `Hash.prototype.copy()` method. It returns a new `Hash` object
        with its internal state cloned from the original one.
        #29910
    * dgram
      * Added source-specific multicast support. This adds methods to
        Datagram sockets to support RFC 4607
        (https://tools.ietf.org/html/rfc4607) for IPv4 and IPv6.
        #15735
    * fs
      * Added a `bufferSize` option to `fs.opendir()`. It allows to control
        the number of entries that are buffered internally when reading from
        the directory. #30114
    * meta
      * Added Chengzhong Wu (https://github.com/legendecas) to
        collaborators. #30115
    
    PR-URL: #30262
    targos committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    64eacd8 View commit details
    Browse the repository at this point in the history