Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x] deps: V8: backport fb63e5cf55e9 #30372

Closed
wants to merge 1 commit into from
Closed

[v10.x] deps: V8: backport fb63e5cf55e9 #30372

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Nov 12, 2019

Original commit message:

[Intl] Fix output of hour:'2-digit', hour12: true

Bug: chromium:527926
Change-Id: I783ba59c6e4b117163e058032fb04283e1f43c46
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529260
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60379}

Refs: v8/v8@fb63e5c

Fixes: #30369

@targos
deps: V8: backport fb63e5cf55e9
ded973a 
Original commit message:

    [Intl] Fix output of hour:'2-digit', hour12: true

    Bug: chromium:527926
    Change-Id: I783ba59c6e4b117163e058032fb04283e1f43c46
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529260
    Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
    Commit-Queue: Frank Tang <ftang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60379}

Refs: v8/v8@fb63e5c

Fixes: nodejs#30369
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v10.x v8 engine Issues and PRs related to the V8 dependency. labels Nov 12, 2019
@targos targos changed the title deps: V8: backport fb63e5cf55e9 [v10.x] deps: V8: backport fb63e5cf55e9 Nov 12, 2019
@targos targos mentioned this pull request Nov 12, 2019
Closed
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@richardlau
Copy link
Member

V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/2624/

The centos7-ppcle failure is because #28458 isn't on 10.x-staging.

@BethGriggs
Copy link
Member

Landed #28458 on v10.x-staging
New V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2642

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27289/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 3, 2019 •
edited by BethGriggs

CI: https://ci.nodejs.org/job/node-test-pull-request/27298/ ✅

BethGriggs pushed a commit that referenced this pull request Dec 3, 2019
@targos @BethGriggs
deps: V8: backport fb63e5cf55e9
0a7f6fa 
Original commit message:

    [Intl] Fix output of hour:'2-digit', hour12: true

    Bug: chromium:527926
    Change-Id: I783ba59c6e4b117163e058032fb04283e1f43c46
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529260
    Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
    Commit-Queue: Frank Tang <ftang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60379}

Refs: v8/v8@fb63e5c

Fixes: #30369

Backport-PR-URL: #30372
@BethGriggs
Copy link
Member

Landed in 271b4137f0

@BethGriggs BethGriggs closed this Dec 3, 2019
@targos targos deleted the fix-30369 branch December 3, 2019 17:02
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@targos @MylesBorins
deps: V8: backport fb63e5cf55e9
3e0709c 
Original commit message:

    [Intl] Fix output of hour:'2-digit', hour12: true

    Bug: chromium:527926
    Change-Id: I783ba59c6e4b117163e058032fb04283e1f43c46
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529260
    Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
    Commit-Queue: Frank Tang <ftang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60379}

Refs: v8/v8@fb63e5c

Fixes: #30369

Backport-PR-URL: #30372
francois2metz added a commit to osmontrouge/osmontrouge that referenced this pull request Jan 31, 2020
@francois2metz
Update the test with 2-digit formating since the nodejs bug is fixed.
0add237 
See nodejs/node#30372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@lundibundi lundibundi lundibundi approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@targos @nodejs-github-bot @richardlau @BethGriggs @bnoordhuis @cjihrig @lundibundi