Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: mark ArrayBuffers with free callbacks as untransferable #30475

Closed
wants to merge 2 commits into from
Closed

src: mark ArrayBuffers with free callbacks as untransferable #30475

wants to merge 2 commits into from

Commits on Nov 13, 2019

  1. src: mark ArrayBuffers with free callbacks as untransferable 

    More precisely, make them untransferable if they were created through
*our* APIs, because those do not follow the improved free callback
mechanism that V8 uses now. All other ArrayBuffers can be transferred
between threads now, the assumption being that they were created in a
clean way that follows the V8 API on this.

This addresses a TODO comment.

Refs: nodejs#30339 (comment)
    @addaleax
    addaleax committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    44da3b3 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2019

  1. fixup! src: mark ArrayBuffers with free callbacks as untransferable

    @addaleax
    addaleax committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    47ff8a9 View commit details
    Browse the repository at this point in the history