v13.2.0 proposal

.travis.yml

@@ -1,9 +1,3 @@
-x-ccache-setup-steps: &ccache-setup-steps
-  - export CCACHE_NOSTATS=1
-  - export CCACHE_SLOPPINESS="file_macro,include_file_mtime,include_file_ctime,time_macros,file_stat_matches"
-  - export CC='ccache gcc-6'
-  - export CXX='ccache g++-6'
-
 os: linux
 language: cpp
 env:
@@ -13,33 +7,24 @@ env:
 jobs:
   include:
     - stage: "Compile"
-      name: "Compile V8"
+      name: "Compile Node.js"
       cache: ccache
       addons:
         apt:
           sources:
             - ubuntu-toolchain-r-test
           packages:
             - g++-6
-      install: *ccache-setup-steps
-      script:
-        - pyenv global ${PYTHON_VERSION}
-        - ./configure
-        - make -j2 -C out V=1 v8
-
-    - name: "Compile Node.js"
-      cache: ccache
-      addons:
-        apt:
-          sources:
-            - ubuntu-toolchain-r-test
-          packages:
-            - g++-6
-      install: *ccache-setup-steps
+      install:
+        - export CCACHE_NOSTATS=1
+        - export CCACHE_SLOPPINESS="file_macro,include_file_mtime,include_file_ctime,time_macros,file_stat_matches"
+        - export CC='ccache gcc-6'
+        - export CXX='ccache g++-6'
       script:
         - pyenv global ${PYTHON_VERSION}
         - ./configure
-        - make -j2 V=1
+        - timeout --preserve-status 45m make -j2 V=1
+      before_cache:
         - cp out/Release/node /home/travis/.ccache
         - cp out/Release/cctest /home/travis/.ccache
 

BUILDING.md

@@ -69,17 +69,14 @@ There are three support tiers:
 
 * **Tier 1**: These platforms represent the majority of Node.js users. The
   Node.js Build Working Group maintains infrastructure for full test coverage.
-  Maintenance is supported by the Node.js core team. All commits to the
-  Node.js repository are tested on multiple variants of these platforms. Test
+  All commits to the Node.js repository are tested on these platforms. Test
   failures on tier 1 platforms will block releases.
 * **Tier 2**: These platforms represent smaller segments of the Node.js user
   base. The Node.js Build Working Group maintains infrastructure for full test
-  coverage. Maintenance is supported by smaller groups or individuals within
-  the Node.js core team, or the vendor of the platform itself. All commits to
-  the Node.js repository are tested on multiple variants of these platforms
-  where practical. Test failures on tier 2 platforms will block releases.
-  Delays in release of binaries for these platforms are acceptable
-  where necessary due to infrastructure concerns.
+  coverage. All commits to the Node.js repository are tested on these platforms.
+  Test failures on tier 2 platforms will block releases. Delays in release of
+  binaries for these platforms are acceptable where necessary due to
+  infrastructure concerns.
 * **Experimental**: May not compile or test suite may not pass. The core team
   does not create releases for these platforms. Test failures on experimental
   platforms do not block releases. Contributions to improve support for these
@@ -371,6 +368,10 @@ loopback interface on Ubuntu:
 sudo sysctl -w net.ipv6.conf.lo.disable_ipv6=0
 ```
 
+You can use
+[node-code-ide-configs](https://github.com/nodejs/node-code-ide-configs)
+to run/debug tests, if your IDE configs are present.
+
 #### Running Coverage
 
 It's good practice to ensure any code you add or change is covered by tests.
@@ -475,7 +476,7 @@ To use the debug build with all the normal dependencies overwrite the release
 version in the install directory:
 
 ``` console
-$ make install --prefix=/opt/node-debug/
+$ make install PREFIX=/opt/node-debug/
 $ cp -a -f out/Debug/node /opt/node-debug/node
 ```
 

CHANGELOG.md

@@ -30,7 +30,8 @@ release.
 </tr>
 <tr>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V13.md#13.1.0">13.1.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V13.md#13.2.0">13.2.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V13.md#13.1.0">13.1.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V13.md#13.0.1">13.0.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V13.md#13.0.0">13.0.0</a><br/>
     </td>

COLLABORATOR_GUIDE.md

@@ -172,25 +172,35 @@ the comment anyway to avoid any doubt.
 All fixes must have a test case which demonstrates the defect. The test should
 fail before the change, and pass after the change.
 
-All pull requests must pass continuous integration tests on the
-[project CI server](https://ci.nodejs.org/).
+All pull requests must pass continuous integration tests. Code changes must pass
+on [project CI server](https://ci.nodejs.org/). Pull requests that only change
+documentation and comments can use Travis CI results.
+
+Travis CI jobs have a fixed running time limit that building Node.js sometimes
+exceeds. If the `Compile Node.js` Travis CI job has timed out it will fail after
+around 45 minutes. The exit code will be 143, indicating that a `SIGTERM` signal
+terminated the `make` command. When this happens, restart the timed out job. It
+will reuse built artifacts from the previous timed-out run, and thus take less
+time to complete.
 
 Do not land any pull requests without passing (green or yellow) CI runs. If
 there are CI failures unrelated to the change in the pull request, try "Resume
 Build". It is in the left navigation of the relevant `node-test-pull-request`
 job. It will preserve all the green results from the current job but re-run
 everything else.
 
+Some of the CI Jobs may require `GIT_REMOTE_REF` which is the remote portion
+of Git refspec. To specify the branch this way `refs/heads/BRANCH` is used
+(i.e for `master` -> `refs/heads/master`).
+For pull requests it will look like `refs/pull/PR_NUMBER/head`
+(i.e. for PR#42 -> `refs/pull/42/head`).
+
 #### Useful CI Jobs
 
 * [`node-test-pull-request`](https://ci.nodejs.org/job/node-test-pull-request/)
 is the CI job to test pull requests. It runs the `build-ci` and `test-ci`
 targets on all supported platforms.
 
-* [`node-test-pull-request-lite-pipeline`](https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/)
-runs the linter job. It also runs the tests on a very fast host. This is useful
-for changes that only affect comments or documentation.
-
 * [`citgm-smoker`](https://ci.nodejs.org/job/citgm-smoker/)
 uses [`CitGM`](https://github.com/nodejs/citgm) to allow you to run
 `npm install && npm test` on a large selection of common modules. This is

GOVERNANCE.md

@@ -15,22 +15,21 @@
 ## Collaborators
 
 Node.js Core Collaborators maintain the [nodejs/node][] GitHub repository.
-The GitHub team for Node.js Core Collaborators is @nodejs/collaborators. Their
-privileges include but are not limited to:
+The GitHub team for Node.js Core Collaborators is @nodejs/collaborators.
+Collaborators have:
 
 * Commit access to the [nodejs/node][] repository
 * Access to the Node.js continuous integration (CI) jobs
 
 Both Collaborators and non-Collaborators may propose changes to the Node.js
 source code. The mechanism to propose such a change is a GitHub pull request.
-Collaborators are responsible for reviewing and merging (_landing_)
-pull requests.
+Collaborators review and merge (_land_) pull requests.
 
-At least two Collaborators must approve a pull request before the pull request
-can land. (One Collaborator approval is enough if the pull request has been open
-for more than 7 days.) Approving a pull request indicates that the Collaborator
-accepts responsibility for the change. Approval must be from Collaborators who
-are not authors of the change.
+Two Collaborators must approve a pull request before the pull request can land.
+(One Collaborator approval is enough if the pull request has been open for more
+than 7 days.) Approving a pull request indicates that the Collaborator accepts
+responsibility for the change. Approval must be from Collaborators who are not
+authors of the change.
 
 If a Collaborator opposes a proposed change, then the change cannot land. The
 exception is if the TSC votes to approve the change despite the opposition.
@@ -39,13 +38,11 @@ result in Collaborators removing their opposition.
 
 See:
 
-* [Current list of Collaborators](./README.md#current-project-team-members)
+* [List of Collaborators](./README.md#current-project-team-members)
 * [A guide for Collaborators](./COLLABORATOR_GUIDE.md)
 
 ### Collaborator Activities
 
-Typical activities of a Collaborator include:
-
 * Helping users and novice contributors
 * Contributing code and documentation changes that improve the project
 * Reviewing and commenting on issues and pull requests
@@ -71,7 +68,7 @@ The current list of TSC members is in
 [the project README](./README.md#current-project-team-members).
 
 The [TSC Charter][] governs the operations of the TSC. All changes to the
-Charter need approval by the Node.js Board of Directors.
+Charter need approval by the OpenJS Foundation Board of Directors.
 
 ### TSC Meetings
 
@@ -124,7 +121,7 @@ Provide a summary of the nominee's contributions. For example:
   * Use the link `https://github.com/nodejs/node/issues?q=commenter:GITHUB_ID`
 * Reviews on pull requests in the [nodejs/node][] repository
   * Use the link `https://github.com/nodejs/node/pulls?q=reviewed-by:GITHUB_ID`
-* Help provided to end users and novice contributors
+* Help provided to end-users and novice contributors
 * Pull requests and issues opened throughout the Node.js organization
   * Use the link  `https://github.com/search?q=author:GITHUB_ID+org:nodejs`
 * Comments on pull requests and issues throughout the Node.js organization
@@ -144,16 +141,15 @@ frictionless as possible. Use the [Collaborators discussion page][] to request
 feedback from other Collaborators in private. A nominator may also work with the
 nominee to improve their contribution profile.
 
-It is possible that Collaborators will overlook someone with valuable
-contributions. In that case, the contributor may open an issue or contact a
-Collaborator to request a nomination.
+Collaborators might overlook someone with valuable contributions. In that case,
+the contributor may open an issue or contact a Collaborator to request a
+nomination.
 
 ### Onboarding
 
 After the nomination passes, a TSC member onboards the new Collaborator. See
-[the onboarding guide](./doc/onboarding.md) on details of the onboarding
-process. In general, the onboarding should occur within a month after the
-nomination passes.
+[the onboarding guide](./doc/onboarding.md) for details of the onboarding
+process.
 
 ## Consensus Seeking Process
 

Makefile

@@ -300,7 +300,7 @@ jstest: build-addons build-js-native-api-tests build-node-api-tests ## Runs addo
 
 .PHONY: tooltest
 tooltest:
-	@$(PYTHON) test/tools/test-js2c.py
+	@$(PYTHON) -m unittest discover -s ./test/tools
 
 .PHONY: coverage-run-js
 coverage-run-js:

README.md

@@ -256,8 +256,6 @@ For information about the governance of the Node.js project, see
 **Ben Noordhuis** <info@bnoordhuis.nl>
 * [boneskull](https://github.com/boneskull) -
 **Christopher Hiller** <boneskull@boneskull.com> (he/him)
-* [brendanashworth](https://github.com/brendanashworth) -
-**Brendan Ashworth** <brendan.ashworth@me.com>
 * [BridgeAR](https://github.com/BridgeAR) -
 **Ruben Bridgewater** <ruben@bridgewater.de> (he/him)
 * [bzoz](https://github.com/bzoz) -
@@ -276,8 +274,6 @@ For information about the governance of the Node.js project, see
 **Shelley Vohr** <codebytere@gmail.com> (she/her)
 * [danbev](https://github.com/danbev) -
 **Daniel Bevenius** <daniel.bevenius@gmail.com> (he/him)
-* [DavidCai1993](https://github.com/DavidCai1993) -
-**David Cai** <davidcai1993@yahoo.com> (he/him)
 * [davisjam](https://github.com/davisjam) -
 **Jamie Davis** <davisjam@vt.edu> (he/him)
 * [devnexen](https://github.com/devnexen) -
@@ -318,8 +314,6 @@ For information about the governance of the Node.js project, see
 **Yuta Hiroto** <hello@hiroppy.me> (he/him)
 * [iarna](https://github.com/iarna) -
 **Rebecca Turner** <me@re-becca.org>
-* [imyller](https://github.com/imyller) -
-**Ilkka Myller** <ilkka.myller@nodefield.com>
 * [indutny](https://github.com/indutny) -
 **Fedor Indutny** <fedor.indutny@gmail.com>
 * [italoacasas](https://github.com/italoacasas) -
@@ -328,8 +322,6 @@ For information about the governance of the Node.js project, see
 **Jackson Tian** <shyvo1987@gmail.com>
 * [jasnell](https://github.com/jasnell) -
 **James M Snell** <jasnell@gmail.com> (he/him)
-* [jasongin](https://github.com/jasongin) -
-**Jason Ginchereau** <jasongin@microsoft.com>
 * [jbergstroem](https://github.com/jbergstroem) -
 **Johan Bergström** <bugs@bergstroem.nu>
 * [jdalton](https://github.com/jdalton) -
@@ -392,8 +384,6 @@ For information about the governance of the Node.js project, see
 **Richard Lau** <riclau@uk.ibm.com>
 * [ronkorving](https://github.com/ronkorving) -
 **Ron Korving** <ron@ronkorving.nl>
-* [RReverser](https://github.com/RReverser) -
-**Ingvar Stepanyan** <me@rreverser.com>
 * [rubys](https://github.com/rubys) -
 **Sam Ruby** <rubys@intertwingly.net>
 * [rvagg](https://github.com/rvagg) -
@@ -461,16 +451,24 @@ For information about the governance of the Node.js project, see
 **Andras** <andras@kinvey.com>
 * [AnnaMag](https://github.com/AnnaMag) -
 **Anna M. Kedzierska** <anna.m.kedzierska@gmail.com>
+* [brendanashworth](https://github.com/brendanashworth) -
+**Brendan Ashworth** <brendan.ashworth@me.com>
 * [estliberitas](https://github.com/estliberitas) -
 **Alexander Makarenko** <estliberitas@gmail.com>
 * [chrisdickinson](https://github.com/chrisdickinson) -
 **Chris Dickinson** <christopher.s.dickinson@gmail.com>
+* [DavidCai1993](https://github.com/DavidCai1993) -
+**David Cai** <davidcai1993@yahoo.com> (he/him)
 * [firedfox](https://github.com/firedfox) -
 **Daniel Wang** <wangyang0123@gmail.com>
 * [imran-iq](https://github.com/imran-iq) -
 **Imran Iqbal** <imran@imraniqbal.org>
+* [imyller](https://github.com/imyller) -
+**Ilkka Myller** <ilkka.myller@nodefield.com>
 * [isaacs](https://github.com/isaacs) -
 **Isaac Z. Schlueter** <i@izs.me>
+* [jasongin](https://github.com/jasongin) -
+**Jason Ginchereau** <jasongin@microsoft.com>
 * [jhamhader](https://github.com/jhamhader) -
 **Yuval Brik** <yuval@brik.org.il>
 * [joshgav](https://github.com/joshgav) -
@@ -511,6 +509,8 @@ For information about the governance of the Node.js project, see
 **Robert Kowalski** <rok@kowalski.gd>
 * [romankl](https://github.com/romankl) -
 **Roman Klauke** <romaaan.git@gmail.com>
+* [RReverser](https://github.com/RReverser) -
+**Ingvar Stepanyan** <me@rreverser.com>
 * [stefanmb](https://github.com/stefanmb) -
 **Stefan Budeanu** <stefan@budeanu.com>
 * [tellnes](https://github.com/tellnes) -

benchmark/assert/deepequal-buffer.js

@@ -27,7 +27,7 @@ function main({ len, n, method, strict }) {
   const value2 = method.includes('not') ? expectedWrong : expected;
 
   bench.start();
-  for (var i = 0; i < n; ++i) {
+  for (let i = 0; i < n; ++i) {
     fn(actual, value2);
   }
   bench.end(n);