Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use fs rimraf to refresh tmpdir #30569

Merged
merged 3 commits into from Dec 10, 2019
Merged

test: use fs rimraf to refresh tmpdir #30569

merged 3 commits into from Dec 10, 2019

Commits on Dec 10, 2019

  1. fs: only operate on buffers in rimraf 

    PR-URL: nodejs#30569
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @cjihrig
    cjihrig committed Dec 10, 2019
    Copy the full SHA
    152014a View commit details
    Browse the repository at this point in the history

  2. fs: retry unlink operations in rimraf 

    This commit adds synchronous retry logic to
the unlinkSync() calls in rimraf.

PR-URL: nodejs#30569
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @cjihrig
    cjihrig committed Dec 10, 2019
    Copy the full SHA
    350654a View commit details
    Browse the repository at this point in the history

  3. test: use fs rimraf to refresh tmpdir 

    Now that the functionality is built into core, use it to
refresh the test suite's tmpdir.

PR-URL: nodejs#30569
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @cjihrig
    cjihrig committed Dec 10, 2019
    Copy the full SHA
    4a5fb74 View commit details
    Browse the repository at this point in the history