Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector: properly shut down uv_async_t #30612

Closed
wants to merge 2 commits into from
Closed

inspector: properly shut down uv_async_t #30612

wants to merge 2 commits into from

Commits on Nov 23, 2019

  1. inspector: properly shut down uv_async_t 

    Closing in the Agent destructor is too late, because that happens
when the Environment is destroyed, not when libuv handles are closed.

This fixes a situation in which the same libuv loop is re-used for
multiple Environment instances sequentially, e.g. in our cctest.
    @addaleax
    addaleax committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    0193576 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2019

  1. fixup! inspector: properly shut down uv_async_t

    @addaleax
    addaleax committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    25a0659 View commit details
    Browse the repository at this point in the history