Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: refactor rimraf retry options #30644

Merged
merged 5 commits into from Nov 27, 2019
Merged

fs: refactor rimraf retry options #30644

merged 5 commits into from Nov 27, 2019
+68 −42

Commits on Nov 27, 2019

  1. fs: rename rimraf's maxBusyTries to maxRetries 

    This is part of reworking the rimraf retry logic.

Refs: nodejs#30580
PR-URL: nodejs#30644
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig
    cjihrig committed Nov 27, 2019
    Copy the full SHA
    4059055 View commit details
    Browse the repository at this point in the history

  2. fs: make rimraf default to 0 retries 

    This commit makes retries an opt-in feature by defaulting
to no automatic retries. This will be particularly important
once synchronous operations can sleep between attempts.

Refs: nodejs#30580
PR-URL: nodejs#30644
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig
    cjihrig committed Nov 27, 2019
    Copy the full SHA
    7e85f06 View commit details
    Browse the repository at this point in the history

  3. fs: remove rimraf's emfileWait option 

    This commit removes the emfileWait option. EMFILE errors are
now handled the same as any other retriable error.

Refs: nodejs#30580
PR-URL: nodejs#30644
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig
    cjihrig committed Nov 27, 2019
    Copy the full SHA
    4c77a76 View commit details
    Browse the repository at this point in the history

  4. fs: add retryDelay option to rimraf 

    This commit adds a retryDelay option to rimraf which configures
the amount of time between retry operations.

Refs: nodejs#30580
PR-URL: nodejs#30644
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig
    cjihrig committed Nov 27, 2019
    Copy the full SHA
    b7cdeb8 View commit details
    Browse the repository at this point in the history

  5. fs: add ENFILE to rimraf retry logic 

    Co-authored-by: Thang Tran <trankimthang279@gmail.com>
Fixes: nodejs#30482
Refs: nodejs#30499
Refs: nodejs#30580
PR-URL: nodejs#30644
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig @thangktran
    cjihrig and thangktran committed Nov 27, 2019
    Copy the full SHA
    74f8196 View commit details
    Browse the repository at this point in the history