Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add --without-node-code-cache configure option #30647

Closed
wants to merge 3 commits into from

Commits on Nov 26, 2019

  1. build: add --without-node-code-cache configure option

    So that it's possible to build without code cache (in particular,
    without building mkcodecache) for testing.
    joyeecheung committed Nov 26, 2019
    Copy the full SHA
    f593a94 View commit details
    Browse the repository at this point in the history
  2. build: do not build mksnapshot and mkcodecache for --shared

    To build mkcodecache and mksnapshot (they are executables),
    we currently build libnode with unresolved symbols, then build
    the two exectuables with src/node_snapshot_stub.cc and
    src/node_code_cache_stub.cc. Each of them write a C++ file to
    disk when being run. We then use the generated C++ files & libnode
    (with unresolved symbols) to build the final Node executable.
    
    However, if libnode itself is the final product, then we should
    not build it with unresolved symbols.
    nodejs#28897 added the two stubs
    for the libnode target when the --shared configure option is used,
    but it did not get rid of the actions to build and run mksnapshot
    and mkcodecache for --shared, so I think to get it working we also
    need a patch to make sure --shared imply --without-node-code-cache
    and --without-node-snapshot, until we actually fix the TODO so that
    mksnapshot and mkcodecache do not use the libnode that way.
    joyeecheung committed Nov 26, 2019
    Copy the full SHA
    609fc75 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2019

  1. Copy the full SHA
    3615173 View commit details
    Browse the repository at this point in the history