Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: avoid proposal syntax in code example #30685

Closed
wants to merge 1 commit into from
Closed

doc: avoid proposal syntax in code example #30685

wants to merge 1 commit into from

Conversation

alexzherdev
Copy link
Contributor

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 27, 2019
@MylesBorins MylesBorins added the esm Issues and PRs related to the ECMAScript Modules implementation. label Nov 28, 2019
MylesBorins
MylesBorins reviewed Nov 28, 2019
View reviewed changes
doc/api/esm.md Outdated Show resolved Hide resolved
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 29, 2019
MylesBorins
MylesBorins approved these changes Nov 29, 2019
View reviewed changes
Copy link
Member

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

addaleax pushed a commit that referenced this pull request Nov 30, 2019
@alexzherdev @addaleax
doc: avoid proposal syntax in code example
6233356 
PR-URL: #30685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@addaleax
Copy link
Member

Landed in 6233356

@addaleax addaleax closed this Nov 30, 2019
@alexzherdev alexzherdev deleted the patch-1 branch November 30, 2019 01:37
addaleax pushed a commit that referenced this pull request Nov 30, 2019
@alexzherdev @addaleax
doc: avoid proposal syntax in code example
20dbce1 
PR-URL: #30685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
MylesBorins pushed a commit that referenced this pull request Jan 12, 2020
@alexzherdev @MylesBorins
doc: avoid proposal syntax in code example
005cad3 
PR-URL: #30685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@alexzherdev @BethGriggs
doc: avoid proposal syntax in code example
de3fdfa 
PR-URL: #30685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexzherdev @addaleax @MylesBorins @nodejs-github-bot