Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: cherry-pick ca5b0ec #30708

Closed
wants to merge 2 commits into from
Closed

Commits on Nov 28, 2019

  1. deps: V8: cherry-pick ca5b0ec

    Original commit message:
    
        [heap] Ensure SyntheticModule is initialized before next allocation
    
        Ensure that all fields of `SyntheticModule` are set before creating
        the exports hash table for it, because the latter may trigger
        garbage collection, leading to crashes.
    
        This has been causing failures in the Node.js CI over the last weeks,
        after making the creating of synthetic modules part of Node’s
        startup sequence.
    
        (I am generally not very familiar with this part of the V8
        code and there might be a better way, or possibly a way to add a
        reliable regression test, that I am not aware of.)
    
        Refs: nodejs#30498
        Refs: nodejs#30648
        Change-Id: I32da4b7bd888c6ec1421f34f5bd52e7bad154c1e
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1939752
        Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
        Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#65247}
    
    Refs: v8/v8@ca5b0ec
    Fixes: nodejs#30498
    Fixes: nodejs#30648
    addaleax committed Nov 28, 2019
    Copy the full SHA
    a8c5b51 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    c4f3cdf View commit details
    Browse the repository at this point in the history