Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove imprecise and redundant testing text #30763

Merged
merged 1 commit into from Dec 5, 2019
Merged

Commits on Dec 5, 2019

  1. doc: remove imprecise and redundant testing text

    Remove "All commits...are tested on these platforms." for the following
    reasons:
    
    * It's somewhat redundant. The surrounding text makes it clear that we
      test on these platforms.
    * It's imprecise. Commits, such as those that only affect documentation
      or linting do not get tested on all the platforms. (Well, perhaps they
      do in an after-the-fact kind of way when a subsequent commit gets
      tested, but I think that's a stretch.)
    
    PR-URL: nodejs#30763
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Trott committed Dec 5, 2019
    Copy the full SHA
    ca11291 View commit details
    Browse the repository at this point in the history