Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert,util: always verify both sides #30764

Closed
wants to merge 3 commits into from
Closed

assert,util: always verify both sides #30764

wants to merge 3 commits into from

Commits on Dec 2, 2019

  1. assert,util: stricter type comparison using deep equal comparisons 

    This veryfies that both input arguments are always of the identical
type. It was possible to miss a few cases before. This change applies
to all deep equal assert functions (e.g., `assert.deepStrictEqual()`)
and to `util.isDeepStrictEqual()`.
    @BridgeAR
    BridgeAR committed Dec 2, 2019
    Copy the full SHA
    3802007 View commit details
    Browse the repository at this point in the history

  2. test: run more assert tests 

    This makes sure the assertion does not depend on the argument order.
It also removes comments that do not apply anymore and verifies the
behavior for the loose and strict implementation.
    @BridgeAR
    BridgeAR committed Dec 2, 2019
    Copy the full SHA
    17aad5d View commit details
    Browse the repository at this point in the history

  3. fixup: fix isRegExp and add more tests

    @BridgeAR
    BridgeAR committed Dec 2, 2019
    Copy the full SHA
    668ab35 View commit details
    Browse the repository at this point in the history