Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: add synchronous retries to rimraf #30785

Closed
wants to merge 3 commits into from
Closed

fs: add synchronous retries to rimraf #30785

wants to merge 3 commits into from

Commits on Dec 8, 2019

  1. fs: add synchronous retries to rimraf 

    This commit gives the synchronous version of rimraf the same
linear retry logic as the asynchronous version. Prior to this
commit, sync rimraf kept retrying the operation as soon as
possible until maxRetries was reached.
    @cjihrig
    cjihrig committed Dec 8, 2019
    Copy the full SHA
    b0f690b View commit details
    Browse the repository at this point in the history

  2. fixup! fs: add synchronous retries to rimraf

    @cjihrig
    cjihrig committed Dec 8, 2019
    Copy the full SHA
    8c2ca28 View commit details
    Browse the repository at this point in the history

  3. fs: reduce unnecessary sync rimraf retries 

    rimraf should only retry if certain errors are encountered.
Additionally, there is no point sleeping if an error occurs
on the last try.
    @cjihrig
    cjihrig committed Dec 8, 2019
    Copy the full SHA
    2dd26b0 View commit details
    Browse the repository at this point in the history