Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v10.18.1 proposal #30796

Closed
wants to merge 14 commits into from
Closed

v10.18.1 proposal #30796

wants to merge 14 commits into from

Commits on Nov 19, 2019

  1. build: fix configure script to work with Apple Clang 11

    PR-URL: #28071
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
    saagarjha authored and BethGriggs committed Nov 19, 2019
    Copy the full SHA
    61d6ac7 View commit details
    Browse the repository at this point in the history
  2. tools: fix v8 testing with devtoolset on ppcle

    The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them
    if not present.
    
    PR-URL: #28458
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    sam-github authored and BethGriggs committed Nov 19, 2019
    Copy the full SHA
    7066335 View commit details
    Browse the repository at this point in the history
  3. tools: move python code out of jenkins shell

    https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes
    python code into tools and runs it. Move these scripts into tools for
    better maintainability.
    
    Once this lands and is back-ported into LTS branches a bunch of shell
    code can be deleted from the job.
    
    PR-URL: #28458
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    sam-github authored and BethGriggs committed Nov 19, 2019
    Copy the full SHA
    7ff19be View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2019

  1. lib: fix comment nits in bootstrap\loaders.js

    Backport-PR-URL: #30338
    PR-URL: #24641
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    vsemozhetbyt authored and BethGriggs committed Nov 22, 2019
    Copy the full SHA
    efeac48 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2019

  1. tools: update tzdata to 2019c

    Refs: #30211
    Refs: #30356
    
    PR-URL: #30479
    Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    MylesBorins authored and BethGriggs committed Dec 3, 2019
    Copy the full SHA
    501ebbb View commit details
    Browse the repository at this point in the history
  2. deps: V8: backport fb63e5cf55e9

    Original commit message:
    
        [Intl] Fix output of hour:'2-digit', hour12: true
    
        Bug: chromium:527926
        Change-Id: I783ba59c6e4b117163e058032fb04283e1f43c46
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529260
        Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
        Commit-Queue: Frank Tang <ftang@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#60379}
    
    Refs: v8/v8@fb63e5c
    
    Fixes: #30369
    
    Backport-PR-URL: #30372
    targos authored and BethGriggs committed Dec 3, 2019
    Copy the full SHA
    0a7f6fa View commit details
    Browse the repository at this point in the history
  3. n-api: correct bug in napi_get_last_error

    napi_get_last_error returns incorrect napi_status.
    
    Backport-PR-URL: #30532
    PR-URL: #28702
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Octavian Soldea authored and BethGriggs committed Dec 3, 2019
    Copy the full SHA
    14e7a35 View commit details
    Browse the repository at this point in the history
  4. build,win: add test-ci-native and test-ci-js

    Backport-PR-URL: #30726
    PR-URL: #30724
    Refs: nodejs/build#1996
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    joaocgreis authored and BethGriggs committed Dec 3, 2019
    Copy the full SHA
    c3e3862 View commit details
    Browse the repository at this point in the history
  5. build,win: propagate error codes in vcbuild

    Don't exit vcbuild with error code 0 when cctest fails.
    
    Backport-PR-URL: #30726
    PR-URL: #30724
    Refs: nodejs/build#1996
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    joaocgreis authored and BethGriggs committed Dec 3, 2019
    Copy the full SHA
    4d3ec1a View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2019

  1. test: do not fail SLOW tests if they are not slow

    PR-URL: #25868
    Refs: #25867
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gus Caplan <me@gus.host>
    hashseed authored and BethGriggs committed Dec 4, 2019
    Copy the full SHA
    fabbc76 View commit details
    Browse the repository at this point in the history
  2. http2: use the latest settings

    Fixes: #29764
    
    PR-URL: #29780
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    ZYSzys authored and BethGriggs committed Dec 4, 2019
    Copy the full SHA
    8e0ea6d View commit details
    Browse the repository at this point in the history
  3. stream: extract Readable.from in its own file

    See: nodejs/readable-stream#420
    
    PR-URL: #30140
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    mcollina authored and BethGriggs committed Dec 4, 2019
    Copy the full SHA
    c4dc53c View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2019

  1. http2: fix session memory accounting after pausing

    The ability to pause input processing was added in 8a4a193 but
    introduced a session memory accounting mismatch leading to potential
    NGHTTP2_ENHANCE_YOUR_CALM errors.
    
    After pausing
    (https://github.com/nodejs/node/blob/f36331c1bfa4c4c202346b05dc3bd672f653e4df/src/node_http2.cc#L871),
    the early return on line 873 skips the
    DecrementCurrentSessionMemory(stream_buf_.len) call below (line 878).
    
    When we later finished processing the input chunk
    (https://github.com/nodejs/node/blob/f36331c1bfa4c4c202346b05dc3bd672f653e4df/src/node_http2.cc#L1858),
    we were calling DecrementCurrentSessionMemory(stream_buf_offset_) [line
    1875] which was a no-op since we just set stream_buf_offset_ to 0 [line
    1873].
    
    The correct amount to decrement by is still stream_buf_.len, since
    that's the amount we skipped previously (line 878).
    
    Fixes: #29223
    Refs: 164ac5b
    
    PR-URL: #30684
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Michael Lehenbauer authored and BethGriggs committed Dec 6, 2019
    Copy the full SHA
    99915bc View commit details
    Browse the repository at this point in the history
  2. 2019-12-10, Version 10.17.1 'Dubnium' (LTS)

    Notable changes:
     - TBD
    
    PR-URL: #30796
    BethGriggs committed Dec 6, 2019
    Copy the full SHA
    7b72862 View commit details
    Browse the repository at this point in the history