Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark readline-async-iterators-destroy as flaky #30826

Closed
wants to merge 1 commit into from
Closed

test: mark readline-async-iterators-destroy as flaky #30826

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Dec 6, 2019

This test came up multiple times so far as failure. Mark it flaky for now.

Refs: #30660

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 6, 2019
addaleax
addaleax approved these changes Dec 7, 2019
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

#30836 + #30837 should fix this too, so the two of the PRs that lands last should probably include a revert of this

@addaleax
Copy link
Member

The fixes have landed, I don’t think we need to merge this anymore :) Thanks for the PR and drawing my attention to the issue, though!

@addaleax addaleax closed this Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@antsmartian antsmartian antsmartian approved these changes

@devnexen devnexen devnexen approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@BridgeAR @addaleax @Trott @antsmartian @devnexen @richardlau @nodejs-github-bot