Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: synchronize close with other I/O for streams #30837

Closed
wants to merge 2 commits into from
Closed

fs: synchronize close with other I/O for streams #30837

wants to merge 2 commits into from

Commits on Dec 9, 2019

  1. fs: synchronize close with other I/O for streams 

    Part of the flakiness in the
parallel/test-readline-async-iterators-destroy test comes from
fs streams starting `_read()` and `_destroy()` without waiting
for the other to finish, which can lead to the `fs.read()` call
resulting in `EBADF` if timing is bad.

Fix this by synchronizing write and read operations with `close()`.

Refs: nodejs#30660
    @addaleax
    addaleax committed Dec 9, 2019
    Copy the full SHA
    b1f7bf0 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2019

  1. fixup! fs: synchronize close with other I/O for streams

    @addaleax
    addaleax committed Dec 10, 2019
    Copy the full SHA
    a1453c5 View commit details
    Browse the repository at this point in the history