Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v13.4.0 proposal #30937

Merged
merged 117 commits into from Dec 17, 2019
Merged

v13.4.0 proposal #30937

merged 117 commits into from Dec 17, 2019

Commits on Dec 9, 2019

  1. events: add captureRejection option

    PR-URL: #27867
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    mcollina authored and targos committed Dec 9, 2019
    Copy the full SHA
    220a600 View commit details
    Browse the repository at this point in the history
  2. stream: add support for captureRejection option

    PR-URL: #27867
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    mcollina authored and targos committed Dec 9, 2019
    Copy the full SHA
    89bc571 View commit details
    Browse the repository at this point in the history
  3. http: implement capture rejections for 'request' event

    PR-URL: #27867
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    mcollina authored and targos committed Dec 9, 2019
    Copy the full SHA
    33a6bf3 View commit details
    Browse the repository at this point in the history
  4. http: add captureRejection support to OutgoingMessage

    PR-URL: #27867
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    mcollina authored and targos committed Dec 9, 2019
    Copy the full SHA
    334d4f6 View commit details
    Browse the repository at this point in the history
  5. net: implement capture rejections for 'connection' event

    PR-URL: #27867
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    mcollina authored and targos committed Dec 9, 2019
    Copy the full SHA
    4eecee0 View commit details
    Browse the repository at this point in the history
  6. tls: implement capture rejections for 'secureConnection' event

    PR-URL: #27867
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    mcollina authored and targos committed Dec 9, 2019
    Copy the full SHA
    5ad3efb View commit details
    Browse the repository at this point in the history
  7. http2: implement capture rection for 'request' and 'stream' events

    PR-URL: #27867
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    mcollina authored and targos committed Dec 9, 2019
    Copy the full SHA
    c3ac4c8 View commit details
    Browse the repository at this point in the history
  8. test: change common.PORT to arbitrary port

    Change common.PORT to arbitrary port in
    test-child-process-fork-getconnections to prepare for moving that test
    from sequential to parallel.
    
    PR-URL: #30749
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Trott authored and targos committed Dec 9, 2019
    Copy the full SHA
    50ab1fa View commit details
    Browse the repository at this point in the history
  9. test: move test-child-process-fork-getconnections to parallel

    Now that the test uses an open port assigned by the operating system
    rather than a hardcoded common.PORT, it can be moved to parallel.
    
    PR-URL: #30749
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Trott authored and targos committed Dec 9, 2019
    Copy the full SHA
    9bd5c72 View commit details
    Browse the repository at this point in the history
  10. doc: update status of Python 3 support

    Refs: nodejs/TSC#781 (comment)
    Based on the completion of the Python 3 strategic
    initiative, update statements around Python 3 support.
    
    PR-URL: #30722
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    mhdawson authored and targos committed Dec 9, 2019
    Copy the full SHA
    145f881 View commit details
    Browse the repository at this point in the history
  11. test: use block-scoping in test-net-server-address

    Use block-scoping in test-net-server-address. This also allows us to
    easily rename some identifiers that were not camelCase.
    
    PR-URL: #30754
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Dec 9, 2019
    Copy the full SHA
    a0fa327 View commit details
    Browse the repository at this point in the history
  12. src: fix node_dir.cc memory allocation

    PR-URL: #30750
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    piyukore06 authored and targos committed Dec 9, 2019
    Copy the full SHA
    b51b26f View commit details
    Browse the repository at this point in the history
  13. src: improve node_crypto.cc memory allocation

    This avoids heap allocations in common cases
    
    PR-URL: #30751
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    piyukore06 authored and targos committed Dec 9, 2019
    Copy the full SHA
    cb69ff4 View commit details
    Browse the repository at this point in the history
  14. src: remove redundant cast in node_dir.cc

    PR-URL: #30747
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    gengjiawen authored and targos committed Dec 9, 2019
    Copy the full SHA
    66db874 View commit details
    Browse the repository at this point in the history
  15. src: delete redundant method in node_dir.h

    PR-URL: #30747
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    gengjiawen authored and targos committed Dec 9, 2019
    Copy the full SHA
    838ae10 View commit details
    Browse the repository at this point in the history
  16. doc: clarify text about using 'session' event for compatibility

    PR-URL: #30746
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Trott authored and targos committed Dec 9, 2019
    Copy the full SHA
    8369562 View commit details
    Browse the repository at this point in the history
  17. doc: Buffer.toString(): add note about invalid data

    PR-URL: #30706
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    jgehrcke authored and targos committed Dec 9, 2019
    Copy the full SHA
    9428304 View commit details
    Browse the repository at this point in the history
  18. tls: expose IETF name for current cipher suite

    OpenSSL has its own legacy names, but knowing the IETF name is useful
    when trouble-shooting, or looking for more information on the cipher.
    
    PR-URL: #30637
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    sam-github authored and targos committed Dec 9, 2019
    Copy the full SHA
    255cd7e View commit details
    Browse the repository at this point in the history
  19. worker: add argv constructor option

    A convenience option to populate `process.argv` in worker threads.
    
    PR-URL: #30559
    Fixes: #30531
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    legendecas authored and targos committed Dec 9, 2019
    Copy the full SHA
    71d43a5 View commit details
    Browse the repository at this point in the history
  20. fs: fix existsSync for invalid symlink at win32

    Fixes: #30538
    
    PR-URL: #30556
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    pd4d10 authored and targos committed Dec 9, 2019
    Copy the full SHA
    60b1e1a View commit details
    Browse the repository at this point in the history
  21. doc: adds assert doc for strict mode with pointer to strict equality

    Refs: #30485
    
    PR-URL: #30486
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    shobhitchittora authored and targos committed Dec 9, 2019
    Copy the full SHA
    2c0f1ed View commit details
    Browse the repository at this point in the history
  22. doc: fix up N-API doc

    PR-URL: #30656
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    NickNaso authored and targos committed Dec 9, 2019
    Copy the full SHA
    543bf9d View commit details
    Browse the repository at this point in the history
  23. doc: revise addons introduction for brevity and clarity

    PR-URL: #30756
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Dec 9, 2019
    Copy the full SHA
    510eb3a View commit details
    Browse the repository at this point in the history
  24. doc: remove usage of "Node" in favor of "Node.js"

    In accordance with the Style Guide, remove "Node" in favor of "Node.js".
    A lint rule for this is forthcoming.
    
    PR-URL: #30758
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Dec 9, 2019
    Copy the full SHA
    7cb84fd View commit details
    Browse the repository at this point in the history
  25. inspector: do not access queueMicrotask from global

    Grab it from the internal module where it's defined instead.
    
    PR-URL: #30732
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    targos committed Dec 9, 2019
    Copy the full SHA
    d3f0dd2 View commit details
    Browse the repository at this point in the history
  26. test: increase debugging information in subprocess test

    Refs: #25988 (comment)
    
    PR-URL: #30761
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Dec 9, 2019
    Copy the full SHA
    54a266c View commit details
    Browse the repository at this point in the history
  27. tools: update ESLint to 6.7.2

    PR-URL: #30762
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and targos committed Dec 9, 2019
    Copy the full SHA
    7b9400c View commit details
    Browse the repository at this point in the history
  28. esm: make specifier flag clearly experimental

    `--es-module-specifier-resolution` is the only flagged portion of the
    ESM implementation that does not have the word experimental in the flag
    name. This commit changes the flag to:
    
    `--experimental-specifier-resolution`
    
    `--es-module-specifier-resolution` remains as an alias for backwards
    compatibility but it is no longer documented.
    
    PR-URL: #30678
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    MylesBorins authored and targos committed Dec 9, 2019
    Copy the full SHA
    eb4f443 View commit details
    Browse the repository at this point in the history
  29. test: remove duplicate entries from root.status

    PR-URL: #30769
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    richardlau authored and targos committed Dec 9, 2019
    Copy the full SHA
    55a270b View commit details
    Browse the repository at this point in the history
  30. module: add warnings for experimental flags

    PR-URL: #30617
    Fixes: #30600
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    pd4d10 authored and targos committed Dec 9, 2019
    Copy the full SHA
    851f313 View commit details
    Browse the repository at this point in the history
  31. doc: remove imprecise and redundant testing text

    Remove "All commits...are tested on these platforms." for the following
    reasons:
    
    * It's somewhat redundant. The surrounding text makes it clear that we
      test on these platforms.
    * It's imprecise. Commits, such as those that only affect documentation
      or linting do not get tested on all the platforms. (Well, perhaps they
      do in an after-the-fact kind of way when a subsequent commit gets
      tested, but I think that's a stretch.)
    
    PR-URL: #30763
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Trott authored and targos committed Dec 9, 2019
    Copy the full SHA
    67823e8 View commit details
    Browse the repository at this point in the history
  32. test: simplify tmpdir import in wasi tests

    PR-URL: #30770
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Trott authored and targos committed Dec 9, 2019
    Copy the full SHA
    fb31ab5 View commit details
    Browse the repository at this point in the history
  33. test: improve wasi test coverage

    Add test coverage for options validation in WASI constructor.
    
    PR-URL: #30770
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Trott authored and targos committed Dec 9, 2019
    Copy the full SHA
    30756e3 View commit details
    Browse the repository at this point in the history
  34. lib,test: improves ERR_REQUIRE_ESM message

    PR-URL: #30694
    Fixes: #30599
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    juanarbol authored and targos committed Dec 9, 2019
    Copy the full SHA
    94f237e View commit details
    Browse the repository at this point in the history
  35. module: ignore resolution failures for inspect-brk

    The resolution for the main entry point may fail when the resolution
    requires a preloaded module to be executed first (for example when
    adding new extensions to the resolution process). Silently skipping
    such failures allow us to defer the resolution as long as needed
    without having any adverse change (since the main entry point won't
    resolve anyway if it really can't be resolved at all).
    
    PR-URL: #30336
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    arcanis authored and targos committed Dec 9, 2019
    Copy the full SHA
    bd2f127 View commit details
    Browse the repository at this point in the history
  36. module: fixup lint and test regressions

    PR-URL: #30802
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: João Reis <reis@janeasystems.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    guybedford authored and targos committed Dec 9, 2019
    Copy the full SHA
    a7ec78f View commit details
    Browse the repository at this point in the history
  37. doc: add documentation about node_mksnapshot and mkcodecache

    PR-URL: #30773
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    joyeecheung authored and targos committed Dec 9, 2019
    Copy the full SHA
    1d5c4e2 View commit details
    Browse the repository at this point in the history
  38. test: use callback arguments in getconnections test

    Use previously-unused callback arguments in
    test-child-process-fork-getconnections.
    
    PR-URL: #30775
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Dec 9, 2019
    Copy the full SHA
    5067463 View commit details
    Browse the repository at this point in the history
  39. lib: delay access to CLI option to pre-execution

    CLI options should not be added through the config binding, instead
    they are already available in the JS land via
    `require('internal/options')`. Also CLI options in principle should
    be processed in pre-execution instead of bootstrap scripts.
    
    PR-URL: #30778
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    joyeecheung authored and targos committed Dec 9, 2019
    Copy the full SHA
    325128e View commit details
    Browse the repository at this point in the history
  40. doc: improve napi formatting

    This addresses two nits:
    
    1. Bullet points that span over multiple lines should be indented
       consitently. Otherwise they are not always properly highlighted.
    2. Lines breaks after titles improve the readability.
    
    PR-URL: #30772
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and targos committed Dec 9, 2019
    Copy the full SHA
    1baa6ab View commit details
    Browse the repository at this point in the history
  41. doc,benchmark: move benchmark guide to benchmark directory

    The doc/guides directory looks like a place for guides to using Node.js
    but it's actually where we store development/internal documentation.
    Move the benchmark guide to the benchmark directory where someone (who
    doesn't know that bit of somewhat-surprising information) is more likely
    to find it.
    
    PR-URL: #30781
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and targos committed Dec 9, 2019
    Copy the full SHA
    bbbba76 View commit details
    Browse the repository at this point in the history
  42. build: remove (almost) unused macros/constants

    Macros, like CHECK, cause issues for tracking coverage because
    they modify the source before it's placed in V8. Upon investigation
    it seemed that we only used this functionality in two places:
    internal/vm/module.js, and internal/async_hooks.js (in comments).
    
    Given this, it seemed to make more sense to move CHECK to
    JavaScript, and retire a mostly unused build step.
    
    PR-URL: #30755
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    bcoe authored and targos committed Dec 9, 2019
    Copy the full SHA
    43e947a View commit details
    Browse the repository at this point in the history
  43. http2: small clean up in OnStreamRead

    PR-URL: #30351
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    lundibundi authored and targos committed Dec 9, 2019
    Copy the full SHA
    3840abe View commit details
    Browse the repository at this point in the history
  44. http2: streamline OnStreamRead streamline memory accounting

    * avoid consecutive decrement/increment session memory calls.
    * only Resize the buffer when it is needed.
    * flip `stream_buf_offset_` condition to the LIKELY case.
    
    PR-URL: #30351
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    lundibundi authored and targos committed Dec 9, 2019
    Copy the full SHA
    71bb026 View commit details
    Browse the repository at this point in the history
  45. repl: use better uncaught exceptions indicator

    This switches "Thrown:" with "Uncaught" to outline clearer that the
    thrown error is not caught.
    
    PR-URL: #29676
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    BridgeAR authored and targos committed Dec 9, 2019
    Copy the full SHA
    c440f3f View commit details
    Browse the repository at this point in the history
  46. tools: update icu to 65.1

    Update the version of the bundled ICU (deps/icu-small) to ICU version
    65.2.
    
    Fixes: #30211
    Fixes: #29540
    
    PR-URL: #30232
    Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    albertyw authored and targos committed Dec 9, 2019
    Copy the full SHA
    0cb7720 View commit details
    Browse the repository at this point in the history
  47. deps: fix OPENSSLDIR on Windows

    Backslashes and spaces are need to be escaped to define OPENSSLDIR to
    "C:\Program Files\Common Files\SSL".
    
    PR-URL: #29456
    Refs: #29455
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    shigeki authored and targos committed Dec 9, 2019
    Copy the full SHA
    4588606 View commit details
    Browse the repository at this point in the history
  48. tools: update remark-preset-lint-node to 1.11.0

    PR-URL: #30789
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Trott authored and targos committed Dec 9, 2019
    Copy the full SHA
    2b687af View commit details
    Browse the repository at this point in the history
  49. deps: upgrade to libuv 1.34.0

    Notable changes:
    
    - Fix handling of large files in uv_fs_copyfile().
      Fixes: #30085
    - Fix Android build errors.
    - uv_sleep() has been added.
    - uv_interface_addresses() IPv6 netmask support has been fixed.
      Fixes: #30504
    - uv_fs_mkstemp() has been added.
    
    PR-URL: #30783
    Fixes: #30085
    Fixes: #30504
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    cjihrig authored and targos committed Dec 9, 2019
    Copy the full SHA
    ca47f72 View commit details
    Browse the repository at this point in the history
  50. util: improve inspect's customInspect performance

    This improves the performance to copy user options that are then
    passed through to the custom inspect function.
    
    The performance improvement depends on the complexity of the custom
    inspect function. For very basic cases this is 100% faster than
    before.
    
    PR-URL: #30659
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    BridgeAR authored and targos committed Dec 9, 2019
    Copy the full SHA
    77ffd54 View commit details
    Browse the repository at this point in the history
  51. util: add more predefined color codes to inspect.colors

    This adds most commonly used ANSI color codes to
    `util.inspect.colors`.
    
    PR-URL: #30659
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    BridgeAR authored and targos committed Dec 9, 2019
    Copy the full SHA
    608d720 View commit details
    Browse the repository at this point in the history
  52. benchmark: add more util inspect and format benchmarks

    This adds a couple of benchmarks to check different options and code
    paths.
    
    PR-URL: #30767
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and targos committed Dec 9, 2019
    Copy the full SHA
    ad4d52d View commit details
    Browse the repository at this point in the history
  53. util: improve performance inspecting proxies

    This makes sure we do not retrieve the handler in case it's not
    required. This improves the performance a tiny bit for these cases.
    
    PR-URL: #30767
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and targos committed Dec 9, 2019
    Copy the full SHA
    eeaeb51 View commit details
    Browse the repository at this point in the history
  54. util: never trigger any proxy traps using format()

    PR-URL: #30767
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and targos committed Dec 9, 2019
    Copy the full SHA
    3898b23 View commit details
    Browse the repository at this point in the history
  55. assert,util: stricter type comparison using deep equal comparisons

    This veryfies that both input arguments are always of the identical
    type. It was possible to miss a few cases before. This change applies
    to all deep equal assert functions (e.g., `assert.deepStrictEqual()`)
    and to `util.isDeepStrictEqual()`.
    
    PR-URL: #30764
    Refs: #30743
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and targos committed Dec 9, 2019
    Copy the full SHA
    1c4b2f1 View commit details
    Browse the repository at this point in the history
  56. test: run more assert tests

    This makes sure the assertion does not depend on the argument order.
    It also removes comments that do not apply anymore and verifies the
    behavior for the loose and strict implementation.
    
    PR-URL: #30764
    Refs: #30743
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and targos committed Dec 9, 2019
    Copy the full SHA
    3557659 View commit details
    Browse the repository at this point in the history
  57. module: fix dynamic import from eval

    This allows dynamic import to work from CLI `--eval` with or without
    `--input-type=module`.
    
    Fixes: #30591
    
    PR-URL: #30624
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
    Reviewed-By: Ben Coe <bencoe@gmail.com>
    coreyfarrell authored and targos committed Dec 9, 2019
    Copy the full SHA
    d4aa656 View commit details
    Browse the repository at this point in the history
  58. util: add internal sleep() function

    PR-URL: #30787
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    cjihrig authored and targos committed Dec 9, 2019
    Copy the full SHA
    dc69cbe View commit details
    Browse the repository at this point in the history
  59. test: remove common.busyLoop()

    This commit replaces common.busyLoop() with sleep().
    
    PR-URL: #30787
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    cjihrig authored and targos committed Dec 9, 2019
    Copy the full SHA
    a574cb0 View commit details
    Browse the repository at this point in the history
  60. lib: add warning on dynamic import es modules

    PR-URL: #30720
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    juanarbol authored and targos committed Dec 9, 2019
    Copy the full SHA
    d9d6475 View commit details
    Browse the repository at this point in the history
  61. lib: add parent to ERR_UNKNOWN_FILE_EXTENSION

    - default_resolve updated to pass parentURL into error
    - ERR_UNKNOWN_FILE_EXTENSION updated to include parentURL
    - test added to check for import message in error
    
    PR-URL: #30728
    Fixes: #30721
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    qualitymanifest authored and targos committed Dec 9, 2019
    Copy the full SHA
    2c439bb View commit details
    Browse the repository at this point in the history
  62. tools: use CC instead of CXX when pointing to gcc

    Current CC flag points to g++ instead of gcc which is causing failures
    when compiling V8.
    
    PR-URL: #30817
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Milad Farazmand authored and targos committed Dec 9, 2019
    Copy the full SHA
    1ed1a64 View commit details
    Browse the repository at this point in the history
  63. test: improve WASI options validation

    Refs: https://github.com/nodejs/node/pull/30770/files#r353051438
    
    PR-URL: #30800
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and targos committed Dec 9, 2019
    Copy the full SHA
    25e3696 View commit details
    Browse the repository at this point in the history
  64. src: use checked allocations in WASI::New()

    PR-URL: #30809
    Refs: #30257
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    cjihrig authored and targos committed Dec 9, 2019
    Copy the full SHA
    e6e379e View commit details
    Browse the repository at this point in the history
  65. src: free preopen memory in WASI::New()

    PR-URL: #30809
    Refs: #30257
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    cjihrig authored and targos committed Dec 9, 2019
    Copy the full SHA
    8ad53ab View commit details
    Browse the repository at this point in the history
  66. readline: eagerly load string_decoder

    There was no point in lazy loading the string_decoder, since it
    would be used in all cases anyway.
    
    PR-URL: #30807
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    BridgeAR authored and targos committed Dec 9, 2019
    Copy the full SHA
    2f1ae4f View commit details
    Browse the repository at this point in the history
  67. test: mark addons/openssl-bindings/test flaky on arm

    PR-URL: #30838
    Refs: #30786
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    richardlau authored and targos committed Dec 9, 2019
    Copy the full SHA
    4dc9d8d View commit details
    Browse the repository at this point in the history
  68. src: don't use deprecated OpenSSL APIs

    The extra headers are needed when deprecated APIs are disabled as ssl.h
    no longer includes them implicitly.
    
    PR-URL: #30812
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    neheb authored and targos committed Dec 9, 2019
    Copy the full SHA
    ccf0917 View commit details
    Browse the repository at this point in the history
  69. src: port memory-tracking allocator from QUIC repo

    This implements a memory-tracking allocator that can be used to
    provide memory allocation facilities to several thread-safe C
    libraries, including nghttp2, nghttp3, ngtcp3 and uvwasi.
    
    Refs: https://github.com/nodejs/quic/blob/34ee0bc96f804c73cb22b2945a1a78f780938492/src/node_mem.h
    Co-authored-by: James M Snell <jasnell@gmail.com>
    
    PR-URL: #30745
    Refs: nodejs/quic#126
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    addaleax authored and targos committed Dec 9, 2019
    Copy the full SHA
    041daaa View commit details
    Browse the repository at this point in the history
  70. http2: use shared memory tracking implementation

    The extensive testing done on http2 makes it easier to make sure
    the implementation is correct (and doesn’t diverge unnecessarily).
    
    Refs: nodejs/quic#126
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    
    PR-URL: #30745
    Refs: https://github.com/nodejs/quic/blob/34ee0bc96f804c73cb22b2945a1a78f780938492/src/node_mem.h
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    addaleax authored and targos committed Dec 9, 2019
    Copy the full SHA
    8a9f57d View commit details
    Browse the repository at this point in the history
  71. http2: track nghttp2-allocated memory in heap snapshot

    PR-URL: #30745
    Refs: https://github.com/nodejs/quic/blob/34ee0bc96f804c73cb22b2945a1a78f780938492/src/node_mem.h
    Refs: nodejs/quic#126
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    addaleax authored and targos committed Dec 9, 2019
    Copy the full SHA
    d17ea8f View commit details
    Browse the repository at this point in the history
  72. deps: update uvwasi

    PR-URL: #30745
    Refs: https://github.com/nodejs/quic/blob/34ee0bc96f804c73cb22b2945a1a78f780938492/src/node_mem.h
    Refs: nodejs/quic#126
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    addaleax authored and targos committed Dec 9, 2019
    Copy the full SHA
    13fe9f7 View commit details
    Browse the repository at this point in the history
  73. wasi: use memory-tracking allocator

    This:
    
    - Protects against memory leaks in uvwasi.
    - Allows tracking the allocated memory in heap dumps.
    
    PR-URL: #30745
    Refs: https://github.com/nodejs/quic/blob/34ee0bc96f804c73cb22b2945a1a78f780938492/src/node_mem.h
    Refs: nodejs/quic#126
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    addaleax authored and targos committed Dec 9, 2019
    Copy the full SHA
    14269d1 View commit details
    Browse the repository at this point in the history
  74. doc: include line/cursor in readline documentation

    Documents the existence and purpose of the `line` and `cursor`
    properties.  `line` can be used for reading the current input value
    during runtime, if reading from a TTY stream.  Both properties are
    necessary when developing a custom CLI input process using `readline`
    as a backend.
    
    Refs: #30347
    Refs: DefinitelyTyped/DefinitelyTyped#40513
    
    PR-URL: #30667
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Js-Brecht authored and targos committed Dec 9, 2019
    Copy the full SHA
    2123d53 View commit details
    Browse the repository at this point in the history
  75. test: mark tests as flaky

    PR-URL: #30848
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    joaocgreis authored and targos committed Dec 9, 2019
    Copy the full SHA
    305e45a View commit details
    Browse the repository at this point in the history
  76. src: improve checked uv loop close output

    Addon developers may run into this when not closing libuv handles
    inside Workers.
    
    Previously, output may have included unhelpful statements such as
    `uv loop at ... has 0 active handles`, which may sound like
    everything’s supposed to be fine actually.
    
    So, instead of printing the active handle count, print the total
    handle count and mark active handles individually.
    
    Also, fix the test for this to work properly and make sure that
    parsing finishes properly.
    
    PR-URL: #30814
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    addaleax authored and targos committed Dec 9, 2019
    Copy the full SHA
    7ed867d View commit details
    Browse the repository at this point in the history
  77. lib: replace Symbol global by the primordials Symbol

    PR-URL: #30737
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Sebastien-Ahkrin authored and targos committed Dec 9, 2019
    Copy the full SHA
    af01417 View commit details
    Browse the repository at this point in the history
  78. test: scale keepalive timeouts for slow machines

    The test was using fixed timeouts and that seems to be causing sporadic
    test failures on pi1-docker host (which is a very slow machine.)
    
    Fixes: #30828
    
    PR-URL: #30834
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    bnoordhuis authored and targos committed Dec 9, 2019
    Copy the full SHA
    97e0efe View commit details
    Browse the repository at this point in the history
  79. fs: add synchronous retries to rimraf

    This commit gives the synchronous version of rimraf the same
    linear retry logic as the asynchronous version. Prior to this
    commit, sync rimraf kept retrying the operation as soon as
    possible until maxRetries was reached.
    
    PR-URL: #30785
    Fixes: #30580
    Refs: #30569
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    cjihrig authored and targos committed Dec 9, 2019
    Copy the full SHA
    5523950 View commit details
    Browse the repository at this point in the history
  80. fs: reduce unnecessary sync rimraf retries

    rimraf should only retry if certain errors are encountered.
    Additionally, there is no point sleeping if an error occurs
    on the last try.
    
    PR-URL: #30785
    Fixes: #30580
    Refs: #30569
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    cjihrig authored and targos committed Dec 9, 2019
    Copy the full SHA
    7e1dee3 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2019

  1. http: llhttp opt-in insecure HTTP header parsing

    Allow insecure HTTP header parsing. Make clear it is insecure.
    
    See:
    - #30553
    - #27711 (comment)
    - #30515
    
    PR-URL: #30567
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    sam-github authored and targos committed Dec 10, 2019
    Copy the full SHA
    daca078 View commit details
    Browse the repository at this point in the history
  2. repl: support previews by eager evaluating input

    This adds input previews by using the inspectors eager evaluation
    functionality.
    It is implemented as additional line that is not counted towards
    the actual input. In case no colors are supported, it will be visible
    as comment. Otherwise it's grey.
    It will be triggered on any line change. It is heavily tested against
    edge cases and adheres to "dumb" terminals (previews are deactived
    in that case).
    
    PR-URL: #30811
    Fixes: #20977
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    BridgeAR authored and targos committed Dec 10, 2019
    Copy the full SHA
    e551c16 View commit details
    Browse the repository at this point in the history
  3. src: fix the false isatty() issue on IBMi

    On IBMi PASE isatty() always returns true for stdin, stdout and stderr.
    Use ioctl() instead to identify whether it's actually a TTY.
    
    PR-URL: #30829
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    dmabupt authored and targos committed Dec 10, 2019
    Copy the full SHA
    6088603 View commit details
    Browse the repository at this point in the history
  4. test: refactor test-accessor-properties

    PR-URL: #29943
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    himself65 authored and targos committed Dec 10, 2019
    Copy the full SHA
    5ae3a85 View commit details
    Browse the repository at this point in the history
  5. doc: improve doc Http2Stream: FrameError, Timeout and Trailers

    Document arguments for the 'frameError', 'timeout' and 'trailers'
    event.
    
    PR-URL: #30373
    Fixes: nodejs/help#877
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    dev-script authored and targos committed Dec 10, 2019
    Copy the full SHA
    0022d75 View commit details
    Browse the repository at this point in the history
  6. doc: deprecate http finished

    PR-URL: #28679
    Refs: #28651
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    ronag authored and targos committed Dec 10, 2019
    Copy the full SHA
    93ca4f4 View commit details
    Browse the repository at this point in the history
  7. lib: replace var with let/const

    PR-URL: #30384
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    jens-cappelle authored and targos committed Dec 10, 2019
    Copy the full SHA
    0a34fcb View commit details
    Browse the repository at this point in the history
  8. module: fix require in node repl

    Fixes: #30808
    
    PR-URL: #30835
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    ZYSzys authored and targos committed Dec 10, 2019
    Copy the full SHA
    8e16093 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2019

  1. fs: only operate on buffers in rimraf

    PR-URL: #30569
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ben Coe <bencoe@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    cjihrig authored and targos committed Dec 11, 2019
    Copy the full SHA
    5e98de1 View commit details
    Browse the repository at this point in the history
  2. fs: retry unlink operations in rimraf

    This commit adds synchronous retry logic to
    the unlinkSync() calls in rimraf.
    
    PR-URL: #30569
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ben Coe <bencoe@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    cjihrig authored and targos committed Dec 11, 2019
    Copy the full SHA
    18758ef View commit details
    Browse the repository at this point in the history
  3. test: use fs rimraf to refresh tmpdir

    Now that the functionality is built into core, use it to
    refresh the test suite's tmpdir.
    
    PR-URL: #30569
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ben Coe <bencoe@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    cjihrig authored and targos committed Dec 11, 2019
    Copy the full SHA
    cc4a6ed View commit details
    Browse the repository at this point in the history
  4. fs: synchronize close with other I/O for streams

    Part of the flakiness in the
    parallel/test-readline-async-iterators-destroy test comes from
    fs streams starting `_read()` and `_destroy()` without waiting
    for the other to finish, which can lead to the `fs.read()` call
    resulting in `EBADF` if timing is bad.
    
    Fix this by synchronizing write and read operations with `close()`.
    
    Refs: #30660
    
    PR-URL: #30837
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    addaleax authored and targos committed Dec 11, 2019
    Copy the full SHA
    6c07a72 View commit details
    Browse the repository at this point in the history
  5. build: ease DragonFlyBSD build

    Implicitly pretending being FreeBSD and disable
    large pages for this platform.
    
    PR-URL: #30201
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    devnexen authored and targos committed Dec 11, 2019
    Copy the full SHA
    3d05d4b View commit details
    Browse the repository at this point in the history
  6. benchmark: improve --filter pattern matching

      * Let users provide more than one pattern by repeating the flag
      * Add new flag --exclude to exclude patterns
      * Add tests for --filter
      * Document --filter
    
    This commit also fixes a bug where things like
    `compare.js --new --old binary --new binary` was acceptable (now the
    script will exit and print the usage message).
    
    PR-URL: #29987
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    mmarchini authored and targos committed Dec 11, 2019
    Copy the full SHA
    78eaf50 View commit details
    Browse the repository at this point in the history
  7. test: wait for stream close before writing to file

    Wait for async operations on a file to finish before writing to it
    again.
    
    This fixes flakiness in parallel/test-readline-async-iterators-destroy.
    
    PR-URL: #30836
    Fixes: #30660
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    addaleax authored and targos committed Dec 11, 2019
    Copy the full SHA
    ce21fc7 View commit details
    Browse the repository at this point in the history
  8. net: remove duplicate _undestroy

    initSocketHandle will call _undestroy.
    
    PR-URL: #30833
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    ronag authored and targos committed Dec 11, 2019
    Copy the full SHA
    123327d View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2019

  1. doc: add code example to inspector.url() method

    PR-URL: #29496
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    juanarbol authored and MylesBorins committed Dec 13, 2019
    Copy the full SHA
    1cce000 View commit details
    Browse the repository at this point in the history
  2. lib: replace every Symbol.for by SymbolFor primordials

    PR-URL: #30857
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Sebastien-Ahkrin authored and MylesBorins committed Dec 13, 2019
    Copy the full SHA
    39898a9 View commit details
    Browse the repository at this point in the history
  3. lib: replace Symbol.iterator by SymbolIterator

    PR-URL: #30859
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Sebastien-Ahkrin authored and MylesBorins committed Dec 13, 2019
    Copy the full SHA
    64ab5c9 View commit details
    Browse the repository at this point in the history
  4. doc: clarify Tier 2 implications in BUILDING.md

    Clarify the explanation of Tier 2 platforms and binary releases.
    
    PR-URL: #30866
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Trott authored and MylesBorins committed Dec 13, 2019
    Copy the full SHA
    9d1c793 View commit details
    Browse the repository at this point in the history
  5. test: assert: fix deepStrictEqual comparing a real array and fake array

    PR-URL: #30743
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    ljharb authored and MylesBorins committed Dec 13, 2019
    Copy the full SHA
    5f42b1f View commit details
    Browse the repository at this point in the history
  6. url: declare iterator inside loop

    Refs: #30281 (comment)
    
    PR-URL: #30509
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    trivikr authored and MylesBorins committed Dec 13, 2019
    Copy the full SHA
    5ab3ca4 View commit details
    Browse the repository at this point in the history
  7. src: accept single argument in getProxyDetails

    This makes sure this function stays backwards compatible in case
    it's accessed through the binding directly.
    
    Refs: #29947 (comment)
    
    PR-URL: #30858
    Refs: #30767
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    BridgeAR authored and MylesBorins committed Dec 13, 2019
    Copy the full SHA
    de36820 View commit details
    Browse the repository at this point in the history
  8. build: add flag to enable pointer compression

    The --experimental-enable-pointer-compression is experimental
    as it breaks ABI compatibility.
    
    PR-URL: #30463
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    mcollina authored and MylesBorins committed Dec 13, 2019
    Copy the full SHA
    dfd3a4d View commit details
    Browse the repository at this point in the history
  9. deps: update npm to 6.13.4

    PR-URL: #30904
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    isaacs authored and MylesBorins committed Dec 13, 2019
    Copy the full SHA
    0379fb6 View commit details
    Browse the repository at this point in the history
  10. build: fix library version and compile flags on Android

    Compiling a library with -fPIE won't do, and on Android libraries
    are not versioned.
    
    PR-URL: #29388
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    gcampax authored and MylesBorins committed Dec 13, 2019
    Copy the full SHA
    d1c4fcc View commit details
    Browse the repository at this point in the history
  11. build: on Android, use android log library to print stack traces

    And other errors like lost promises
    
    PR-URL: #29388
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    gcampax authored and MylesBorins committed Dec 13, 2019
    Copy the full SHA
    d90815d View commit details
    Browse the repository at this point in the history
  12. doc: fix argument type of setAAD

    PR-URL: #30863
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and MylesBorins committed Dec 13, 2019
    Copy the full SHA
    df9df18 View commit details
    Browse the repository at this point in the history
  13. http2: forward debug message in debugStreamObj

    PR-URL: #30840
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    lundibundi authored and MylesBorins committed Dec 13, 2019
    Copy the full SHA
    822fb00 View commit details
    Browse the repository at this point in the history
  14. test: disable colorMode in test-console-group

    Disable colorMode in test-console-group so that the test will succeed if
    run without the test runner from the command line.
    
    PR-URL: #30886
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and MylesBorins committed Dec 13, 2019
    Copy the full SHA
    eb6e32c View commit details
    Browse the repository at this point in the history
  15. doc: edit colorMode information

    Add information about what it means when colorMode is set to false.
    
    PR-URL: #30887
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and MylesBorins committed Dec 13, 2019
    Copy the full SHA
    8bf0da6 View commit details
    Browse the repository at this point in the history
  16. test: work around ENOTEMPTY when cleaning tmp dir

    Replace the homegrown rimrafsync implementation in test/common with
    a call to `fs.rmdirSync(path, { recursive: true })`.
    
    Fixes: #30620
    Fixes: #30844
    
    PR-URL: #30849
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    bnoordhuis authored and MylesBorins committed Dec 13, 2019
    Copy the full SHA
    1b534d5 View commit details
    Browse the repository at this point in the history
  17. module: conditional exports import condition

    PR-URL: #30799
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    guybedford authored and MylesBorins committed Dec 13, 2019
    Copy the full SHA
    e61f4ea View commit details
    Browse the repository at this point in the history
  18. tools: update link to google styleguide for cpplint

    This commit updates two old links to Google's C++ styleguide which
    currently result in a 404 when accessed.
    
    PR-URL: #30876
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    danbev authored and MylesBorins committed Dec 13, 2019
    Copy the full SHA
    5203ffb View commit details
    Browse the repository at this point in the history
  19. lib: enforce use of BigInt from primordials

    PR-URL: #30882
    Refs: #30697
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    targos authored and MylesBorins committed Dec 13, 2019
    Copy the full SHA
    71c6d44 View commit details
    Browse the repository at this point in the history
  20. doc: clarify build support text

    Revise compilation/execution support text to keep it shorter, simpler,
    and hopefully easier to read/understand.
    
    PR-URL: #30899
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Trott authored and MylesBorins committed Dec 13, 2019
    Copy the full SHA
    b3ae532 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2019

  1. 2019-12-17, Version 13.4.0 (Current)

    This is a security release.
    
    For more details about the vulnerability please consult the npm blog:
    
    https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli
    
    Notable Changes:
    * deps:
      * update npm to 6.13.4
        #30904
      * update uvwasi (Anna Henningsen)
        #30745
      * upgrade to libuv 1.34.0 (Colin Ihrig)
        #30783
    * doc:
      * docs deprecate http finished (Robert Nagy)
        #28679
    * events:
      * add captureRejection option (Matteo Collina)
        #27867
    * http:
      * add captureRejection support (Matteo Collina)
        #27867
      * llhttp opt-in insecure HTTP header parsing (Sam Roberts)
        #30567
    * http2:
      * implement capture rection for 'request' and 'stream' events (Matteo Collina)
        #27867
    * net:
      * implement capture rejections for 'connection' event (Matteo Collina)
        #27867
    * repl:
      * support previews by eager evaluating input (Ruben Bridgewater)
        #30811
    * stream:
      * add support for captureRejection option (Matteo Collina)
        #27867
    * tls:
      * implement capture rejections for 'secureConnection' event (Matteo Collina)
        #27867
      * expose IETF name for current cipher suite (Sam Roberts)
        #30637
    * worker:
      * add argv constructor option (legendecas)
        #30559
    
    PR-URL: #30937
    MylesBorins committed Dec 16, 2019
    Copy the full SHA
    f15fe94 View commit details
    Browse the repository at this point in the history