Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: remove lint-js.js #30955

Closed
wants to merge 1 commit into from
Closed

tools: remove lint-js.js #30955

wants to merge 1 commit into from

Commits on Jun 26, 2020

  1. tools: remove lint-js.js

    lint-js.js was implemented before ESLint had a caching feature. It is
    now only used in CI. Let's remove it on the following grounds:
    
    * It results in occasional (and puzzling) yellow CI runs for
      node-test-linter because the tap file is corrupted somehow.
      Interleaved maybe? I don't know, but a simple solution is removing it
      and running ESLint directly.
    
    * On my local laptop, it reduces the linting from about 75 seconds to
      about 55 seconds. This kind of savings is not worth the added
      complexity and the instability noted above.
    Trott committed Jun 26, 2020
    Copy the full SHA
    bfab964 View commit details
    Browse the repository at this point in the history