New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
async_hooks: add executionAsyncResource #30959
Commits on Feb 10, 2020
-
async_hooks: add currentResource
Remove the need for the destroy hook in the basic APM case.
-
-
-
-
-
-
-
-
-
-
Use stack emplace rather than push
This avoids creating a temporary v8::Global
-
Do not push promise resource on init
This means the sync executor or sync start of an async function will have the same execution async resource as the caller which may result in unexpected behaviour but it is likely better than hijacking the rest of the sync context with the promise as the current execution async resource.
-
-
-
-
-
-
-
Stored resource needs to be strong reference
The reference must live long enough to be used for async_hooks triggers but must be reset when a destroy occurs to ensure the resources don't cause a leak but also don't cause a crash.
-
-
Make stronger statement about unsafety of using resource properties o…
…r methods and avoid delete keyword
-
fixup: make benchmark tests pass
Add missing parameters to the test file and rename an option to avoid naming conflicts with another async_hooks benchmark.