Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async_hooks: add executionAsyncResource #30959

Closed
wants to merge 24 commits into from
Closed

Commits on Feb 10, 2020

  1. async_hooks: add currentResource

    Remove the need for the destroy hook in the basic APM case.
    mcollina authored and addaleax committed Feb 10, 2020
    Copy the full SHA
    dd0d929 View commit details
    Browse the repository at this point in the history
  2. rename to ExecutionAsyncResource

    mcollina authored and addaleax committed Feb 10, 2020
    Copy the full SHA
    6ab9a58 View commit details
    Browse the repository at this point in the history
  3. benchmark fix

    mcollina authored and addaleax committed Feb 10, 2020
    Copy the full SHA
    1c4abc1 View commit details
    Browse the repository at this point in the history
  4. store resource on AsyncHooks object

    Qard authored and addaleax committed Feb 10, 2020
    Copy the full SHA
    2fb5a50 View commit details
    Browse the repository at this point in the history
  5. Update docs to use executionAsyncResource

    Qard authored and addaleax committed Feb 10, 2020
    Copy the full SHA
    63fcaa5 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    e1a4e88 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    b66098d View commit details
    Browse the repository at this point in the history
  8. Clean up some unnecessary bits

    Qard authored and addaleax committed Feb 10, 2020
    Copy the full SHA
    b95b514 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    a388de9 View commit details
    Browse the repository at this point in the history
  10. Minor docs improvements

    Qard authored and addaleax committed Feb 10, 2020
    Copy the full SHA
    b3ecef0 View commit details
    Browse the repository at this point in the history
  11. Use stack emplace rather than push

    This avoids creating a temporary v8::Global
    Qard authored and addaleax committed Feb 10, 2020
    Copy the full SHA
    0fd3be8 View commit details
    Browse the repository at this point in the history
  12. Do not push promise resource on init

    This means the sync executor or sync start of an async function
    will have the same execution async resource as the caller
    which may result in unexpected behaviour but it is likely better
    than hijacking the rest of the sync context with the promise
    as the current execution async resource.
    Qard authored and addaleax committed Feb 10, 2020
    Copy the full SHA
    1eb13c5 View commit details
    Browse the repository at this point in the history
  13. Rename test files

    Qard authored and addaleax committed Feb 10, 2020
    Copy the full SHA
    9381824 View commit details
    Browse the repository at this point in the history
  14. Interact with resource stack directly

    Qard authored and addaleax committed Feb 10, 2020
    Copy the full SHA
    851e478 View commit details
    Browse the repository at this point in the history
  15. Cleanup some things

    Qard authored and addaleax committed Feb 10, 2020
    Copy the full SHA
    30f79b2 View commit details
    Browse the repository at this point in the history
  16. Handle object reuse properly

    Qard authored and addaleax committed Feb 10, 2020
    Copy the full SHA
    621d089 View commit details
    Browse the repository at this point in the history
  17. Add test for object reuse fix

    Qard authored and addaleax committed Feb 10, 2020
    Copy the full SHA
    c485b39 View commit details
    Browse the repository at this point in the history
  18. Make reused resource storage weak

    Qard authored and addaleax committed Feb 10, 2020
    Copy the full SHA
    36bcdfa View commit details
    Browse the repository at this point in the history
  19. Stored resource needs to be strong reference

    The reference must live long enough to be used for async_hooks triggers
    but must be reset when a destroy occurs to ensure the resources don't
    cause a leak but also don't cause a crash.
    Qard authored and addaleax committed Feb 10, 2020
    Copy the full SHA
    60b33d2 View commit details
    Browse the repository at this point in the history
  20. Copy the full SHA
    48920e3 View commit details
    Browse the repository at this point in the history
  21. Better resource stack clearing

    Qard authored and addaleax committed Feb 10, 2020
    Copy the full SHA
    1d68999 View commit details
    Browse the repository at this point in the history
  22. Make stronger statement about unsafety of using resource properties o…

    …r methods and avoid delete keyword
    Qard authored and addaleax committed Feb 10, 2020
    Copy the full SHA
    a8f00fc View commit details
    Browse the repository at this point in the history
  23. fixup: make benchmark tests pass

    Add missing parameters to the test file and rename an option
    to avoid naming conflicts with another async_hooks benchmark.
    addaleax committed Feb 10, 2020
    Copy the full SHA
    1a7243c View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2020

  1. fixup: docs review nit

    addaleax committed Feb 11, 2020
    Copy the full SHA
    3402fac View commit details
    Browse the repository at this point in the history