wasi: require CLI flag to require() wasi module #30963

cjihrig · 2019-12-14T16:16:50Z

This commit ensures that the WASI module cannot be require()'ed without a CLI flag while the module is still experimental.

This fixes a regression from #30778.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

test-wasi-start-validation.js should require the --experimental-wasi-unstable-preview0 flag in order to run. However, due to a recent regression, that hasn't been enforced. nodejs#30963 fixes the regression and will cause this test to start (correctly) failing. This commit adds the missing flag.

richardlau · 2019-12-15T00:27:28Z

Test failure looks relevant:
https://travis-ci.com/nodejs/node/jobs/267277987#L273-L296

=== release test-code-cache ===
Path: parallel/test-code-cache
--- stderr ---
internal/modules/cjs/loader.js:1026
    throw err;
    ^

Error: Cannot find module 'wasi'
Require stack:
- /home/travis/build/nodejs/node/test/parallel/test-code-cache.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:1023:17)
    at Function.Module._load (internal/modules/cjs/loader.js:910:27)
    at Module.require (internal/modules/cjs/loader.js:1085:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (/home/travis/build/nodejs/node/test/parallel/test-code-cache.js:19:3)
    at Module._compile (internal/modules/cjs/loader.js:1196:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1216:10)
    at Module.load (internal/modules/cjs/loader.js:1045:32)
    at Function.Module._load (internal/modules/cjs/loader.js:949:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [ '/home/travis/build/nodejs/node/test/parallel/test-code-cache.js' ]
}
Command: out/Release/node --expose-internals /home/travis/build/nodejs/node/test/parallel/test-code-cache.js

test-wasi-start-validation.js should require the --experimental-wasi-unstable-preview0 flag in order to run. However, due to a recent regression, that hasn't been enforced. #30963 fixes the regression and will cause this test to start (correctly) failing. This commit adds the missing flag. PR-URL: #30971 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

This commit ensures that the WASI module cannot be require()'ed without a CLI flag while the module is still experimental. This fixes a regression from nodejs#30778.

nodejs-github-bot · 2019-12-15T17:11:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27718/

nodejs-github-bot · 2019-12-15T19:08:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27720/ 💛

danbev · 2019-12-17T05:11:10Z

Landed in efb9084.

This commit ensures that the WASI module cannot be require()'ed without a CLI flag while the module is still experimental. This fixes a regression from #30778. PR-URL: #30963 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

ljharb · 2019-12-17T23:07:23Z

v13.4 seems to have been released without this fix.

ljharb · 2019-12-17T23:11:57Z

For future reference, if CIGTM includes resolve's tests, then this sort of thing can be caught prior to a release :-)

test-wasi-start-validation.js should require the --experimental-wasi-unstable-preview0 flag in order to run. However, due to a recent regression, that hasn't been enforced. #30963 fixes the regression and will cause this test to start (correctly) failing. This commit adds the missing flag. PR-URL: #30971 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

This commit ensures that the WASI module cannot be require()'ed without a CLI flag while the module is still experimental. This fixes a regression from #30778. PR-URL: #30963 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

Notable Changes: * cli: * add --trace-exit cli option (legendecas) #30516 * http,https: * increase server headers timeout (Tim Costa) #30071 * readline: * update ansi-regex (Ruben Bridgewater) #30907 * promote \_getCursorPos to public api (Jeremy Albright) #30687 * repl: * add completion preview (Ruben Bridgewater) #30907 * util: * add Set and map size to inspect output (Ruben Bridgewater) #30225 * wasi: * require CLI flag to require() wasi module (Colin Ihrig) #30963 PR-URL: #31010

Running `resolve`'s tests will help avoid problems like nodejs/node#30963 from occurring silently.

test-wasi-start-validation.js should require the --experimental-wasi-unstable-preview0 flag in order to run. However, due to a recent regression, that hasn't been enforced. #30963 fixes the regression and will cause this test to start (correctly) failing. This commit adds the missing flag. PR-URL: #30971 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

This commit ensures that the WASI module cannot be require()'ed without a CLI flag while the module is still experimental. This fixes a regression from #30778. PR-URL: #30963 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

test-wasi-start-validation.js should require the --experimental-wasi-unstable-preview0 flag in order to run. However, due to a recent regression, that hasn't been enforced. #30963 fixes the regression and will cause this test to start (correctly) failing. This commit adds the missing flag. PR-URL: #30971 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

This commit ensures that the WASI module cannot be require()'ed without a CLI flag while the module is still experimental. This fixes a regression from #30778. PR-URL: #30963 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

addaleax approved these changes Dec 14, 2019

View reviewed changes

richardlau approved these changes Dec 14, 2019

View reviewed changes

cjihrig mentioned this pull request Dec 15, 2019

test: add missing test flags #30971

Closed

3 tasks

cjihrig force-pushed the require-wasi branch from cfb211c to a3c8438 Compare December 15, 2019 02:44

BridgeAR approved these changes Dec 15, 2019

View reviewed changes

cjihrig added 2 commits December 15, 2019 11:41

wasi: require CLI flag to require() wasi module

909a870

This commit ensures that the WASI module cannot be require()'ed without a CLI flag while the module is still experimental. This fixes a regression from nodejs#30778.

fixup! wasi: require CLI flag to require() wasi module

5a547f3

cjihrig force-pushed the require-wasi branch from a3c8438 to 5a547f3 Compare December 15, 2019 16:41

jasnell approved these changes Dec 15, 2019

View reviewed changes

cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 15, 2019

Trott approved these changes Dec 15, 2019

View reviewed changes

devnexen approved these changes Dec 16, 2019

View reviewed changes

danbev closed this Dec 17, 2019

cjihrig deleted the require-wasi branch December 17, 2019 14:44

MylesBorins mentioned this pull request Dec 17, 2019

v13.5.0 proposal #31010

Merged

ljharb mentioned this pull request Dec 17, 2019

lookup: add resolve nodejs/citgm#775

Merged

15 tasks

richardlau pushed a commit to nodejs/citgm that referenced this pull request Jan 7, 2020

lookup: add resolve (#775)

4e4a773

Running `resolve`'s tests will help avoid problems like nodejs/node#30963 from occurring silently.

targos mentioned this pull request Jan 15, 2020

v12.15.0 release proposal #31368

Closed

MylesBorins mentioned this pull request Feb 8, 2020

v12.16.0 proposal #31691

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

wasi: require CLI flag to require() wasi module #30963

wasi: require CLI flag to require() wasi module #30963

cjihrig commented Dec 14, 2019

richardlau commented Dec 15, 2019

nodejs-github-bot commented Dec 15, 2019

nodejs-github-bot commented Dec 15, 2019 •

edited by cjihrig

danbev commented Dec 17, 2019

ljharb commented Dec 17, 2019 •

edited

ljharb commented Dec 17, 2019

wasi: require CLI flag to require() wasi module #30963

wasi: require CLI flag to require() wasi module #30963

Conversation

cjihrig commented Dec 14, 2019

Checklist

richardlau commented Dec 15, 2019

nodejs-github-bot commented Dec 15, 2019

nodejs-github-bot commented Dec 15, 2019 • edited by cjihrig

danbev commented Dec 17, 2019

ljharb commented Dec 17, 2019 • edited

ljharb commented Dec 17, 2019

nodejs-github-bot commented Dec 15, 2019 •

edited by cjihrig

ljharb commented Dec 17, 2019 •

edited