Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: cherry-pick d3a1a5b6c491 #31005

Closed
wants to merge 1 commit into from
Closed

Commits on Dec 17, 2019

  1. deps: V8: cherry-pick d3a1a5b6c491

    Original commit message:
    
        [objects] Fix memory leak in PrototypeUsers::Add
    
        PrototypeUsers::Add now iterates the WeakArrayList to find empty slots
        before growing the array. Not reusing empty slots caused a memory leak.
    
        It might also be desirable to shrink the WeakArrayList in the future.
        Right now it is only compacted when invoking CreateBlob.
    
        Also removed unused PrototypeUsers::IsEmptySlot declaration.
    
        Bug: v8:10031
        Change-Id: I570ec78fca37e8f0c794f1f40846a4daab47c225
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967317
        Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
        Reviewed-by: Igor Sheludko <ishell@chromium.org>
        Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#65456}
    
    Refs: v8/v8@d3a1a5b
    Fixes: nodejs#30753
    targos committed Dec 17, 2019
    Copy the full SHA
    cceb2a8 View commit details
    Browse the repository at this point in the history