Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repl: use for...of #31050

Closed
wants to merge 1 commit into from
Closed

repl: use for...of #31050

wants to merge 1 commit into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Dec 21, 2019

Searched for regular expression for \([^\.]*.length in lib and made changes in repl submodule

Refs: #30910 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Dec 21, 2019
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR
Copy link
Member

I think it would be better to have a single PR that include #31049 and #31051. Having lots of very tiny PRs is a lot of overhead in this case.

I am not sure we should really change these as long as we do not touch any of these files due to something else though.

@trivikr
Copy link
Member Author

trivikr commented Dec 24, 2019

@cjihrig had raised similar request, and this is explanation I'd given #30962 (comment)

A single PR will need lot of follow-up, when different decisions are taken for different submodules like:

@nodejs-github-bot
Copy link
Collaborator

@trivikr
Copy link
Member Author

trivikr commented Jan 4, 2020

Closing as most collaborators are opposed to such changes.
Example #30958 (comment)

@trivikr trivikr closed this Jan 4, 2020
@trivikr trivikr deleted the repl-for-of branch August 31, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants