Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v12.x] src: make --use-largepages a runtime option #31063

Commits on Dec 31, 2019

  1. src: make --use-largepages a runtime option

    Moves the option that instructs Node.js to-remap its static code to
    large pages from a configure-time option to a runtime option. This
    should make it easy to assess the performance impact of such a change
    without having to custom-build.
    
    PR-URL: nodejs#30954
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Co-authored-by: David Carlier <devnexen@gmail.com>
    Gabriel Schulhof and devnexen committed Dec 31, 2019
    Copy the full SHA
    3dffd75 View commit details
    Browse the repository at this point in the history
  2. build: re-introduce --use-largepages as no-op

    Re-introduce the build-time option as a no-op in order to retain
    backward compatibility for LTS purposes.
    
    Re: nodejs#31063 (review)
    PR_URL: nodejs#31075
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Gabriel Schulhof committed Dec 31, 2019
    Copy the full SHA
    a06a137 View commit details
    Browse the repository at this point in the history
  3. build: switch realpath to pwd

    PR-URL: nodejs#31095
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    bcoe authored and Gabriel Schulhof committed Dec 31, 2019
    Copy the full SHA
    40afe3d View commit details
    Browse the repository at this point in the history
  4. src: make large_pages node.cc include conditional

    The usage of the relevant methods from the file is conditional so make
    the include conditional too.
    
    PR-URL: nodejs#31078
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    lundibundi authored and Gabriel Schulhof committed Dec 31, 2019
    Copy the full SHA
    b74afb3 View commit details
    Browse the repository at this point in the history
  5. build: warn upon --use-largepages config option

    Emit a warning when the user configures with `--use-largepages` and/or
    `--use-largepages-script-lld` informing them that the option is now
    available as a Node.js runtime option once it is built.
    
    Refs: nodejs#31063 (comment)
    PR-URL: nodejs#31103
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Gabriel Schulhof committed Dec 31, 2019
    Copy the full SHA
    c48f9d1 View commit details
    Browse the repository at this point in the history