Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: modernize DH/ECDH/ECDH-ES #31178

Closed
wants to merge 5 commits into from
Closed

crypto: modernize DH/ECDH/ECDH-ES #31178

wants to merge 5 commits into from
+634 −47

Commits on Jan 20, 2020

  1. crypto: add key type 'dh' 

    The new key type 'dh' corresponds to EVP_PKEY_DH.
    @tniessen
    tniessen committed Jan 20, 2020
    Copy the full SHA
    392b385 View commit details
    Browse the repository at this point in the history

  2. crypto: simplify DH groups

    @tniessen
    tniessen committed Jan 20, 2020
    Copy the full SHA
    5883185 View commit details
    Browse the repository at this point in the history

  3. crypto: add DH support to generateKeyPair 

    This allows using the generateKeyPair API for DH instead of the old
stateful DH APIs.
    @tniessen
    tniessen committed Jan 20, 2020
    Copy the full SHA
    6eedfc8 View commit details
    Browse the repository at this point in the history

  4. crypto: add crypto.diffieHellman 

    Currently, Node.js has separate (stateful) APIs for DH/ECDH, and no
support for ECDH-ES. This commit adds a single stateless function to
compute the DH/ECDH/ECDH-ES secret based on two KeyObjects.
    @tniessen
    tniessen committed Jan 20, 2020
    Copy the full SHA
    d7a6917 View commit details
    Browse the repository at this point in the history

  5. test: skip keygen tests on arm systems 

    test-crypto-keygen and test-crypto-dh-stateless are currently flaky
on ARM CI systems due to their slow CPUs.
    @tniessen
    tniessen committed Jan 20, 2020
    Copy the full SHA
    14a21e8 View commit details
    Browse the repository at this point in the history