Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v13.x backport] stream: invoke buffered write callbacks on error #31179

Closed
wants to merge 2 commits into from
Closed

[v13.x backport] stream: invoke buffered write callbacks on error #31179

wants to merge 2 commits into from

Commits on Jan 3, 2020

  1. stream: invoke buffered write callbacks on error 

    Buffered write callbacks were only invoked upon
error if `autoDestroy` was invoked.

Backport-PR-URL: nodejs#31179
PR-URL: nodejs#30596
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @ronag
    ronag committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    03b85ec View commit details
    Browse the repository at this point in the history

  2. fixup: unrelated tests

    @ronag
    ronag committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    9696963 View commit details
    Browse the repository at this point in the history