Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v12 backport] lib: no need to strip BOM or shebang for scripts #31228

Closed
wants to merge 2 commits into from
Closed

[v12 backport] lib: no need to strip BOM or shebang for scripts #31228

wants to merge 2 commits into from

Commits on Jan 6, 2020

  1. lib: rework logic of stripping BOM+Shebang from commonjs 

    Fixes nodejs#27767

PR-URL: nodejs#27768
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @devsnek @aduh95
    devsnek authored and aduh95 committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    eb38365 View commit details
    Browse the repository at this point in the history

  2. lib: no need to strip BOM or shebang for scripts 

    PR-URL: nodejs#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @refack @aduh95
    refack authored and aduh95 committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    7100e23 View commit details
    Browse the repository at this point in the history