v13.6.0 proposal

.github/ISSUE_TEMPLATE/config.yml

@@ -3,6 +3,6 @@ contact_links:
   - name: ⁉️ Need help with Node.js?
     url: https://github.com/nodejs/help
     about: Please file an issue in our help repo.
-  - name: 🌐 Found a problem with nodejs.org?
+  - name: 🌐 Found a problem with nodejs.org beyond the API reference docs?
     url: https://github.com/nodejs/nodejs.org/issues/new/choose
     about: Please file an issue in the Node.js website repo.

.travis.yml

@@ -85,3 +85,4 @@ jobs:
         - flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
   allow_failures:  # TODO (cclauss): remove this when dependencies are clean
     - name: "Find syntax errors in our Python dependencies"
+    - name: "First commit message adheres to guidelines at <a href=\"https://goo.gl/p2fr5Q\">https://goo.gl/p2fr5Q</a>"

BUILDING.md

@@ -23,15 +23,15 @@ file a new issue.
   * [Unix and macOS](#unix-and-macos)
     * [Unix prerequisites](#unix-prerequisites)
     * [macOS prerequisites](#macos-prerequisites)
-    * [Building Node.js](#building-nodejs)
+    * [Building Node.js](#building-nodejs-1)
     * [Running Tests](#running-tests)
     * [Running Coverage](#running-coverage)
     * [Building the documentation](#building-the-documentation)
     * [Building a debug build](#building-a-debug-build)
   * [Windows](#windows)
     * [Prerequisites](#prerequisites)
       * [Option 1: Manual install](#option-1-manual-install)
-      * [Option 1: Automated install with Boxstarter](#option-1-automated-install-with-boxstarter)
+      * [Option 2: Automated install with Boxstarter](#option-2-automated-install-with-boxstarter)
     * [Building Node.js](#building-nodejs-1)
   * [Android/Android-based devices (e.g. Firefox OS)](#androidandroid-based-devices-eg-firefox-os)
 * [`Intl` (ECMA-402) support](#intl-ecma-402-support)
@@ -80,7 +80,7 @@ There are three support tiers:
   platforms are welcome.
 
 Platforms may move between tiers between major release lines. The table below
-will be updated to reflect those changes.
+will reflect those changes.
 
 ### Platform list
 
@@ -113,26 +113,26 @@ platforms. This is true regardless of entries in the table below.
 | AIX              | ppc64be >=power7 | >= 7.2 TL02                     | Tier 2       |                                   |
 | FreeBSD          | x64              | >= 11                           | Experimental | Downgraded as of Node.js 12  <sup>[7](#fn7)</sup>     |
 
-<em id="fn1">1</em>: GCC 6 is not provided on the base platform, users will
+<em id="fn1">1</em>: GCC 6 is not provided on the base platform. Users will
   need the
   [Toolchain test builds PPA](https://launchpad.net/~ubuntu-toolchain-r/+archive/ubuntu/test?field.series_filter=xenial)
   or similar to source a newer compiler.
 
-<em id="fn2">2</em>: GCC 6 is not provided on the base platform, users will
+<em id="fn2">2</em>: GCC 6 is not provided on the base platform. Users will
   need the
   [devtoolset-6](https://www.softwarecollections.org/en/scls/rhscl/devtoolset-6/)
   or later to source a newer compiler.
 
-<em id="fn3">3</em>: Older kernel versions may work for ARM64, however the
+<em id="fn3">3</em>: Older kernel versions may work for ARM64. However the
   Node.js test infrastructure only tests >= 4.5.
 
 <em id="fn4">4</em>: On Windows, running Node.js in Windows terminal emulators
   like `mintty` requires the usage of [winpty](https://github.com/rprichard/winpty)
-  for the tty channels to work correctly (e.g. `winpty node.exe script.js`).
+  for the tty channels to work (e.g. `winpty node.exe script.js`).
   In "Git bash" if you call the node shell alias (`node` without the `.exe`
   extension), `winpty` is used automatically.
 
-<em id="fn5">5</em>: The Windows Subsystem for Linux (WSL) is not directly
+<em id="fn5">5</em>: The Windows Subsystem for Linux (WSL) is not
   supported, but the GNU/Linux build process and binaries should work. The
   community will only address issues that reproduce on native GNU/Linux
   systems. Issues that only reproduce on WSL should be reported in the
@@ -142,11 +142,11 @@ platforms. This is true regardless of entries in the table below.
 
 <em id="fn6">6</em>: Running Node.js on x86 Windows should work and binaries
 are provided. However, tests in our infrastructure only run on WoW64.
-Furthermore, compiling on x86 Windows is currently considered Experimental and
+Furthermore, compiling on x86 Windows is Experimental and
 may not be possible.
 
 <em id="fn7">7</em>: The default FreeBSD 12.0 compiler is Clang 6.0.1, but
-FreeBSD 12.1 upgrades to 8.0.1. Other Clang/LLVM versions are provided
+FreeBSD 12.1 upgrades to 8.0.1. Other Clang/LLVM versions are available
 via the system's package manager, including Clang 9.0.
 
 ### Supported toolchains

CHANGELOG.md

@@ -30,7 +30,8 @@ release.
 </tr>
 <tr>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V13.md#13.5.0">13.5.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V13.md#13.6.0">13.6.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V13.md#13.5.0">13.5.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V13.md#13.4.0">13.4.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V13.md#13.3.0">13.3.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V13.md#13.2.0">13.2.0</a><br/>

CPP_STYLE_GUIDE.md

@@ -14,9 +14,9 @@ codebase not related to stylistic issues.
   * [Align function arguments vertically](#align-function-arguments-vertically)
   * [Initialization lists](#initialization-lists)
   * [CamelCase for methods, functions, and classes](#camelcase-for-methods-functions-and-classes)
-  * [snake\_case for local variables and parameters](#snake_case-for-local-variables-and-parameters)
-  * [snake\_case\_ for private class fields](#snake_case_-for-private-class-fields)
-  * [snake\_case for C-like structs](#snake_case-for-c-like-structs)
+  * [`snake_case` for local variables and parameters](#snake_case-for-local-variables-and-parameters)
+  * [`snake_case_` for private class fields](#snake_case_-for-private-class-fields)
+  * [`snake_case` for C-like structs](#snake_case-for-c-like-structs)
   * [Space after `template`](#space-after-template)
 * [Memory Management](#memory-management)
   * [Memory allocation](#memory-allocation)
@@ -155,15 +155,15 @@ class FooBar {
 };
 ```
 
-### snake\_case for local variables and parameters
+### `snake_case` for local variables and parameters
 
 ```c++
 int FunctionThatDoesSomething(const char* important_string) {
   const char* pointer_into_string = important_string;
 }
 ```
 
-### snake\_case\_ for private class fields
+### `snake_case_` for private class fields
 
 ```c++
 class Foo {
@@ -172,7 +172,8 @@ class Foo {
 };
 ```
 
-### snake\_case for C-like structs
+### `snake_case` for C-like structs
+
 For plain C-like structs snake_case can be used.
 
 ```c++

benchmark/README.md

@@ -74,21 +74,21 @@ The common.js module is used by benchmarks for consistency across repeated
 tasks. It has a number of helpful functions and properties to help with
 writing benchmarks.
 
-### createBenchmark(fn, configs\[, options\])
+### `createBenchmark(fn, configs[, options])`
 
 See [the guide on writing benchmarks](writing-and-running-benchmarks.md#basics-of-a-benchmark).
 
-### default\_http\_benchmarker
+### `default_http_benchmarker`
 
 The default benchmarker used to run HTTP benchmarks.
 See [the guide on writing HTTP benchmarks](writing-and-running-benchmarks.md#creating-an-http-benchmark).
 
-### PORT
+### `PORT`
 
 The default port used to run HTTP benchmarks.
 See [the guide on writing HTTP benchmarks](writing-and-running-benchmarks.md#creating-an-http-benchmark).
 
-### sendResult(data)
+### `sendResult(data)`
 
 Used in special benchmarks that can't use `createBenchmark` and the object
 it returns to accomplish what they need. This function reports timing

benchmark/async_hooks/http-server.js

@@ -0,0 +1,40 @@
+'use strict';
+const common = require('../common.js');
+
+const bench = common.createBenchmark(main, {
+  asyncHooks: ['init', 'before', 'after', 'all', 'disabled', 'none'],
+  connections: [50, 500]
+});
+
+function main({ asyncHooks, connections }) {
+  if (asyncHooks !== 'none') {
+    let hooks = {
+      init() {},
+      before() {},
+      after() {},
+      destroy() {},
+      promiseResolve() {}
+    };
+    if (asyncHooks !== 'all' || asyncHooks !== 'disabled') {
+      hooks = {
+        [asyncHooks]: () => {}
+      };
+    }
+    const hook = require('async_hooks').createHook(hooks);
+    if (asyncHooks !== 'disabled') {
+      hook.enable();
+    }
+  }
+  const server = require('../fixtures/simple-http-server.js')
+  .listen(common.PORT)
+  .on('listening', () => {
+    const path = '/buffer/4/4/normal/1';
+
+    bench.http({
+      connections,
+      path,
+    }, () => {
+      server.close();
+    });
+  });
+}

benchmark/child_process/child-process-exec-stdout.js

@@ -19,7 +19,7 @@ function childProcessExecStdout({ dur, len }) {
   const cmd = `yes "${'.'.repeat(len)}"`;
   const child = exec(cmd, { 'stdio': ['ignore', 'pipe', 'ignore'] });
 
-  var bytes = 0;
+  let bytes = 0;
   child.stdout.on('data', (msg) => {
     bytes += msg.length;
   });

benchmark/child_process/child-process-read-ipc.js

@@ -26,7 +26,7 @@ if (process.argv[2] === 'child') {
     const child = spawn(process.argv[0],
                         [process.argv[1], 'child', len], options);
 
-    var bytes = 0;
+    let bytes = 0;
     child.on('message', (msg) => { bytes += msg.length; });
 
     setTimeout(() => {

benchmark/child_process/child-process-read.js

@@ -24,7 +24,7 @@ function main({ dur, len }) {
   const options = { 'stdio': ['ignore', 'pipe', 'ignore'] };
   const child = child_process.spawn('yes', [msg], options);
 
-  var bytes = 0;
+  let bytes = 0;
   child.stdout.on('data', (msg) => {
     bytes += msg.length;
   });

benchmark/cluster/echo.js

@@ -19,10 +19,10 @@ if (cluster.isMaster) {
     serialization
   }) {
     const expectedPerBroadcast = sendsPerBroadcast * workers;
-    var readies = 0;
-    var broadcasts = 0;
-    var msgCount = 0;
-    var data;
+    let readies = 0;
+    let broadcasts = 0;
+    let msgCount = 0;
+    let data;
 
     cluster.settings.serialization = serialization;
 
@@ -37,7 +37,7 @@ if (cluster.isMaster) {
         throw new Error('Unsupported payload type');
     }
 
-    for (var i = 0; i < workers; ++i)
+    for (let i = 0; i < workers; ++i)
       cluster.fork().on('online', onOnline).on('message', onMessage);
 
     function onOnline() {
@@ -48,16 +48,15 @@ if (cluster.isMaster) {
     }
 
     function broadcast() {
-      var id;
       if (broadcasts++ === n) {
         bench.end(n);
-        for (id in cluster.workers)
+        for (const id in cluster.workers)
           cluster.workers[id].disconnect();
         return;
       }
-      for (id in cluster.workers) {
+      for (const id in cluster.workers) {
         const worker = cluster.workers[id];
-        for (var i = 0; i < sendsPerBroadcast; ++i)
+        for (let i = 0; i < sendsPerBroadcast; ++i)
           worker.send(data);
       }
     }

benchmark/crypto/aes-gcm-throughput.js

@@ -25,7 +25,7 @@ function AEAD_Bench(cipher, message, associate_data, key, iv, n, len) {
   const bits = written * 8;
   const mbits = bits / (1024 * 1024);
 
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     const alice = crypto.createCipheriv(cipher, key, iv);
     alice.setAAD(associate_data);
     const enc = alice.update(message);

benchmark/crypto/cipher-stream.js

@@ -38,8 +38,8 @@ function main({ api, cipher, type, len, writes }) {
   const alice_cipher = crypto.createCipher(cipher, alice_secret);
   const bob_cipher = crypto.createDecipher(cipher, bob_secret);
 
-  var message;
-  var encoding;
+  let message;
+  let encoding;
   switch (type) {
     case 'asc':
       message = 'a'.repeat(len);
@@ -65,7 +65,7 @@ function main({ api, cipher, type, len, writes }) {
 }
 
 function streamWrite(alice, bob, message, encoding, writes) {
-  var written = 0;
+  let written = 0;
   bob.on('data', (c) => {
     written += c.length;
   });
@@ -86,9 +86,9 @@ function streamWrite(alice, bob, message, encoding, writes) {
 }
 
 function legacyWrite(alice, bob, message, encoding, writes) {
-  var written = 0;
-  var enc, dec;
-  for (var i = 0; i < writes; i++) {
+  let written = 0;
+  let enc, dec;
+  for (let i = 0; i < writes; i++) {
     enc = alice.update(message, encoding);
     dec = bob.update(enc);
     written += dec.length;

benchmark/crypto/get-ciphers.js

@@ -9,7 +9,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, v }) {
   const method = require(v).getCiphers;
-  var i = 0;
+  let i = 0;
   // First call to getCiphers will dominate the results
   if (n > 1) {
     for (; i < n; i++)

benchmark/crypto/hash-stream-creation.js

@@ -20,8 +20,8 @@ function main({ api, type, len, out, writes, algo }) {
     api = 'legacy';
   }
 
-  var message;
-  var encoding;
+  let message;
+  let encoding;
   switch (type) {
     case 'asc':
       message = 'a'.repeat(len);
@@ -52,7 +52,7 @@ function legacyWrite(algo, message, encoding, writes, len, outEnc) {
   while (writes-- > 0) {
     const h = crypto.createHash(algo);
     h.update(message, encoding);
-    var res = h.digest(outEnc);
+    let res = h.digest(outEnc);
 
     // Include buffer creation costs for older versions
     if (outEnc === 'buffer' && typeof res === 'string')

benchmark/crypto/hash-stream-throughput.js

@@ -19,8 +19,8 @@ function main({ api, type, len, algo, writes }) {
     api = 'legacy';
   }
 
-  var message;
-  var encoding;
+  let message;
+  let encoding;
   switch (type) {
     case 'asc':
       message = 'a'.repeat(len);

benchmark/crypto/rsa-encrypt-decrypt-throughput.js

@@ -35,7 +35,7 @@ function StreamWrite(algo, keylen, message, n, len) {
 
   const privateKey = RSA_PrivatePem[keylen];
   const publicKey = RSA_PublicPem[keylen];
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     const enc = crypto.privateEncrypt(privateKey, message);
     crypto.publicDecrypt(publicKey, enc);
   }

benchmark/dgram/array-vs-concat.js

@@ -18,12 +18,12 @@ const bench = common.createBenchmark(main, {
 
 function main({ dur, len, num, type, chunks }) {
   const chunk = [];
-  for (var i = 0; i < chunks; i++) {
+  for (let i = 0; i < chunks; i++) {
     chunk.push(Buffer.allocUnsafe(Math.round(len / chunks)));
   }
 
   // Server
-  var sent = 0;
+  let sent = 0;
   const socket = dgram.createSocket('udp4');
   const onsend = type === 'concat' ? onsendConcat : onsendMulti;
 
@@ -32,7 +32,7 @@ function main({ dur, len, num, type, chunks }) {
       // The setImmediate() is necessary to have event loop progress on OSes
       // that only perform synchronous I/O on nonblocking UDP sockets.
       setImmediate(() => {
-        for (var i = 0; i < num; i++) {
+        for (let i = 0; i < num; i++) {
           socket.send(Buffer.concat(chunk), PORT, '127.0.0.1', onsend);
         }
       });
@@ -44,7 +44,7 @@ function main({ dur, len, num, type, chunks }) {
       // The setImmediate() is necessary to have event loop progress on OSes
       // that only perform synchronous I/O on nonblocking UDP sockets.
       setImmediate(() => {
-        for (var i = 0; i < num; i++) {
+        for (let i = 0; i < num; i++) {
           socket.send(chunk, PORT, '127.0.0.1', onsend);
         }
       });