Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v12 backport] Modules bootstrap refactoring #31242

Closed
wants to merge 0 commits into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 7, 2020

Backport of #29937.

Blocked by #31241.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. v12.x labels Jan 7, 2020
@MylesBorins
Copy link
Member

@aduh95 thanks for opening this PR!

I'm in the process of planning a backport PR to get all of the modules work up to date. Part of this will include updating V8 to 7.8 (it is still on 7.7)

The PR is #30109

@MylesBorins
Copy link
Member

Realizing I left my post only half done.

I may build on top of your PR to make the new PR if you are ok with that, were there a lot of conflicts that you dealt with?

@aduh95
Copy link
Contributor Author

aduh95 commented Jan 7, 2020

@MylesBorins I'm definitely OK with that :)

were there a lot of conflicts that you dealt with?

It depends what you call a lot, I suppose, there were a few for sure.

@targos
Copy link
Member

targos commented Jan 8, 2020

this commit also landed cleanly after the previous ones

@targos targos closed this Jan 8, 2020
@aduh95 aduh95 deleted the backport-29937-to-erbium branch January 8, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants