Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v10.18.1 proposal #31248

Merged
merged 16 commits into from Jan 9, 2020
Merged

v10.18.1 proposal #31248

merged 16 commits into from Jan 9, 2020

Commits on Dec 17, 2019

  1. build: fix configure script to work with Apple Clang 11

    PR-URL: #28071
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
    saagarjha authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    a80c591 View commit details
    Browse the repository at this point in the history
  2. tools: fix v8 testing with devtoolset on ppcle

    The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them
    if not present.
    
    PR-URL: #28458
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    sam-github authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    4879b80 View commit details
    Browse the repository at this point in the history
  3. tools: move python code out of jenkins shell

    https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes
    python code into tools and runs it. Move these scripts into tools for
    better maintainability.
    
    Once this lands and is back-ported into LTS branches a bunch of shell
    code can be deleted from the job.
    
    PR-URL: #28458
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    sam-github authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    4ae8d20 View commit details
    Browse the repository at this point in the history
  4. lib: fix comment nits in bootstrap\loaders.js

    Backport-PR-URL: #30338
    PR-URL: #24641
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    vsemozhetbyt authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    81c3100 View commit details
    Browse the repository at this point in the history
  5. tools: update tzdata to 2019c

    Refs: #30211
    Refs: #30356
    
    PR-URL: #30479
    Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    MylesBorins committed Dec 17, 2019
    Copy the full SHA
    0f3ae77 View commit details
    Browse the repository at this point in the history
  6. deps: V8: backport fb63e5cf55e9

    Original commit message:
    
        [Intl] Fix output of hour:'2-digit', hour12: true
    
        Bug: chromium:527926
        Change-Id: I783ba59c6e4b117163e058032fb04283e1f43c46
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529260
        Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
        Commit-Queue: Frank Tang <ftang@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#60379}
    
    Refs: v8/v8@fb63e5c
    
    Fixes: #30369
    
    Backport-PR-URL: #30372
    targos authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    3e0709c View commit details
    Browse the repository at this point in the history
  7. n-api: correct bug in napi_get_last_error

    napi_get_last_error returns incorrect napi_status.
    
    Backport-PR-URL: #30532
    PR-URL: #28702
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Octavian Soldea authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    88e8b7c View commit details
    Browse the repository at this point in the history
  8. build,win: propagate error codes in vcbuild

    Don't exit vcbuild with error code 0 when cctest fails.
    
    Backport-PR-URL: #30726
    PR-URL: #30724
    Refs: nodejs/build#1996
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    joaocgreis authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    68b2b5c View commit details
    Browse the repository at this point in the history
  9. test: do not fail SLOW tests if they are not slow

    PR-URL: #25868
    Refs: #25867
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gus Caplan <me@gus.host>
    hashseed authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    7e941eb View commit details
    Browse the repository at this point in the history
  10. http2: use the latest settings

    Fixes: #29764
    
    PR-URL: #29780
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    ZYSzys authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    20f64a9 View commit details
    Browse the repository at this point in the history
  11. stream: extract Readable.from in its own file

    See: nodejs/readable-stream#420
    
    PR-URL: #30140
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    mcollina authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    894aaa2 View commit details
    Browse the repository at this point in the history
  12. http2: fix session memory accounting after pausing

    The ability to pause input processing was added in 8a4a193 but
    introduced a session memory accounting mismatch leading to potential
    NGHTTP2_ENHANCE_YOUR_CALM errors.
    
    After pausing
    (https://github.com/nodejs/node/blob/f36331c1bfa4c4c202346b05dc3bd672f653e4df/src/node_http2.cc#L871),
    the early return on line 873 skips the
    DecrementCurrentSessionMemory(stream_buf_.len) call below (line 878).
    
    When we later finished processing the input chunk
    (https://github.com/nodejs/node/blob/f36331c1bfa4c4c202346b05dc3bd672f653e4df/src/node_http2.cc#L1858),
    we were calling DecrementCurrentSessionMemory(stream_buf_offset_) [line
    1875] which was a no-op since we just set stream_buf_offset_ to 0 [line
    1873].
    
    The correct amount to decrement by is still stream_buf_.len, since
    that's the amount we skipped previously (line 878).
    
    Fixes: #29223
    Refs: 164ac5b
    
    PR-URL: #30684
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Michael Lehenbauer authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    8f3b8ca View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2019

  1. doc: allow <code> in header elements

    Allow use of <code> in header elements without styling side effects. We
    can add styling later if desired. The goal here is to allow code to be
    set off in markdown without needing to escape characters and do lint
    exceptions for terms. This is probably a win in terms of accessibility
    too although it would be moreso if we had some visual differentiation
    for <code> inside of headers. As mentioned above, that can always be
    added at a later time.
    
    Backport-PR-URL: #31109
    PR-URL: #31086
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Trott authored and BethGriggs committed Dec 31, 2019
    Copy the full SHA
    25b8fbd View commit details
    Browse the repository at this point in the history
  2. doc,dns: use code markup/markdown in headers

    This will allow us to lint for use of `hostname` in prose without
    flagging `hostname` in code within headers. This also allows us to
    remove backslash escaping for `[` and `]` inside of header code, which
    makes the bare markdown more readable.
    
    Backport-PR-URL: #31109
    PR-URL: #31086
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Trott authored and BethGriggs committed Dec 31, 2019
    Copy the full SHA
    a1b095d View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2020

  1. stream: increase MAX_HWM

    MAX_HWM was added in 9208c89 where the highwatermark was changed to
    always increase in steps of highest power of 2 to prevent increasing
    hwm excessivly in tiny amounts.
    
    Why a limit was added on the highwatermark is unclear but breaks
    existing usage where a larger read size is used. The invariant for
    read(n) is that a buffer of size n is always returned. Considering
    a maximum ceiling on the buffer size breaks this invariant.
    
    This PR significantly increases the limit to make it less likely to
    break the previous invariant and also documents the limit.
    
    Fixes: #29933
    
    PR-URL: #29938
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    ronag authored and BethGriggs committed Jan 7, 2020
    Copy the full SHA
    77e0318 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2020

  1. 2020-01-09, Version 10.18.1 'Dubnium' (LTS)

    - http2: fix session memory accounting after pausing (Michael Lehenbauer)
      [#30684](#30684)
    - n-api: correct bug in napi_get_last_error (Octavian Soldea)
      [#28702](#28702)
    - tools: update tzdata to 2019c (Myles Borins)
      [#30479](#30479)
    
    PR-URL: #31248
    BethGriggs committed Jan 9, 2020
    Copy the full SHA
    8d5e286 View commit details
    Browse the repository at this point in the history