Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: allow monitoring uncaughtException #31257

Closed
wants to merge 10 commits into from
Closed

process: allow monitoring uncaughtException #31257

wants to merge 10 commits into from

Commits on Jan 8, 2020

  1. process: allow monitoring uncaughtException 

    Installing an uncaughtException listener has a side effect that process
is not aborted. This is quite bad for monitoring/logging tools which
tend to be interested in errors but don't want to cause side effects
like swallow an exception or change the output on console.

There are some workarounds in the wild like monkey patching emit or
rethrow in the exception if monitoring tool detects that it is the only
listener but this is error prone and risky.

This PR allows to install a listener to monitor uncaughtException
without the side effect to consider the exception has handled. To avoid
conflicts with other events it exports a symbol on process which owns
this special meaning.
    @Flarna
    Flarna committed Jan 8, 2020
    Copy the full SHA
    9039128 View commit details
    Browse the repository at this point in the history

  2. fixup! crlf => lf

    @Flarna
    Flarna committed Jan 8, 2020
    Copy the full SHA
    df03daa View commit details
    Browse the repository at this point in the history

  3. use arrow functions

    @Flarna
    Flarna committed Jan 8, 2020
    Copy the full SHA
    b58dd7c View commit details
    Browse the repository at this point in the history

  4. add test to verify default exit behavior is unchanged

    @Flarna
    Flarna committed Jan 8, 2020
    Copy the full SHA
    6f53695 View commit details
    Browse the repository at this point in the history

  5. fixup! improve fixture

    @Flarna
    Flarna committed Jan 8, 2020
    Copy the full SHA
    acee3de View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2020

  1. replace symbol uncaughtExceptionMonitor by a string

    @Flarna
    Flarna committed Jan 10, 2020
    Copy the full SHA
    5daab4d View commit details
    Browse the repository at this point in the history

  2. add test to verify that throwing in monitoring listener results in 

    exit code 7
    @Flarna
    Flarna committed Jan 10, 2020
    Copy the full SHA
    c3b5f2d View commit details
    Browse the repository at this point in the history

  3. Update doc/api/process.md 

    Co-Authored-By: Colin Ihrig <cjihrig@gmail.com>
    @Flarna @cjihrig
    Flarna and cjihrig committed Jan 10, 2020
    Copy the full SHA
    9db2da6 View commit details
    Browse the repository at this point in the history

  4. Update doc/api/process.md 

    Co-Authored-By: Colin Ihrig <cjihrig@gmail.com>
    @Flarna @cjihrig
    Flarna and cjihrig committed Jan 10, 2020
    Copy the full SHA
    4206027 View commit details
    Browse the repository at this point in the history

  5. Update doc/api/process.md 

    Co-Authored-By: Colin Ihrig <cjihrig@gmail.com>
    @Flarna @cjihrig
    Flarna and cjihrig committed Jan 10, 2020
    Copy the full SHA
    efedbb5 View commit details
    Browse the repository at this point in the history