repl: prevent previews during pasting #31315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
readline
BridgeAR
force-pushed
the
2020-01-11-repl-prevent-previews-during-pasting
branch
from
7dabd1e
to
fe738a3
Compare
BridgeAR
force-pushed
the
2020-01-11-repl-prevent-previews-during-pasting
branch
from
fe738a3
to
eea1c73
Compare
jasnell
approved these changes
Jan 12, 2020
BridgeAR
added
the
author ready
This makes sure no previews are triggered while pasting code. The very last character is allowed to trigger the preview. The output should be completely identical to the user.
BridgeAR
force-pushed
the
2020-01-11-repl-prevent-previews-during-pasting
branch
from
eea1c73
to
5f1cee3
Compare
|
Rebased due to conflicts. |
|
@nodejs/repl @nodejs/readline PTAL |
Trott
approved these changes
Jan 13, 2020
JungMinu
approved these changes
Jan 13, 2020
BridgeAR
added a commit
that referenced
this pull request
Jan 13, 2020
This makes sure no previews are triggered while pasting code. The very last character is allowed to trigger the preview. The output should be completely identical to the user. PR-URL: #31315 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
|
Landed in c3b702f 🎉 |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2020
This makes sure no previews are triggered while pasting code. The very last character is allowed to trigger the preview. The output should be completely identical to the user. PR-URL: #31315 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Merged
|
@BridgeAR sorry for the many pings - this is in the group needing manual backport to 12 if it should indeed go there. |
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
This makes sure no previews are triggered while pasting code. The very last character is allowed to trigger the preview. The output should be completely identical to the user. PR-URL: nodejs#31315 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
This makes sure no previews are triggered while pasting code. The very last character is allowed to trigger the preview. The output should be completely identical to the user. PR-URL: #31315 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #31288 and therefore the two first commits should be ignored. I'll rebase as soon as the other PR lands.Update: done.
This makes sure no previews are triggered while pasting code. The
very last character is allowed to trigger the preview. The output
should be completely identical to the user.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes