Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v12.x] deps: V8: cherry-pick d89f4ef1cd62 #31344

Closed
wants to merge 1 commit into from
Closed

[v12.x] deps: V8: cherry-pick d89f4ef1cd62 #31344

wants to merge 1 commit into from

Conversation

miladfarca
Copy link
Contributor

@miladfarca miladfarca commented Jan 13, 2020 •
edited

Original commit message:

S390x: improve performance by skipping Debug Hook if not needed

Change-Id: Ib4b2821f2941cdc131f9c75b89a3baced7554f8d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991802
Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#65644}

Refs: v8/v8@d89f4ef

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

deps: V8: cherry-pick d89f4ef1cd62
69c230b 
Original commit message:

    S390x: improve performance by skipping Debug Hook if not needed

    Change-Id: Ib4b2821f2941cdc131f9c75b89a3baced7554f8d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991802
    Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
    Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
    Cr-Commit-Position: refs/heads/master@{#65644}

Refs: v8/v8@d89f4ef
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v12.x v8 engine Issues and PRs related to the V8 dependency. labels Jan 13, 2020
@miladfarca
Copy link
Contributor Author

/cc @nodejs/platform-s390

mhdawson
mhdawson approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau changed the title deps: V8: cherry-pick d89f4ef1cd62 [12.x] deps: V8: cherry-pick d89f4ef1cd62 Jan 13, 2020
@richardlau richardlau changed the title [12.x] deps: V8: cherry-pick d89f4ef1cd62 [v12.x] deps: V8: cherry-pick d89f4ef1cd62 Jan 13, 2020
@targos
Copy link
Member

targos commented Jan 14, 2020

Is this not needed on master/v13.x ?

@miladfarca
Copy link
Contributor Author

@targos I'm trying to back-port it to Node 12, if you think it needs to be on other branches I can make separate PRs.

@targos
Copy link
Member

targos commented Jan 14, 2020

@miladfarca We usually do it the other way: PR to master, then cherry-pick (or open a backport PR if needed) to release branches.

@miladfarca
Copy link
Contributor Author

@targos here is a PR to master: #31354
Let me know if it needs to be ported to other branches as well.

@targos targos mentioned this pull request Jan 14, 2020
Closed
2 tasks
@targos
Copy link
Member

targos commented Jan 15, 2020

cherry-picked #31354 on v12.x-staging.

@targos targos closed this Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-github sam-github sam-github approved these changes

@richardlau richardlau richardlau approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@miladfarca @targos @sam-github @richardlau @BethGriggs @mhdawson @nodejs-github-bot