Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v13.7.0 proposal #31382

Merged
merged 110 commits into from Jan 21, 2020
Merged

v13.7.0 proposal #31382

merged 110 commits into from Jan 21, 2020

Commits on Jan 11, 2020

  1. deps: deactivate failing tests corresponding to experimental features

    This comments out three tests that consistently fail on v13.x.
    The test can be activated again in case the necessary code change
    lands on v13.x for the tests to pass.
    
    PR-URL: #31289
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    BridgeAR authored and Trott committed Jan 11, 2020
    Copy the full SHA
    6f95f01 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2020

  1. module: loader getSource, getFormat, transform hooks

    PR-URL: #30986
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    GeoffreyBooth authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    94af94a View commit details
    Browse the repository at this point in the history
  2. module: logical conditional exports ordering

    PR-URL: #31008
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    guybedford authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    f62fb76 View commit details
    Browse the repository at this point in the history
  3. stream: sync stream unpipe resume

    pipe() ondata should not control flow state if cleaned up.
    
    Fixes: #31190
    
    PR-URL: #31191
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    ronag authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    256289f View commit details
    Browse the repository at this point in the history
  4. src: clean up large_pages code

    PR-URL: #31196
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    lundibundi authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    1ad9070 View commit details
    Browse the repository at this point in the history
  5. lib: replace BigUInt64Array global by the primordials

    PR-URL: #31194
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Sebastien-Ahkrin authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    aafeab8 View commit details
    Browse the repository at this point in the history
  6. lib: replace Float32Array global by the primordials

    PR-URL: #31195
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Sebastien-Ahkrin authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    f7833ac View commit details
    Browse the repository at this point in the history
  7. wasi: improve use of primordials

    PR-URL: #31212
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    cjihrig authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    bdaac04 View commit details
    Browse the repository at this point in the history
  8. lib: add RegExp primordials

    PR-URL: #31208
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Sebastien-Ahkrin authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    53e73fc View commit details
    Browse the repository at this point in the history
  9. lib,tools,test: remove custom number-isnan rule

    This commit removes the custom number-isnan ESLint rule in
    favor of the no-restricted-syntax rule. It also applies the
    rule across the entire codebase, instead of just the test/
    directory.
    
    PR-URL: #31211
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    cjihrig authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    ac904f9 View commit details
    Browse the repository at this point in the history
  10. doc: explain native external types

    There is a reference to native external types in
    util.types.isExternal api documentation. Provide
    a brief explanation to that.
    Refs: #31173 (comment)
    
    PR-URL: #31214
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    HarshithaKP authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    c1333ea View commit details
    Browse the repository at this point in the history
  11. doc,src: clarify that one napi_env is per-module

    PR-URL: #31102
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    legendecas authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    82b447c View commit details
    Browse the repository at this point in the history
  12. build: avoid using CMP for BZ2File

    Some Python distributions do not support
    context manager protocol (CMP) for BZ2File.
    
    PR-URL: #31198
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Christian Clauss <cclauss@me.com>
    SpaceRacet5w2A6l0I authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    9643718 View commit details
    Browse the repository at this point in the history
  13. stream: replace Function.prototype with primordial

    PR-URL: #31204
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Sebastien-Ahkrin authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    9c98d25 View commit details
    Browse the repository at this point in the history
  14. benchmark: benchmarking impacts of async hooks on promises

    PR-URL: #31188
    Refs: nodejs/diagnostics#124
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    legendecas authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    317d2db View commit details
    Browse the repository at this point in the history
  15. win: change to use Python in install tool

    PR-URL: #31221
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    gengjiawen authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    66fe923 View commit details
    Browse the repository at this point in the history
  16. test: fix unit test logging with python3

    A logfile must be opened as a text file and encoding is specified.
    Then it can accept a string. Current behaviour we get,
    
     Message: 'ok 2834 sequential/test-worker-prof'
     Arguments: ()
     --- Logging error ---
     Traceback (most recent call last):
       File "/usr/lib64/python3.7/logging/__init__.py", line 1037, in emit
         stream.write(msg + self.terminator)
     TypeError: a bytes-like object is required, not 'str'
     Call stack:
       File "tools/test.py", line 1734, in <module>
         sys.exit(Main())
       File "tools/test.py", line 1710, in Main
         if RunTestCases(cases_to_run, options.progress, options.j, options.flaky_tests):
       File "tools/test.py", line 933, in RunTestCases
         return progress.Run(tasks)
       File "tools/test.py", line 141, in Run
         self.RunSingle(False, 0)
       File "tools/test.py", line 202, in RunSingle
         self.HasRun(output)
       File "tools/test.py", line 365, in HasRun
         logger.info('  ---')
    
    PR-URL: #31156
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    AdamMajer authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    f93095d View commit details
    Browse the repository at this point in the history
  17. doc: prefer server vs srv and client vs clt

    PR-URL: #31224
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    andrewhughes101 authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    220ea0c View commit details
    Browse the repository at this point in the history
  18. test: prefer server over srv

    PR-URL: #31224
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    andrewhughes101 authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    d76deca View commit details
    Browse the repository at this point in the history
  19. stream: clean up definition using defineProperties

    PR-URL: #31236
    Refs: #31187
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    antsmartian authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    ff60a0e View commit details
    Browse the repository at this point in the history
  20. src: remove uses of node::InitializeV8Platform()

    This requires minor changes to src/env.cc to deal with
    `node::tracing::AgentWriterHandle::GetTracingController()` now possibly
    returning a nullptr, because the cctest doesn't set one.
    
    It seems plausible to me that embedders won't set one either so that
    seems like an okay change to make. It avoids embedders having to track
    down nullptr segfaults.
    
    PR-URL: #31245
    Refs: #31217
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    bnoordhuis authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    6050236 View commit details
    Browse the repository at this point in the history
  21. src: remove node::InitializeV8Platform()

    This API method was introduced in commit 90ae4bd ("src: add
    InitializeV8Platform function") from July 2018 but wasn't properly
    exported and therefore not usable on Windows or with shared library
    builds.
    
    The motivation from the commit log is mainly about making it easier
    to wire up the cctests and there are better ways to do that.
    
    Refs: #31217
    
    PR-URL: #31245
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    bnoordhuis authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    4259afe View commit details
    Browse the repository at this point in the history
  22. test: remove unused symlink loop

    This symlink loop was originally intended to be accessed from
    a test. Instead, a loop is created by the test itself, but this
    was unfortunately forgotten about. It's unused, so remove it.
    
    PR-URL: #31267
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    cjihrig authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    69c4f22 View commit details
    Browse the repository at this point in the history
  23. test: check that --insecure-http-parser works

    Test that using --insecure-http-parser will disable validation of
    invalid characters in HTTP headers.
    
    See:
    - #30567
    
    PR-URL: #31253
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    sam-github authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    0b88c3d View commit details
    Browse the repository at this point in the history
  24. test: fix recursive rm test to actually use tmpdir

    Previously folders were created in the root of the project and would
    therefore stay there in case of errors. This changes the test to create
    all directories in the temp directory (`tmpdir.path`).
    
    PR-URL: #31250
    Reviewed-By: Bryan English <bryan@bryanenglish.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    lundibundi authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    ca51ff8 View commit details
    Browse the repository at this point in the history
  25. fs: use async writeFile in FileHandle#appendFile

    When operating on a FileHandle, the file has already been opened with
    the flag given as an option to fs.promises.open(). This means defaulting
    to 'a' has no effect here, and FileHandle#appendFile turns out to
    exactly be an alias of writeFile. This is now explicit, saving a stack
    frame, object copy and assignment.
    
    PR-URL: #31235
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    bengl authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    57016b9 View commit details
    Browse the repository at this point in the history
  26. doc: correct filehandle.[read|write|append]File()

    * Remove `mode` and `flag` options for all three functions, since they
    all ignore those options.
    * Remove mention of `path` argument for `readFile`, since it isn't
    actually an option to this method.
    * Clarify that for file handles, `appendFile` and `writeFile` are
    equivalent.
    
    PR-URL: #31235
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    bengl authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    3e7b3e3 View commit details
    Browse the repository at this point in the history
  27. src: add build Github Action

    PR-URL: #31153
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    gengjiawen authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    60942cc View commit details
    Browse the repository at this point in the history
  28. src: fix -Wbraced-scalar-init warning

    PR-URL: #31254
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    d0a96ab View commit details
    Browse the repository at this point in the history
  29. doc: fix stream async iterator sample

    The for await loop into writable loop could cause an unhandled exception
    in the case where we are waiting for data from the async iterable and
    this no `'error'` handler is registered on the writable.
    
    Fixes: #31222
    
    PR-URL: #31252
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    ronag authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    d51de78 View commit details
    Browse the repository at this point in the history
  30. doc: rename iterator to iterable in examples

    PR-URL: #31252
    Fixes: #31222
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    ronag authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    0e48d8d View commit details
    Browse the repository at this point in the history
  31. doc: update description of External

    The previous description did not mention what an `External`
    is and instead only provided some hints around what it is not.
    Update the description to be more accurate.
    
    PR-URL: #31255
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    de6f2be View commit details
    Browse the repository at this point in the history
  32. repl: improve preview length calculation

    The preview had an off by one error in case colors where deactivated
    and did not take fullwidth unicode characters into account when
    displaying the preview.
    
    PR-URL: #31112
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    BridgeAR authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    d84c394 View commit details
    Browse the repository at this point in the history
  33. readline,repl: add substring based history search

    This improves the current history search feature by adding substring
    based history search similar to ZSH. In case the `UP` or `DOWN`
    buttons are pressed after writing a few characters, the start string
    up to the current cursor is used to search the history.
    
    All other history features work exactly as they used to.
    
    PR-URL: #31112
    Fixes: #28437
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    BridgeAR authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    b6f4e01 View commit details
    Browse the repository at this point in the history
  34. readline,repl: skip history entries identical to the current line

    Skip history entries that are identical to the currently visible line
    to improve the user experience.
    
    PR-URL: #31112
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    BridgeAR authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    cecd256 View commit details
    Browse the repository at this point in the history
  35. readline,repl: improve history up/previous

    Reaching the history end caused the last entry to be persistent.
    That way there's no actualy feedback to the user that the history
    end is reached. Instead, visualize the original input line and keep
    the history index at the history end in case the user wants to go
    back again.
    
    PR-URL: #31112
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    BridgeAR authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    2e54a99 View commit details
    Browse the repository at this point in the history
  36. readline: improve getStringWidth()

    1. Simplify the getStringWidth function used by Intl builds by removing
       dead code (the options were unused) and by refactoring the logic.
    2. Improve the getStringWidth unicode handling used by non-Intl builds.
       The getStringWidth function returned the wrong width for multiple
       inputs. It's now improved by supporting various zero width characters
       and more full width characters.
    
    PR-URL: #31112
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    BridgeAR authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    7ba21d0 View commit details
    Browse the repository at this point in the history
  37. readline: move charLengthLeft() and charLengthAt()

    This moves the charLengthLeft() and charLengthAt() into the internal
    readline file. This allows sharing the functions internally with
    other code.
    
    PR-URL: #31112
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    BridgeAR authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    f0506c3 View commit details
    Browse the repository at this point in the history
  38. src: improve GetColumnWidth performance

    This improves the performance in GetColumnWidth for full width
    characters.
    
    PR-URL: #31112
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    BridgeAR authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    d2a10ad View commit details
    Browse the repository at this point in the history
  39. src: change GetStringWidth's expand_emoji_sequence option default

    The option is now set to true by default. Most terminals do not have
    full emoji support and visualize emojis with zero width joiners as
    individual emojis.
    Also verify that at least one argument is always passed through to the
    function and remove support for passing through code points. Only
    accept strings from now on to simplify the API.
    
    PR-URL: #31112
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    BridgeAR authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    e3491d7 View commit details
    Browse the repository at this point in the history
  40. readline,repl: support tabs properly

    PR-URL: #31112
    Fixes: #25272
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    BridgeAR authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    686a3bc View commit details
    Browse the repository at this point in the history
  41. repl: activate previews for lines exceeding the terminal columns

    This improves the completion previews by activating them for lines
    that exceed the current terminal columns.
    As a drive-by fix it also simplifies some statements.
    
    PR-URL: #31112
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    BridgeAR authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    b92d65d View commit details
    Browse the repository at this point in the history
  42. test: add repl tests to verify unicode support in previews

    This also adds a test to verify that changed writer options also
    change the preview output depending on the options.
    
    PR-URL: #31112
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    BridgeAR authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    3c82d5b View commit details
    Browse the repository at this point in the history
  43. util: add todo comments for inspect to add unicode support

    PR-URL: #31112
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    BridgeAR authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    63f4eae View commit details
    Browse the repository at this point in the history
  44. lib: add Uint16Array primordials

    PR-URL: #31210
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Sebastien-Ahkrin authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    0271457 View commit details
    Browse the repository at this point in the history
  45. repl: change preview default in case of custom eval functions

    Custom eval functions might have a very different behavior than the
    current implementation and having a preview in such case might be
    confusing. This changes the preview default to `false` in case a
    custom eval function is used. It is still possible to opt into using
    the previews in case that's still desirable.
    
    PR-URL: #31259
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    BridgeAR authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    b9b044b View commit details
    Browse the repository at this point in the history
  46. doc: add GeoffreyBooth to collaborators

    PR-URL: #31306
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Bryan English <bryan@bryanenglish.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    GeoffreyBooth authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    9c58aa4 View commit details
    Browse the repository at this point in the history
  47. doc: fix a code example in zlib.md

    PR-URL: #31264
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    dragonman225 authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    8e14066 View commit details
    Browse the repository at this point in the history
  48. src: include uv.h in node_binding header

    This was removed in 3bb085d
    but is needed by Electron on Windows, as otherwise compilation errors
    will occur as a result of unknown libuv types.
    
    PR-URL: #31265
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    codebytere authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    06fbc03 View commit details
    Browse the repository at this point in the history
  49. doc: update README to make Node.js description clearer

    Fixes: #24872
    
    PR-URL: #31266
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    carterbancroft authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    deff600 View commit details
    Browse the repository at this point in the history
  50. process: allow monitoring uncaughtException

    Installing an uncaughtException listener has a side effect that process
    is not aborted. This is quite bad for monitoring/logging tools which
    tend to be interested in errors but don't want to cause side effects
    like swallow an exception or change the output on console.
    
    There are some workarounds in the wild like monkey patching emit or
    rethrow in the exception if monitoring tool detects that it is the only
    listener but this is error prone and risky.
    
    This PR allows to install a listener to monitor uncaughtException
    without the side effect to consider the exception has handled.
    
    PR-URL: #31257
    Refs: #30932
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Flarna authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    79eba6a View commit details
    Browse the repository at this point in the history
  51. test: allow disabling crypto tests

    PR-URL: #31268
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    codebytere authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    1df7961 View commit details
    Browse the repository at this point in the history
  52. fs: add missing HandleScope to FileHandle.close

    Fixes: #31202
    
    PR-URL: #31276
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    addaleax authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    b55fba2 View commit details
    Browse the repository at this point in the history
  53. doc: improve doc v8.getHeapSpaceStatistics() 'GetHeapSpaceStatistics'

    Link replaced in v8 getHeapSpaceStatistics function because it was
    showing 404 page not found.
    
    Fixes: #31181
    
    PR-URL: #31274
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    dev-script authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    6184f1a View commit details
    Browse the repository at this point in the history
  54. http2: skip creating native ShutdownWrap

    `ShutdownWrap` instances are being used to carry context between the
    start and the asynchronous end of shutting down the writable side of
    a `StreamBase`. HTTP/2 streams always perform this action
    synchronously, so no such object is necessary.
    
    PR-URL: #31283
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    addaleax authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    52504fb View commit details
    Browse the repository at this point in the history
  55. readline: improve unicode support and tab completion

    1. This reduces the number of write operations used during tab
       completion.
    2. The tab completion calculated the string width using the length
       of the string instead of using the actual width. That is fixed.
    3. The key decoder is now capable of handling characters composed
       out of two code points. That reduces the number of "keypress"
       events that are emitted which again lowers the amount of writes
       triggered.
    
    PR-URL: #31288
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    3881189 View commit details
    Browse the repository at this point in the history
  56. repl,readline: clean up code

    This simplifies code that was more complicated than it had to be
    and removes code that should never be reached.
    
    PR-URL: #31288
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    f8e8059 View commit details
    Browse the repository at this point in the history
  57. tools: add clang-tidy rule in src

    PR-URL: #26840
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    gengjiawen authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    a5311bd View commit details
    Browse the repository at this point in the history
  58. build: test Python 3 using GitHub Actions-based CI

    PR-URL: #29474
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    cclauss authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    7a5d4fa View commit details
    Browse the repository at this point in the history
  59. n-api: add napi_get_all_property_names

    Co-Authored-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    
    PR-URL: #30006
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    himself65 authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    0911813 View commit details
    Browse the repository at this point in the history
  60. tools: ensure consistent perms of signed release files

    Fixes: nodejs/build#1904
    
    PR-URL: #29350
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    rvagg authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    d48f592 View commit details
    Browse the repository at this point in the history
  61. async_hooks: remove internal only error checking

    This error checking is mostly unnecessary and is just a Node core
    developer nicety, rather than something that is needed for the
    user-land. It can be safely removed without any practical
    impact while making nextTick, timers, immediates and AsyncResource
    substantially faster.
    
    PR-URL: #30967
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    apapirovski authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    9d26358 View commit details
    Browse the repository at this point in the history
  62. child_process: remove unnecessary use of inner state

    PR-URL: #29358
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    ckarande authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    2285936 View commit details
    Browse the repository at this point in the history
  63. tools: update JSON header parsing for backticks

    Methods, events, and so on in headers in our documentation may (and
    should) be set off with backticks in the raw markdown. When that
    happens, the headers is misinterpreted by tools/json.js as not being a
    method or event. Update the JSON tool generator to accommodate backticks
    in this situation and add a test for this situation.
    
    Fixes: #31290
    
    PR-URL: #31294
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    49364b0 View commit details
    Browse the repository at this point in the history
  64. test: stricten readline keypress failure test condition

    This verifies that the thrown error is the expected one. That was
    not tested before.
    
    PR-URL: #31300
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    4244080 View commit details
    Browse the repository at this point in the history
  65. repl: fix preview cursor position

    The cusor position was off in case the preview was exactly as long
    as the current terminal was wide.
    
    PR-URL: #31293
    Fixes: #31291
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    c252356 View commit details
    Browse the repository at this point in the history
  66. vm: add code cache support for SourceTextModule

    PR-URL: #31278
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    devsnek authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    27564a4 View commit details
    Browse the repository at this point in the history
  67. deps: upgrade npm to 6.13.6

    PR-URL: #31304
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    ruyadorno authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    985f980 View commit details
    Browse the repository at this point in the history
  68. repl: do not preview while pasting code

    This makes sure no previews are triggered while pasting code. The
    very last character is allowed to trigger the preview. The output
    should be completely identical to the user.
    
    PR-URL: #31315
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    BridgeAR authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    85926d4 View commit details
    Browse the repository at this point in the history
  69. stream: simplify push

    PR-URL: #31150
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    ronag authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    d04118f View commit details
    Browse the repository at this point in the history
  70. doc: document readline key bindings

    This documents all readline key bindings. It is a rework of
    #20825
    
    PR-URL: #31256
    Fixes: #20814
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    HarshithaKP authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    b9aca78 View commit details
    Browse the repository at this point in the history
  71. build: silence c-ares Windows compiler warnings

    Silence the following compiler warning on Windows:
    `inet_addr': Use inet_pton() or InetPton() instead or define
    _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings`
    
    PR-URL: #31311
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    richardlau authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    6b118b4 View commit details
    Browse the repository at this point in the history
  72. build: silence OpenSSL Windows compiler warnings

    Silence the following compiler warning on Windows:
    `'function': different 'const' qualifiers`
    
    PR-URL: #31311
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    richardlau authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    a31eed0 View commit details
    Browse the repository at this point in the history
  73. doc: fix example of parsing request.url

    PR-URL: #31302
    Fixes: #31301
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    NMVikings authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    0608873 View commit details
    Browse the repository at this point in the history
  74. lib: replace BigInt64Array global by the primordials

    PR-URL: #31193
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Sebastien-Ahkrin authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    108046d View commit details
    Browse the repository at this point in the history
  75. doc: add an example for util.types.isExternal

    added usage example for util.types.isExternal
    which was missing owing to the complexity.
    Used a combination of n-api and js to demonstrate
    usage of the api.
    
    PR-URL: #31173
    Fixes: #20604
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    HarshithaKP authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    bb9622b View commit details
    Browse the repository at this point in the history
  76. build: add GitHub actions to run linters

    Add jobs to our GitHub Actions workflow to run our
    various lint Makefile targets. The `setup-node` action
    used to run the JavaScript linter contains problem
    matchers for eslint that will annotate the files in a pull
    request if there are failures.
    
    PR-URL: #31323
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    richardlau authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    0379c31 View commit details
    Browse the repository at this point in the history
  77. build: fix step name in GitHub Actions workflow

    The CI workflow doesn't use the matrix strategy so there is no
    `${{ matrix.node-version }}` variable to use in the `Use Node.js`
    step names.
    
    PR-URL: #31323
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    richardlau authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    a6e1e9c View commit details
    Browse the repository at this point in the history
  78. errors: remove dead code in ERR_INVALID_ARG_TYPE

    Remove unreachable code. As expected is converted to an Array the
    'not ' check will be never executed.
    
    PR-URL: #31322
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Flarna authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    4981f97 View commit details
    Browse the repository at this point in the history
  79. stream: fix async iterator destroyed error propagation

    There was an edge case where if _destroy calls the error callback
    later than one tick the iterator would complete early and not
    propgate the error.
    
    PR-URL: #31314
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    ronag authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    499c41d View commit details
    Browse the repository at this point in the history
  80. doc: fix a code example in crypto.md

    PR-URL: #31313
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    himself65 authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    e1fd6ae View commit details
    Browse the repository at this point in the history
  81. n-api: return napi_invalid_arg on napi_create_bigint_words

    N-API statuses shall be preferred over throwing JavaScript Errors on
    checks occurred in N-APIs.
    
    PR-URL: #31312
    Refs: #29849
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    legendecas authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    c8aa08e View commit details
    Browse the repository at this point in the history
  82. doc: standardize on "host name" in async_hooks.md

    Our docs have a mix of "hostname" and "host name" in prose.
    
    Let's follow the usage of Unix man pages, RFCs, and most
    professionally-edited sources, and use "host name" in prose and
    "hostname" to refer to the command and in code.
    
    Lint rule forthcoming.
    
    PR-URL: #31326
    Refs: #31073
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    6e9f0da View commit details
    Browse the repository at this point in the history
  83. doc: standardize on "host name" in deprecations.md

    Our docs have a mix of "hostname" and "host name" in prose.
    
    Let's follow the usage of Unix man pages, RFCs, and most
    professionally-edited sources, and use "host name" in prose and
    "hostname" to refer to the command and in code.
    
    Lint rule forthcoming.
    
    PR-URL: #31326
    Refs: #31073
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    8055f78 View commit details
    Browse the repository at this point in the history
  84. doc: standardize on "host name" in dgram.md

    Our docs have a mix of "hostname" and "host name" in prose.
    
    Let's follow the usage of Unix man pages, RFCs, and most
    professionally-edited sources, and use "host name" in prose and
    "hostname" to refer to the command and in code.
    
    Lint rule forthcoming.
    
    PR-URL: #31326
    Refs: #31073
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    b8dee45 View commit details
    Browse the repository at this point in the history
  85. doc: standardize on "host name" in errors.md

    Our docs have a mix of "hostname" and "host name" in prose.
    
    Let's follow the usage of Unix man pages, RFCs, and most
    professionally-edited sources, and use "host name" in prose and
    "hostname" to refer to the command and in code.
    
    Lint rule forthcoming.
    
    PR-URL: #31326
    Refs: #31073
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    ece70a8 View commit details
    Browse the repository at this point in the history
  86. doc: standardize on "host name" in fs.md

    Our docs have a mix of "hostname" and "host name" in prose.
    
    Let's follow the usage of Unix man pages, RFCs, and most
    professionally-edited sources, and use "host name" in prose and
    "hostname" to refer to the command and in code.
    
    Lint rule forthcoming.
    
    PR-URL: #31326
    Refs: #31073
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    47f71de View commit details
    Browse the repository at this point in the history
  87. doc: standardize on "host name" in http2.md

    Our docs have a mix of "hostname" and "host name" in prose.
    
    Let's follow the usage of Unix man pages, RFCs, and most
    professionally-edited sources, and use "host name" in prose and
    "hostname" to refer to the command and in code.
    
    Lint rule forthcoming.
    
    PR-URL: #31326
    Refs: #31073
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    600eb8b View commit details
    Browse the repository at this point in the history
  88. doc: standardize on "host name" in https.md

    Our docs have a mix of "hostname" and "host name" in prose.
    
    Let's follow the usage of Unix man pages, RFCs, and most
    professionally-edited sources, and use "host name" in prose and
    "hostname" to refer to the command and in code.
    
    Lint rule forthcoming.
    
    PR-URL: #31326
    Refs: #31073
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    bac588e View commit details
    Browse the repository at this point in the history
  89. doc: standardize on "host name" in net.md

    Our docs have a mix of "hostname" and "host name" in prose.
    
    Let's follow the usage of Unix man pages, RFCs, and most
    professionally-edited sources, and use "host name" in prose and
    "hostname" to refer to the command and in code.
    
    Lint rule forthcoming.
    
    PR-URL: #31326
    Refs: #31073
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    94122f6 View commit details
    Browse the repository at this point in the history
  90. doc: standardize on "host name" in os.md

    Our docs have a mix of "hostname" and "host name" in prose.
    
    Let's follow the usage of Unix man pages, RFCs, and most
    professionally-edited sources, and use "host name" in prose and
    "hostname" to refer to the command and in code.
    
    Lint rule forthcoming.
    
    PR-URL: #31326
    Refs: #31073
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    baeabff View commit details
    Browse the repository at this point in the history
  91. doc: standardize on "host name" in tls.md

    Our docs have a mix of "hostname" and "host name" in prose.
    
    Let's follow the usage of Unix man pages, RFCs, and most
    professionally-edited sources, and use "host name" in prose and
    "hostname" to refer to the command and in code.
    
    Lint rule forthcoming.
    
    PR-URL: #31326
    Refs: #31073
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    2824527 View commit details
    Browse the repository at this point in the history
  92. doc: standardize on "host name" in url.md

    Our docs have a mix of "hostname" and "host name" in prose.
    
    Let's follow the usage of Unix man pages, RFCs, and most
    professionally-edited sources, and use "host name" in prose and
    "hostname" to refer to the command and in code.
    
    Lint rule forthcoming.
    
    PR-URL: #31326
    Refs: #31073
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    aedbfdb View commit details
    Browse the repository at this point in the history
  93. module: add API for interacting with source maps

    PR-URL: #31132
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    bcoe authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    4dced02 View commit details
    Browse the repository at this point in the history
  94. build: fix macos runner type in GitHub Action

    PR-URL: #31327
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    himself65 authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    b2180d9 View commit details
    Browse the repository at this point in the history
  95. deps: upgrade to libuv 1.34.1

    Notable changes:
    
    - uv_fs_copyfile() now supports CIFS share destinations.
    - isatty() now works on IBMi
    - TTYs are opened with the O_NOCTTY flag.
    
    Fixes: #31170
    
    PR-URL: #31332
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    cjihrig authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    51e4a56 View commit details
    Browse the repository at this point in the history
  96. deps: V8: cherry-pick b9d33036e9a8

    Original commit message:
    
        [coverage] Improve whitespace precision of coverage reporting
    
        This CL improves whitespace precision of coverage around try blocks;
        previously a small portion of whitespace could be reported as uncovered
        between try blocks and catch and/or finally blocks.
    
        Change-Id: I763ae3d15106c88f2278cf8893c12b0869a62528
        Fixed: v8:10030
        Bug: v8:10030
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1962265
        Reviewed-by: Toon Verwaest <verwaest@chromium.org>
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#65593}
    
    Refs: v8/v8@b9d3303
    
    PR-URL: #31335
    Refs: #25937
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    bcoe authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    d62d06b View commit details
    Browse the repository at this point in the history
  97. build: add vs2019 to vcbuild.bat help

    PR-URL: #31338
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    richardlau authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    f11406d View commit details
    Browse the repository at this point in the history
  98. build: remove enable_vtune from vcbuild.bat

    vcbuild.bat wasn't updated when vtune support was removed in
    #28522
    
    Refs: #28522
    PR-URL: #31338
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    richardlau authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    55e2b4e View commit details
    Browse the repository at this point in the history
  99. deps: V8: cherry-pick d89f4ef1cd62

    Original commit message:
    
        S390x: improve performance by skipping Debug Hook if not needed
    
        Change-Id: Ib4b2821f2941cdc131f9c75b89a3baced7554f8d
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991802
        Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
        Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
        Cr-Commit-Position: refs/heads/master@{#65644}
    
    Refs: v8/v8@d89f4ef
    
    PR-URL: #31354
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Milad Farazmand authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    6d6a3e4 View commit details
    Browse the repository at this point in the history
  100. src: use uv_guess_handle() to detect TTYs

    This commit reverts #30829
    and uses uv_guess_handle() instead of isatty(). The IBMi
    changes are no longer required, as of libuv 1.34.1.
    
    PR-URL: #31333
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    cjihrig authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    6534c6c View commit details
    Browse the repository at this point in the history
  101. doc: add missing code formatting in vm.md

    This commit adds missing code formatting in a few places in
    the vm module documentation.
    
    PR-URL: #31350
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    cjihrig authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    aed00d7 View commit details
    Browse the repository at this point in the history
  102. src: fix performance regression in node_file.cc

    Commits dcb6929, 4396beb and 8a96d05 turned the O(n) scan in
    InternalModuleReadJSON() into an O(4n) scan. Fix the performance
    regression by turning that into a linear scan again.
    
    PR-URL: #31343
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    bnoordhuis authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    83f7b5a View commit details
    Browse the repository at this point in the history
  103. tools: update remark-preset-lint-node to 1.12.0

    This adds linting for "hostname" in prose.
    
    PR-URL: #31359
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    29e0465 View commit details
    Browse the repository at this point in the history
  104. tools: remove obsolete dependencies

    Remove rollup dependencies in markdown linting tool's package.json. We
    use @zeit/ncc.
    
    PR-URL: #31359
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    5dd6fb1 View commit details
    Browse the repository at this point in the history
  105. module: unflag conditional exports

    PR-URL: #31001
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    guybedford authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    ea27e16 View commit details
    Browse the repository at this point in the history
  106. benchmark: add default type in getstringwidth.js

    This fixes a benchmark test that was recently broken by a breaking
    change on the master branch.
    
    Fixes: #31372
    
    PR-URL: #31377
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Trott authored and MylesBorins committed Jan 16, 2020
    Copy the full SHA
    6e978f7 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2020

  1. module: fix check exports issue in cjs module loading

    Refs: #31001 (comment)
    
    PR-URL: #31427
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    guybedford authored and codebytere committed Jan 21, 2020
    Copy the full SHA
    cb27c2b View commit details
    Browse the repository at this point in the history
  2. test,module: add test for exports cjs loader check

    Refs: #31001 (comment)
    
    PR-URL: #31427
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Trott authored and codebytere committed Jan 21, 2020
    Copy the full SHA
    cbd84c5 View commit details
    Browse the repository at this point in the history
  3. 2020-01-21, Version 13.7.0 (Current)

    Notable changes:
    
    * deps:
      * upgrade to libuv 1.34.1 (cjihrig) #31332
      * upgrade npm to 6.13.6 (Ruy Adorno) #31304
    * module
      * add API for interacting with source maps (bcoe) #31132
      * loader getSource, getFormat, transform hooks (Geoffrey Booth) #30986
      * logical conditional exports ordering (Guy Bedford) #31008
      * unflag conditional exports (Guy Bedford) #31001
    * process:
      * allow monitoring uncaughtException (Gerhard Stoebich) #31257
    * Added new collaborators:
      * [GeoffreyBooth](https://github.com/GeoffreyBooth) - Geoffrey Booth. #31306
    
    PR-URL: #31382
    codebytere committed Jan 21, 2020
    Copy the full SHA
    bbab963 View commit details
    Browse the repository at this point in the history