Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: don't emit 'close' twice if emitClose enabled #31383

Closed
wants to merge 3 commits into from
Closed

fs: don't emit 'close' twice if emitClose enabled #31383

wants to merge 3 commits into from

Commits on Jan 16, 2020

  1. fs: don't emit 'close' twice if emitClose enabled 

    fs streams have some backwards compat behavior that does not
behave well if emitClose: true is passed in options. This
fixes this edge case until the backwards compat is removed.

Fixes: nodejs#31366
    @ronag
    ronag committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    d388a35 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2020

  1. fixup: test

    @ronag
    ronag committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    5fac02f View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2020

  1. fixup

    @ronag
    ronag committed Jan 18, 2020
    Configuration menu
    Copy the full SHA
    26febd6 View commit details
    Browse the repository at this point in the history