Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make fs.read params optional #31402

Closed
wants to merge 17 commits into from
Closed

feat: make fs.read params optional #31402

wants to merge 17 commits into from

Commits on Jan 17, 2020

  1. feat: make fs.read params optional 

    This makes all the parameters of the `fs.read` function, except
for `fd` and the callback(when not using as a promise) optional.

They will default to sensible defaults

fixes nodejs#31237
    @lholmquist
    lholmquist committed Jan 17, 2020
    Copy the full SHA
    95f03ef View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2020

  1. squash: doc updates

    @lholmquist
    lholmquist committed Jan 22, 2020
    Copy the full SHA
    478d2f0 View commit details
    Browse the repository at this point in the history

  2. squash: adding in test

    @lholmquist
    lholmquist committed Jan 22, 2020
    Copy the full SHA
    10d3902 View commit details
    Browse the repository at this point in the history

  3. squash: better use of destructoring

    @lholmquist
    lholmquist committed Jan 22, 2020
    Copy the full SHA
    dfdd3b4 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2020

  1. squash: refactor. 

    now using the options object instead of making all things optional
    @lholmquist
    lholmquist committed Feb 11, 2020
    Copy the full SHA
    cf320a0 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2020

  1. squash: Update doc/api/fs.md 

    Co-Authored-By: Richard Lau <riclau@uk.ibm.com>
    @lholmquist @richardlau
    lholmquist and richardlau committed Feb 12, 2020
    Copy the full SHA
    418b6fd View commit details
    Browse the repository at this point in the history

  2. squash: Update doc/api/fs.md 

    Co-Authored-By: Richard Lau <riclau@uk.ibm.com>
    @lholmquist @richardlau
    lholmquist and richardlau committed Feb 12, 2020
    Copy the full SHA
    e3835c2 View commit details
    Browse the repository at this point in the history

  3. squash: reverting some doc updates

    @lholmquist
    lholmquist committed Feb 12, 2020
    Copy the full SHA
    128aeab View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2020

  1. squash: Update doc/api/fs.md 

    Co-Authored-By: James M Snell <jasnell@gmail.com>
    @lholmquist @jasnell
    lholmquist and jasnell committed Feb 13, 2020
    Copy the full SHA
    2c5d3e7 View commit details
    Browse the repository at this point in the history

  2. squash: Update doc/api/fs.md 

    Co-Authored-By: James M Snell <jasnell@gmail.com>
    @lholmquist @jasnell
    lholmquist and jasnell committed Feb 13, 2020
    Copy the full SHA
    6433727 View commit details
    Browse the repository at this point in the history

  3. squash: add test for promise based

    @lholmquist
    lholmquist committed Feb 13, 2020
    Copy the full SHA
    3923975 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2020

  1. squash: add defaults to filehandler.read docs

    @lholmquist
    lholmquist committed Feb 14, 2020
    Copy the full SHA
    f6f01b6 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2020

  1. squash: add the use case for an optional options object

    @lholmquist
    lholmquist committed Feb 26, 2020
    Copy the full SHA
    55a2356 View commit details
    Browse the repository at this point in the history

  2. squash: add test for optional options option

    @lholmquist
    lholmquist committed Feb 26, 2020
    Copy the full SHA
    f86bdc1 View commit details
    Browse the repository at this point in the history

  3. squash: a little more doc update

    @lholmquist
    lholmquist committed Feb 26, 2020
    Copy the full SHA
    a4c3763 View commit details
    Browse the repository at this point in the history

  4. squash: doc linting

    @lholmquist
    lholmquist committed Feb 26, 2020
    Copy the full SHA
    e321b88 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2020

  1. squash: combine tests and add another test that passes options

    @lholmquist
    lholmquist committed Mar 6, 2020
    Copy the full SHA
    cb8c0ef View commit details
    Browse the repository at this point in the history