Commits on Apr 1, 2020

1. test: refactor common.expectsError …

   This completely refactors the `expectsError` behavior: so far it's
   almost identical to `assert.throws(fn, object)` in case it was used
   with a function as first argument. It had a magical property check
   that allowed to verify a functions `type` in case `type` was passed
   used in the validation object. This pattern is now completely removed
   and `assert.throws()` should be used instead.
   
   The main intent for `common.expectsError()` is to verify error cases
   for callback based APIs. This is now more flexible by accepting all
   validation possibilites that `assert.throws()` accepts as well. No
   magical properties exist anymore. This reduces surprising behavior
   for developers who are not used to the Node.js core code base.
   
   This has the side effect that `common` is used significantly less
   frequent.
   
   Backport-PR-URL: nodejs#31449
   PR-URL: nodejs#31092
   Reviewed-By: Rich Trott <rtrott@gmail.com>
   Reviewed-By: James M Snell <jasnell@gmail.com>
   Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

   

   BridgeAR authored and MylesBorins committed Apr 1, 2020
   Copy the full SHA

   7e1c8e6 View commit details

   Browse the repository at this point in the history