Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: use let and const instead of var #31518

Closed
wants to merge 1 commit into from
Closed

benchmark: use let and const instead of var #31518

wants to merge 1 commit into from

Conversation

dnlup
Copy link
Contributor

@dnlup dnlup commented Jan 26, 2020

Use let and const in domain, es, events, fixtures, fs, http,
http2 and misc.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

I tried to run the modified benchmarks and a few of them are failing:

http benchmark

Screenshot from 2020-01-26 12-13-30

http2 benchmark

Screenshot from 2020-01-26 12-14-44

misc benchmark

Screenshot from 2020-01-26 12-15-27

@dnlup
benchmark: use let and const instead of var
aff86f9 
Use let and const in domain, es, events, fixtures, fs, http,
http2 and misc.
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. domain Issues and PRs related to the domain subsystem. events Issues and PRs related to the events subsystem / EventEmitter. fs Issues and PRs related to the fs subsystem / file system. http Issues or PRs related to the http subsystem. http2 Issues or PRs related to the http2 subsystem. v8 engine Issues and PRs related to the V8 dependency. labels Jan 26, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 28, 2020 •
edited by addaleax

CI: https://ci.nodejs.org/job/node-test-pull-request/28733/ (:white_check_mark:)

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. and removed v8 engine Issues and PRs related to the V8 dependency. domain Issues and PRs related to the domain subsystem. events Issues and PRs related to the events subsystem / EventEmitter. fs Issues and PRs related to the fs subsystem / file system. http Issues or PRs related to the http subsystem. http2 Issues or PRs related to the http2 subsystem. labels Jan 28, 2020
Trott pushed a commit that referenced this pull request Jan 29, 2020
@dnlup @Trott
benchmark: use let and const instead of var
0f89419 
Use let and const in domain, es, events, fixtures, fs, http,
http2 and misc.

PR-URL: #31518
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Jan 29, 2020

Landed in 0f89419

@Trott Trott closed this Jan 29, 2020
@dnlup dnlup deleted the refactor/benchmark branch January 31, 2020 15:48
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@dnlup @codebytere
benchmark: use let and const instead of var
eb3c6e9 
Use let and const in domain, es, events, fixtures, fs, http,
http2 and misc.

PR-URL: #31518
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@dnlup @codebytere
benchmark: use let and const instead of var
ce3f3ef 
Use let and const in domain, es, events, fixtures, fs, http,
http2 and misc.

PR-URL: #31518
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@dnlup @codebytere
benchmark: use let and const instead of var
46cc34d 
Use let and const in domain, es, events, fixtures, fs, http,
http2 and misc.

PR-URL: #31518
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@dnlup @codebytere
benchmark: use let and const instead of var
2973c1f 
Use let and const in domain, es, events, fixtures, fs, http,
http2 and misc.

PR-URL: #31518
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. review wanted PRs that need reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dnlup @nodejs-github-bot @Trott @addaleax