Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use symbol to store AsyncWrap resource #31745

Closed
wants to merge 2 commits into from
Closed

src: use symbol to store AsyncWrap resource #31745

wants to merge 2 commits into from

Commits on May 19, 2020

  1. src: use symbol to store AsyncWrap resource 

    Use a symbol on the bindings object to store the public resource object,
rather than a `v8::Global` Persistent. This has several advantages:

- It’s harder to inadvertently create memory leaks this way.
  The garbage collector sees the `AsyncWrap` →  resource link like
  a regular JS property, and can collect the objects as a group,
  even if the resource object should happen to point back to the
  `AsyncWrap` object.
- This will make it easier in the future to use `owner_symbol` for
  this purpose, which is generally the direction we should be moving
  the `async_hooks` API into (i.e. using more public objects instead
  of letting internal wires stick out).
    @addaleax
    addaleax committed May 19, 2020
    Copy the full SHA
    dd44bb9 View commit details
    Browse the repository at this point in the history

  2. fixup! src: use symbol to store AsyncWrap resource

    @addaleax
    addaleax committed May 19, 2020
    Copy the full SHA
    a6b337d View commit details
    Browse the repository at this point in the history