benchmark: reland test refactoring #31755
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
assert
BridgeAR
force-pushed
the
2020-02-12-reland-benchmark-test-refactoring
branch
from
4bbf411
to
0074942
Compare
addaleax
approved these changes
Feb 12, 2020
|
Benchmark test CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12163/ ✔️ |
mscdex
reviewed
Feb 12, 2020
BridgeAR
added
the
author ready
vdeturckheim
approved these changes
Feb 14, 2020
Trott
approved these changes
Feb 15, 2020
addaleax
removed
the
author ready
|
This needs a rebase. |
BridgeAR
force-pushed
the
2020-02-12-reland-benchmark-test-refactoring
branch
from
5b12cbc
to
778b2a6
Compare
BridgeAR
added
the
author ready
|
Landed in 9e69d97...bb6125b 🎉 |
Merged
targos
added
backport-blocked-v12.x
and removed
author ready
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
This reverts commit 5b0308c. PR-URL: nodejs#31755 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
This reverts commit 4671d55 and contains a fix to the issue raised for the revert. PR-URL: nodejs#31755 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
This reverts commit aa0a01b. PR-URL: nodejs#31755 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
This reverts commit 7cfbc9f. PR-URL: nodejs#31755 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#31396 was reverted in #31722. The issue was that WRK is not able to handle decimal times (and the minimum possible time is one second) and the threads must not be higher than the number of connections.
I just reverted the revert and added a fixup commit to fix the actual issue. The commit message might be changed during landing?
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes