Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12.16.1 proposal #31781

Closed
wants to merge 12 commits into from
Closed

v12.16.1 proposal #31781

wants to merge 12 commits into from

Commits on Feb 13, 2020

  1. src: fix -Winconsistent-missing-override warning

    This commit addresses the following warning:
    
    ../src/node_api.cc:28:19: warning: 'mark_arraybuffer_as_untransferable'
    overrides a member function but is not marked 'override'
          [-Winconsistent-missing-override]
      v8::Maybe<bool> mark_arraybuffer_as_untransferable(
                      ^
    ../src/js_native_api_v8.h:42:27: note: overridden virtual function is here
      virtual v8::Maybe<bool> mark_arraybuffer_as_untransferable(
    
    PR-URL: #30549
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    cjihrig authored and targos committed Feb 13, 2020
    Copy the full SHA
    7a5954e View commit details
    Browse the repository at this point in the history
  2. module: 12.x self resolve flag as experimental modules

    PR-URL: #31757
    Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    guybedford authored and MylesBorins committed Feb 13, 2020
    Copy the full SHA
    f0b2d87 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2020

  1. src: keep main-thread Isolate attached to platform during Dispose

    This works around a situation in which the V8 WASM code calls
    into the platform while the Isolate is being disposed.
    
    This goes against the V8 API constract for `v8::Platform`.
    In lieu of a proper fix, it should be okay to keep the Isolate
    registered; the race condition fixed by 25447d8 cannot
    occur for the `NodeMainInstance`’s Isolate, as it is the last
    one to exit in any given Node.js process.
    
    This partially reverts 25447d8.
    
    Refs: #30909
    Refs: #31752
    
    PR-URL: #31795
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax committed Feb 14, 2020
    Copy the full SHA
    43d02e2 View commit details
    Browse the repository at this point in the history
  2. Revert "build: warn upon --use-largepages config option"

    This reverts commit f5cd6d7.
    
    PR-URL: #31782
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    MylesBorins authored and addaleax committed Feb 14, 2020
    Copy the full SHA
    6d43299 View commit details
    Browse the repository at this point in the history
  3. Revert "src: make large_pages node.cc include conditional"

    This reverts commit 5e232f5.
    
    PR-URL: #31782
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    MylesBorins authored and addaleax committed Feb 14, 2020
    Copy the full SHA
    3d5beeb View commit details
    Browse the repository at this point in the history
  4. Revert "build: switch realpath to pwd"

    This reverts commit dea40f8.
    
    PR-URL: #31782
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    MylesBorins authored and addaleax committed Feb 14, 2020
    Copy the full SHA
    a53eeca View commit details
    Browse the repository at this point in the history
  5. Revert "build: re-introduce --use-largepages as no-op"

    This reverts commit 5fcf542.
    
    PR-URL: #31782
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    MylesBorins authored and addaleax committed Feb 14, 2020
    Copy the full SHA
    7a1b0ac View commit details
    Browse the repository at this point in the history
  6. Revert "src: make --use-largepages a runtime option"

    This reverts commit fcbd2d2.
    
    PR-URL: #31782
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    MylesBorins authored and addaleax committed Feb 14, 2020
    Copy the full SHA
    065a32f View commit details
    Browse the repository at this point in the history
  7. async_hooks: ensure event after been emitted on runInAsyncScope

    The exception handler user-defined will not automatically emit after
    for the async resource.
    
    Also removes a duplicated case
    `test-emit-after-uncaught-exception-runInAsyncScope.js`
    which is identical to test-emit-after-uncaught-exception.js.
    
    Refs: #30965
    PR-URL: #31784
    Fixes: #31783
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    legendecas authored and addaleax committed Feb 14, 2020
    Copy the full SHA
    51fdd75 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2020

  1. Revert "events: allow monitoring error events"

    This reverts commit 5cb0de9.
    MylesBorins committed Feb 18, 2020
    Copy the full SHA
    a5bc00a View commit details
    Browse the repository at this point in the history
  2. src: inform callback scopes about exceptions in HTTP parser

    Refs: 4aca277
    Refs: #30236
    Fixes: #31796
    
    PR-URL: #31801
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    addaleax authored and MylesBorins committed Feb 18, 2020
    Copy the full SHA
    42b68a4 View commit details
    Browse the repository at this point in the history
  3. 2020-02-18, Version 12.16.1 'Erbium' (LTS)

    Notable changes:
    
    Node.js 12.16.0 included 6 regressions that are being fixed in this
    release
    
    Accidental Unflagging of Self Resolving Modules:
    
    12.16.0 included a large update to the ESM implementation. One of the
    new features, Self Referential Modules, was accidentally released
    without requiring the `--experimental-modules` flag. This release is
    being made to appropriately flag the feature.
    
    Process Cleanup Changed Introduced WASM-Related Assertion:
    
    A change during Node.js process cleanup led to a crash in combination
    with specific usage of WASM. This has been fixed by partially reverted
    said change. A regression test and a full fix are being worked on and
    will likely be included in future 12.x and 13.x releases.
    
    Use Largepages Runtime Option Introduced Linking Failure:
    
    A Semver-Minor change to introduce `--use-largepages` as a runtime
    option introduced a linking failure. This had been fixed in master but
    regressed as the fix has not yet gone out in a Current release. The
    feature has been reverted, but will be able to reland with a fix in a
    future Semver-Minor release.
    
    Async Hooks was Causing an Exception When Handling Errors:
    
    Changes in async hooks internals introduced a case where an internal
    api call could be called with undefined causing a process to crash. The
    change to async hooks was reverted. A regression test and fix has been
    proposed and the change could re-land in a future Semver-Patch release
    if the regression is reliably fixed.
    
    New Enumerable Read-Only Property on EventEmitter breaks @types/extend:
    
    A new property for enumerating events was added to the EventEmitter
    class. This broke existing code that was using the `@types/extend`
    module for extending classses as `@types/extend` was attemping to write
    over the existing field which the new change made read-only. As this is
    the first property on EventEmitter that is read-only this feature could
    be considered Semver-Major. The new feature has been reverted but could
    re-land in a future Semver-Minor release if a non breaking way of
    applying it is found.
    
    Exceptions in the HTTP parser were not emitting an uncaughtException:
    
    A refactoring to Node.js interanls resulted in a bug where errors in
    the HTTP parser were not being emitted by
    process.on('uncaughtException') when the `async_hooks` `after` hook
    exists. The fix to this bug has been included in this release.
    
    PR-URL: #31781
    MylesBorins committed Feb 18, 2020
    Copy the full SHA
    5263cc4 View commit details
    Browse the repository at this point in the history