Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: inform callback scopes about exceptions in HTTP parser #31801

Closed
wants to merge 1 commit into from
Closed

src: inform callback scopes about exceptions in HTTP parser #31801

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Refs: 4aca277
Refs: #30236
Fixes: #31796

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. labels Feb 14, 2020
@addaleax addaleax mentioned this pull request Feb 14, 2020
Closed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 14, 2020 •
edited by addaleax

CI: https://ci.nodejs.org/job/node-test-pull-request/29141/ (:white_check_mark:)

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 15, 2020
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2020
Closed
2 tasks
addaleax added a commit that referenced this pull request Feb 18, 2020
@addaleax
src: inform callback scopes about exceptions in HTTP parser
fab3eff 
Refs: 4aca277
Refs: #30236
Fixes: #31796

PR-URL: #31801
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@addaleax
Copy link
Member Author

Landed in fab3eff

@addaleax addaleax closed this Feb 18, 2020
@addaleax addaleax deleted the http-parser-callbackscope branch February 18, 2020 01:58
MylesBorins pushed a commit that referenced this pull request Feb 18, 2020
@addaleax @MylesBorins
src: inform callback scopes about exceptions in HTTP parser
42b68a4 
Refs: 4aca277
Refs: #30236
Fixes: #31796

PR-URL: #31801
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
This was referenced Feb 18, 2020
Merged
Closed
codebytere pushed a commit that referenced this pull request Feb 27, 2020
@addaleax @codebytere
src: inform callback scopes about exceptions in HTTP parser
98d262e 
Refs: 4aca277
Refs: #30236
Fixes: #31796

PR-URL: #31801
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@codebytere codebytere mentioned this pull request Feb 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

12.16/13.8: http response listener throwing does not result in emit of uncaughtException
4 participants
@addaleax @nodejs-github-bot @jasnell @devnexen