Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: fix broken pipeline error propagation #31835

Closed
wants to merge 4 commits into from
Closed

stream: fix broken pipeline error propagation #31835

wants to merge 4 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Feb 17, 2020 •
edited

If the destination was an async function any error thrown from that function would be swallowed.

EDITED

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag ronag force-pushed the stream-pipeline-broken-test branch from 2b052e0 to ca5b7ff Compare February 17, 2020 20:29
@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Feb 17, 2020
@ronag ronag requested a review from mcollina February 20, 2020 19:47
@ronag ronag force-pushed the stream-pipeline-broken-test branch from eae965f to d1533fe Compare February 21, 2020 11:50
@ronag
Copy link
Member Author

ronag commented Feb 21, 2020

Confusion resolved. There was a .catch(...) after .then(...) which was swallowing errors.

@nodejs/streams PTAL

@ronag ronag force-pushed the stream-pipeline-broken-test branch from 22b2dd6 to d0860a6 Compare February 21, 2020 11:54
@ronag ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 21, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29260/

@ronag ronag force-pushed the stream-pipeline-broken-test branch 3 times, most recently from ce8e95d to d3df498 Compare February 21, 2020 13:47
@ronag ronag changed the title stream: fix broken pipeline tests stream: fix broken pipeline error propagation Feb 21, 2020
@ronag
stream: fix broken pipeline error propagation
f07a2d1 
If the destination was an async function any
error thrown from that function would be swallowed.
@ronag ronag force-pushed the stream-pipeline-broken-test branch from d3df498 to f07a2d1 Compare February 21, 2020 18:15
mcollina
mcollina approved these changes Feb 22, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29277/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29280/

lundibundi
lundibundi approved these changes Feb 22, 2020
View reviewed changes
test/parallel/test-stream-pipeline-uncaught.js Outdated Show resolved Hide resolved
test/parallel/test-stream-pipeline-uncaught.js Outdated Show resolved Hide resolved
ronag and others added 2 commits February 22, 2020 22:23
@ronag @lundibundi
Update test/parallel/test-stream-pipeline-uncaught.js
f4a1245 
Co-Authored-By: Denys Otrishko <shishugi@gmail.com>
@ronag
fixup: nits
40c0b13
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29296/

ronag added a commit that referenced this pull request Feb 24, 2020
@ronag
stream: fix broken pipeline error propagation
db28739 
If the destination was an async function any
error thrown from that function would be swallowed.

PR-URL: #31835
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@ronag
Copy link
Member Author

ronag commented Feb 24, 2020

Landed in db28739

@ronag ronag closed this Feb 24, 2020
ronag added a commit to nxtedition/node that referenced this pull request Feb 27, 2020
@ronag
stream: fix broken pipeline error propagation
21a0dd0 
If the destination was an async function any
error thrown from that function would be swallowed.

Backport-PR-URL: nodejs#31975
PR-URL: nodejs#31835
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 1, 2020
@ronag @codebytere
stream: fix broken pipeline error propagation
313ecaa 
If the destination was an async function any
error thrown from that function would be swallowed.

Backport-PR-URL: #31975
PR-URL: #31835
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@codebytere codebytere mentioned this pull request Mar 1, 2020
Merged
@targos
Copy link
Member

targos commented Apr 20, 2020

Should this land on v12.x-staging? If so, please open a backport PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@mcollina mcollina mcollina approved these changes

@lundibundi lundibundi lundibundi approved these changes

@mafintosh mafintosh Awaiting requested review from mafintosh

@lpinca lpinca Awaiting requested review from lpinca

@BridgeAR BridgeAR Awaiting requested review from BridgeAR

@benjamingr benjamingr Awaiting requested review from benjamingr

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ronag @nodejs-github-bot @targos @mcollina @Trott @benjamingr @lundibundi