Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove flaky designation for test-net-connect-options-port #31841

Closed
wants to merge 0 commits into from
Closed

test: remove flaky designation for test-net-connect-options-port #31841

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 18, 2020

Closes: #23207

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 18, 2020
@Trott Trott mentioned this pull request Feb 18, 2020
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29195/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29198/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29228/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 20, 2020
Trott added a commit to Trott/io.js that referenced this pull request Feb 20, 2020
@Trott
test: remove flaky designation for test-net-connect-options-port
cdac185 
Closes: nodejs#23207

PR-URL: nodejs#31841
Fixes: nodejs#23207
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@Trott Trott closed this Feb 20, 2020
@Trott
Copy link
Member Author

Trott commented Feb 20, 2020

Landed in cdac185

@Trott Trott deleted the unmark-it branch February 20, 2020 16:01
@sthagen sthagen mentioned this pull request Feb 20, 2020
Merged
4 tasks
codebytere pushed a commit that referenced this pull request Feb 27, 2020
@Trott @codebytere
test: remove flaky designation for test-net-connect-options-port
7d5776e 
Closes: #23207

PR-URL: #31841
Fixes: #23207
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@codebytere codebytere mentioned this pull request Feb 29, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@Trott @codebytere
test: remove flaky designation for test-net-connect-options-port
86cd207 
Closes: #23207

PR-URL: #31841
Fixes: #23207
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@Trott @codebytere
test: remove flaky designation for test-net-connect-options-port
58b2f86 
Closes: #23207

PR-URL: #31841
Fixes: #23207
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@Trott @codebytere
test: remove flaky designation for test-net-connect-options-port
bde5a9b 
Closes: #23207

PR-URL: #31841
Fixes: #23207
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flaky: test-net-connect-options-port
5 participants
@Trott @nodejs-github-bot @lpinca @cjihrig @devnexen