module: disable conditional exports, self resolve warnings #31845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
guybedford
added
modules-agenda
|
//cc @nodejs/modules-active-members |
|
I've gone ahead and also added the commit here to remove the experimental ES module warning. |
ljharb
reviewed
Feb 18, 2020
guybedford
force-pushed
the
remove-experimental-exports-warnings
branch
from
38eef00
to
5c339fd
Compare
guybedford
force-pushed
the
remove-experimental-exports-warnings
branch
from
5c339fd
to
0ce99ad
Compare
jkrems
approved these changes
Feb 20, 2020
GeoffreyBooth
approved these changes
Feb 21, 2020
|
I've gone ahead and removed the experimental modules warnings removals from this PR, as per discussion in the meeting. |
ljharb
reviewed
Feb 26, 2020
guybedford
force-pushed
the
remove-experimental-exports-warnings
branch
from
0760a08
to
fd2c05b
Compare
guybedford
removed
modules-agenda
guybedford
added a commit
that referenced
this pull request
Feb 26, 2020
PR-URL: #31845 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
|
Landed in 49ad161. |
4 tasks
codebytere
pushed a commit
that referenced
this pull request
Feb 27, 2020
PR-URL: #31845 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Merged
targos
pushed a commit
that referenced
this pull request
Apr 18, 2020
PR-URL: #31845 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
|
Just tracked this down & wanted to say thanks for all your awesome work @guybedford 🙏😄 |
|
This lands cleanly on v12.x-staging but the test fails, even if I add |
|
Actually sorry that's already landed of course... ok let me look into this. |
guybedford
added a commit
to guybedford/node
that referenced
this pull request
Apr 21, 2020
PR-URL: nodejs#31845 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
4 tasks
targos
added a commit
that referenced
this pull request
Apr 24, 2020
Notable changes:
Dependencies:
* Updated OpenSSL to 1.1.1f.
#32583
* Updated c-ares to 1.16.0.
#32246
* Updated experimental uvwasi to 0.0.6.
#32309
ESM (experimental):
* Additional warnings are no longer printed for modules that use
conditional exports or package name self resolution.
#31845
PR-URL: #33009
targos
added a commit
that referenced
this pull request
Apr 27, 2020
Notable changes:
Dependencies:
* Updated OpenSSL to 1.1.1f.
#32583
* Updated c-ares to 1.16.0.
#32246
* Updated experimental uvwasi to 0.0.6.
#32309
ESM (experimental):
* Additional warnings are no longer printed for modules that use
conditional exports or package name self resolution.
#31845
PR-URL: #33009
targos
added a commit
that referenced
this pull request
Apr 27, 2020
Notable changes:
Dependencies:
* Updated OpenSSL to 1.1.1g.
#32971
* Updated c-ares to 1.16.0.
#32246
* Updated experimental uvwasi to 0.0.6.
#32309
ESM (experimental):
* Additional warnings are no longer printed for modules that use
conditional exports or package name self resolution.
#31845
PR-URL: #33009
targos
added a commit
that referenced
this pull request
Apr 28, 2020
Notable changes:
Dependencies:
* Updated OpenSSL to 1.1.1g.
#32971
* Updated c-ares to 1.16.0.
#32246
* Updated experimental uvwasi to 0.0.6.
#32309
ESM (experimental):
* Additional warnings are no longer printed for modules that use
conditional exports or package name self resolution.
#31845
PR-URL: #33009
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the experimental warnings for using conditional exports and package self resolution, while keeping these features as experimental.
Currently the warnings are inhibiting usage of conditional exports (see #31819 and discussion at nodejs/modules#485), such that removing them will allow us to get more usage feedback.
At this stage it seems worthwhile to remove the warnings at this point to ensure we have adequate usage and feedback prior to unflagging on the 12.x backport.
We discussed this as a possibility at the last meeting, but it still needs approval from the modules group, so marking as an agenda item there and blocked for landing.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes